From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1C51A49671 for ; Fri, 16 Feb 2024 03:29:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E755C68D290; Fri, 16 Feb 2024 05:29:16 +0200 (EET) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 26DC868CFDD for ; Fri, 16 Feb 2024 05:29:10 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 450D8240003 for ; Fri, 16 Feb 2024 03:29:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1708054149; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oq9JoCz1pxZ+MaKmsqxfiOKEq9hsX5dkDUs+nasspZY=; b=EnhJKMaQ/ENYI+LvDJF9mpADHt0fPe81ixYRTCZL3ktoiJInsAUGNQuYGSb0MOFFDMq8zT ULJP4lJ0FivxJL/UeyCiIbSrm7bPeFOUQ91Sc/bc2ruj5aBmsKXKDtyQ0oY1o/oXV7Ru6h ej+cXzvtTSVLHTv/PAuATJRD2g8PuqquGJhjGUpZrUblqZqZktcqisb3bRRZ7KnnxG/Y8U cEDregrX+ncCbSaIU+2KwArzwPsFXZwIezUFfh0OXdY1O9HCE+Fxslfd3z9hglKssNuors Sp7qm1VOtSzvB8cFktrSH6Aqt+38v17QIr4jZT4YvqV11mpC1JRwkVfcR6Qcrg== Date: Fri, 16 Feb 2024 04:29:08 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240216032908.GI6420@pb2> References: <20240120014730.53635-1-jamrial@gmail.com> <20240120014730.53635-2-jamrial@gmail.com> MIME-Version: 1.0 In-Reply-To: <20240120014730.53635-2-jamrial@gmail.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 2/2] avcodec/speexdec: fix setting frame_size from extradata X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6179045360347653793==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6179045360347653793== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9nNnoD9Yr4yUYoyj" Content-Disposition: inline --9nNnoD9Yr4yUYoyj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 19, 2024 at 10:47:30PM -0300, James Almer wrote: > Finishes fixing vp5/potter512-400-partial.avi >=20 > The fate-matroska-ms-mode test ref is updated to reflect that the Speex d= ecoder > can now read the stream. >=20 > Signed-off-by: James Almer > --- > libavcodec/speexdec.c | 4 +--- > tests/ref/fate/matroska-ms-mode | 2 +- > 2 files changed, 2 insertions(+), 4 deletions(-) Theres plenty of code remaining after this change that assumes NB_FRAME_SIZE are available and writes that also. There was a testcase reporrted that causes this and many others ill forward the testcase. =3D=3D18747=3D=3D Invalid write of size 4 =3D=3D18747=3D=3D at 0xD1CFC3: sb_decode (speexdec.c:1260) =3D=3D18747=3D=3D by 0xD1E5CE: speex_decode_frame (speexdec.c:1557) =3D=3D18747=3D=3D by 0x998846: decode_simple_internal (decode.c:430) =3D=3D18747=3D=3D by 0x998DD7: decode_simple_receive_frame (decode.c:609) =3D=3D18747=3D=3D by 0x998F47: decode_receive_frame_internal (decode.c:6= 37) =3D=3D18747=3D=3D by 0x99930C: avcodec_send_packet (decode.c:734) =3D=3D18747=3D=3D by 0x669D2F: try_decode_frame (demux.c:2126) =3D=3D18747=3D=3D by 0x66CAA0: avformat_find_stream_info (demux.c:2809) =3D=3D18747=3D=3D by 0x24E9C2: ifile_open (ffmpeg_demux.c:1663) =3D=3D18747=3D=3D by 0x2755BE: open_files (ffmpeg_opt.c:1333) =3D=3D18747=3D=3D by 0x275780: ffmpeg_parse_options (ffmpeg_opt.c:1373) =3D=3D18747=3D=3D by 0x289702: main (ffmpeg.c:1032) =3D=3D18747=3D=3D Address 0x16a170c0 is 0 bytes after a block of size 1,53= 6 alloc'd =3D=3D18747=3D=3D at 0x4C33E76: memalign (in /usr/lib/valgrind/vgpreload= _memcheck-amd64-linux.so) =3D=3D18747=3D=3D by 0x4C33F91: posix_memalign (in /usr/lib/valgrind/vgp= reload_memcheck-amd64-linux.so) =3D=3D18747=3D=3D by 0x13E3FE6: av_malloc (mem.c:105) =3D=3D18747=3D=3D by 0x13BFBFD: av_buffer_alloc (buffer.c:82) =3D=3D18747=3D=3D by 0x13C0645: pool_alloc_buffer (buffer.c:362) =3D=3D18747=3D=3D by 0x13C07C6: av_buffer_pool_get (buffer.c:401) =3D=3D18747=3D=3D by 0xA46052: audio_get_buffer (get_buffer.c:203) =3D=3D18747=3D=3D by 0xA4648D: avcodec_default_get_buffer2 (get_buffer.c= :278) =3D=3D18747=3D=3D by 0x99B967: ff_get_buffer (decode.c:1673) =3D=3D18747=3D=3D by 0xD1E52E: speex_decode_frame (speexdec.c:1552) =3D=3D18747=3D=3D by 0x998846: decode_simple_internal (decode.c:430) =3D=3D18747=3D=3D by 0x998DD7: decode_simple_receive_frame (decode.c:609) =3D=3D18747=3D=3D by 0x998F47: decode_receive_frame_internal (decode.c:6= 37) =3D=3D18747=3D=3D by 0x99930C: avcodec_send_packet (decode.c:734) =3D=3D18747=3D=3D by 0x669D2F: try_decode_frame (demux.c:2126) =3D=3D18747=3D=3D by 0x66CAA0: avformat_find_stream_info (demux.c:2809) =3D=3D18747=3D=3D by 0x24E9C2: ifile_open (ffmpeg_demux.c:1663) =3D=3D18747=3D=3D by 0x2755BE: open_files (ffmpeg_opt.c:1333) =3D=3D18747=3D=3D by 0x275780: ffmpeg_parse_options (ffmpeg_opt.c:1373) =3D=3D18747=3D=3D by 0x289702: main (ffmpeg.c:1032) thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Good people do not need laws to tell them to act responsibly, while bad people will find a way around the laws. -- Plato --9nNnoD9Yr4yUYoyj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZc7WgAAKCRBhHseHBAsP qwPQAKCNtKTrlpnox0+5Bd+UPN1UgLSOWwCgm9KOOj93ej6rFIl+/nqntjME+gc= =6FBv -----END PGP SIGNATURE----- --9nNnoD9Yr4yUYoyj-- --===============6179045360347653793== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6179045360347653793==--