From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B8AF44823F for ; Thu, 15 Feb 2024 01:58:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5FBC568D21A; Thu, 15 Feb 2024 03:58:27 +0200 (EET) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6695668D1EF for ; Thu, 15 Feb 2024 03:58:21 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id A392B1BF204 for ; Thu, 15 Feb 2024 01:58:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1707962300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YVMpE2tQLnCd+o2JWPzGaODcvvPiypEqSh07ayqB4E0=; b=PJuDWwbtE8IYOj02ZA7OVMWRJrlMzW0o2K1BwUb1qoqN0ALc7hzsmIDqxpMs/sPzLm2pEU 2UyrF1mupRAfetKqLCtd0HoSPso2z6sX0NT0gtStWJ5G6uJ9W0STzyZH0Qa4V5gx5+F5Su tW3FdsX+ObKoA3hjHi90xa3EdFrxzii/vk7CTvwaE0yo0AdKx2V+GsGOzKRxlXUEZFs9TJ LTgYlNFPh3NlbRFH3pENr3ixu2QEa+tcWqheRj9wxABQnTmE/Isxi0CXoVFkTgCDHC45KM qX/2GbnlftlOb3XKWgyYTuxfj4q7uql2AfQCqIqGtrhixmES2veOI8TVm9PNyg== Date: Thu, 15 Feb 2024 02:58:19 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240215015819.GF6420@pb2> References: <20240214182435.31380-1-anton@khirnov.net> <20240214182435.31380-7-anton@khirnov.net> MIME-Version: 1.0 In-Reply-To: <20240214182435.31380-7-anton@khirnov.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 07/10] fftools/ffmpeg_filter: refactor setting input timebase X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4229679014260120213==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4229679014260120213== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DIp45irZz0EBvR5r" Content-Disposition: inline --DIp45irZz0EBvR5r Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 14, 2024 at 07:24:32PM +0100, Anton Khirnov wrote: > Treat it analogously to stream parameters like format/dimensions/etc. > This is functionally different from previous code in 2 ways: > * for non-CFR video, the frame timebase (set by the decoder) is used > rather than the demuxer timebase > * for sub2video, AV_TIME_BASE_Q is used, which is hardcoded by the > subtitle decoding API >=20 > These changes should avoid unnecessary and potentially lossy timestamp > conversions from decoder timebase into the demuxer one. >=20 > Changes the timebases used in sub2video tests. > --- > fftools/ffmpeg_filter.c | 17 ++- > tests/ref/fate/sub2video_basic | 182 +++++++++++++------------- > tests/ref/fate/sub2video_time_limited | 8 +- > 3 files changed, 106 insertions(+), 101 deletions(-) breaks: =2E/ffmpeg -i \[a-s\]_full_metal_panic_fumoffu_-_01_-_the_man_from_the_sout= h_-_a_hostage_with_no_compromises__rs2_\[1080p_bd-rip\]\[BBB48A25\].mkv -f= ilter_complex '[0:s:1]scale=3D800:600' -t 15 -qscale 2 -bitexact -y /tmp/fi= le-pgstest2.avi =2E.. Press [q] to stop, [?] for help [aac @ 0x55dcd4a5a940] This stream seems to incorrectly report its last cha= nnel as LFE[3], mapping to LFE[0] [mpeg4 @ 0x55dcd4a5b780] timebase 1/1000000 not supported by MPEG 4 standar= d, the maximum admitted value for the timebase denominator is 65535 [vost#0:0/mpeg4 @ 0x55dcd4a5b2c0] Error while opening encoder - maybe incor= rect parameters such as bit_rate, rate, width or height. [fc#0 @ 0x55dcd4a37a00] Error sending frames to consumers: Invalid argument [fc#0 @ 0x55dcd4a37a00] Task finished with error code: -22 (Invalid argumen= t) [fc#0 @ 0x55dcd4a37a00] Terminating thread with return code -22 (Invalid ar= gument) [vost#0:0/mpeg4 @ 0x55dcd4a5b2c0] Could not open encoder before EOF [vost#0:0/mpeg4 @ 0x55dcd4a5b2c0] Task finished with error code: -22 (Inval= id argument) [vost#0:0/mpeg4 @ 0x55dcd4a5b2c0] Terminating thread with return code -22 (= Invalid argument) [libmp3lame @ 0x55dcd4a5ca80] Trying to remove 1152 samples, but the queue = is empty [out#0/avi @ 0x55dcd4a7f680] Nothing was written into output file, because = at least one of its streams received no packets. frame=3D 0 fps=3D0.0 q=3D0.0 Lsize=3D 0KiB time=3DN/A bitrate=3DN/= A speed=3DN/A Conversion failed! vs. Press [q] to stop, [?] for help [aac @ 0x55b416e87e00] This stream seems to incorrectly report its last cha= nnel as LFE[3], mapping to LFE[0] Output #0, avi, to '/tmp/file-pgstest2.avi': Stream #0:0: Video: mpeg4 (FMP4 / 0x34504D46), yuv420p(progressive), 800x= 600, q=3D2-31, 200 kb/s, 1k tbn Metadata: encoder : Lavc mpeg4 Side data: cpb: bitrate max/min/avg: 0/0/200000 buffer size: 0 vbv_delay: N/A Stream #0:1(eng): Audio: mp3 (U[0][0][0] / 0x0055), 48000 Hz, stereo, flt= p (default) Metadata: title : AAC encoder : Lavc libmp3lame [libmp3lame @ 0x55b416e76640] Trying to remove 1152 samples, but the queue = is empty [out#0/avi @ 0x55b416e7fec0] video:496KiB audio:235KiB subtitle:0KiB other = streams:0KiB global headers:0KiB muxing overhead: 51.412292% frame=3D 360 fps=3D0.0 q=3D2.0 Lsize=3D 1108KiB time=3D00:00:14.97 bitr= ate=3D 605.9kbits/s dup=3D0 drop=3D16 speed=3D44.9x [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Never trust a computer, one day, it may think you are the virus. -- Compn --DIp45irZz0EBvR5r Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZc1vsQAKCRBhHseHBAsP q8tOAJ425xvmlS0tSWX8XDljn9Yv5rTw+wCfUxbJA4ACHHBHQCofRVxldkiiUog= =rm+0 -----END PGP SIGNATURE----- --DIp45irZz0EBvR5r-- --===============4229679014260120213== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4229679014260120213==--