From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7C71849631 for ; Wed, 14 Feb 2024 18:38:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 01B0C68D1F4; Wed, 14 Feb 2024 20:38:37 +0200 (EET) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7CB0068D19E for ; Wed, 14 Feb 2024 20:38:30 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id A68D2FF806 for ; Wed, 14 Feb 2024 18:38:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1707935909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SoihGY3f5DAiES+g82tBKCX7v+yXOCi91Za9A4M4+IM=; b=A/qnq/Scu57v78/rdyxhK0NIqfVepjckSWf0so/mohWgYhXxdcVMuRyOxtwEjnufkAuhR0 8lS8oAq9xpS2cTaXm0t5U8ZqG4VURaYkoNK4O8sfw1/kvJf7Lr08KeU35J/ZKGHqWYuJCH wYQZPs7BByG4VQbmrAgrz4ovBrTQ3IY847pw4ikbFKpFd1bMLOMOp1lQozLhSgxZ4lqyFX Sinpk5Ikcdv2/Gu/c3YxD0L0fYU+R+hVdKph3jnVx2BLlsl8c/XX3+TVaPV4GuZyQVtWF0 M7FrBu9FbmVponigNQLI9nkoCPAwEYTkP9vAkxL2L/NB6oxhuMqQtomF/D9hwQ== Date: Wed, 14 Feb 2024 19:38:28 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240214183828.GE6420@pb2> References: <20240213212456.167386-1-leo.izen@gmail.com> <20240213212456.167386-4-leo.izen@gmail.com> MIME-Version: 1.0 In-Reply-To: <20240213212456.167386-4-leo.izen@gmail.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 3/3] avcodec/pngenc: write eXIf chunks X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1364905505224546440==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1364905505224546440== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LR6bgoVDGZVT00Wv" Content-Disposition: inline --LR6bgoVDGZVT00Wv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 13, 2024 at 04:24:56PM -0500, Leo Izen wrote: > Write EXIF metadata exposed AV_FRAME_DATA_EXIF as an eXIf chunk > to PNG files, if present. >=20 > Signed-off-by: Leo Izen > --- > libavcodec/pngenc.c | 4 ++++ > 1 file changed, 4 insertions(+) This seems to break: --- ./tests/ref/fate/cover-art-mp3-id3v2-remux 2024-02-14 19:33:50.75601217= 4 +0100 +++ tests/data/fate/cover-art-mp3-id3v2-remux 2024-02-14 19:36:59.150052682= +0100 @@ -1,5 +1,5 @@ -94946f0efd5f9bb0061ac1fbff7d731f *tests/data/fate/cover-art-mp3-id3v2-remu= x.mp3 -399346 tests/data/fate/cover-art-mp3-id3v2-remux.mp3 +0643e306430fbadeb1c89da6ab36a303 *tests/data/fate/cover-art-mp3-id3v2-remu= x.mp3 +399414 tests/data/fate/cover-art-mp3-id3v2-remux.mp3 #tb 0: 1/14112000 #media_type 0: audio #codec_id 0: mp3 @@ -23,7 +23,7 @@ 0, -353590, -353590, 368640, 417, 0x15848290, S=3D1, 10 1, 0, 0, 0, 208350, 0x291b44d1 2, 0, 0, 0, 15760, 0x71d5c418 -3, 0, 0, 0, 165671, 0x7c1c8070 +3, 0, 0, 0, 165739, 0x2e108b69 0, 15050, 15050, 368640, 418, 0x46f684a4 0, 383690, 383690, 368640, 418, 0x46f684a4 0, 752330, 752330, 368640, 418, 0x46f684a4 Test cover-art-mp3-id3v2-remux failed. Look at tests/data/fate/cover-art-mp= 3-id3v2-remux.err for details. tests/Makefile:318: recipe for target 'fate-cover-art-mp3-id3v2-remux' fail= ed make: *** [fate-cover-art-mp3-id3v2-remux] Error 1 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Opposition brings concord. Out of discord comes the fairest harmony. -- Heraclitus --LR6bgoVDGZVT00Wv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZc0IngAKCRBhHseHBAsP qz7LAKCWQXtt5W4L7mhygt9pwoO4GZj2qACfXudjsCfXYDWmmSaPVHNBpNprhEo= =EpHN -----END PGP SIGNATURE----- --LR6bgoVDGZVT00Wv-- --===============1364905505224546440== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1364905505224546440==--