From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 54BDC48206 for ; Tue, 13 Feb 2024 21:25:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ABECF68D182; Tue, 13 Feb 2024 23:25:07 +0200 (EET) Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D531A68C4E1 for ; Tue, 13 Feb 2024 23:25:00 +0200 (EET) Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-4280f3ec702so16642491cf.0 for ; Tue, 13 Feb 2024 13:25:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707859499; x=1708464299; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Da+xwfknKqndqCtG6NDQxrspQugaQCaI/+cPYHi03CI=; b=Z1LY9IRhdiiNM2eXbdSwBkD/e7biL7yi73NuOHOj6Wcp3Sq86ukcsQiVuJnW4QkJT2 xphDiJjjPpeVhn8crE8An3IAWSJ3U9pzBdFJrWa25x/+d05dA3eRDn3nlSlvbVORumHE 5Xa7CplQ09KxI/UpvtMyLTrFD57nnhSZCbU/7icjDszU4xDgjlkQVzactFxxe/KnjLe6 ViX6hofzORHpeJu95I4iH3MfG6YnH4ep/fm/Za+hUGnBwxSkeW+JEiqj9ObRYBOWBvEX sOTJMtIm2XQXfw08PV+zRMs2YkhXyfJfCQPIHuBXiesXkZIf4hUX3phZ2pOG7lfQkSvt cQvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707859499; x=1708464299; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Da+xwfknKqndqCtG6NDQxrspQugaQCaI/+cPYHi03CI=; b=uylFZ1vj8am+CxhC5WOYc/IFXnWDNykENd3VME+UFqiDoZZs3QCTONoNcsUVB+GJvQ Y53SxRG/Dd7+jrLyLUWVsoPwQ6OAKcgERfX/XLIfd7VM7gk3N1HkY5sBbZPAVdtR6mjr 1Hzc4pTLMbNWBwu5q6YT48XToClkYeL0MZQ6iLBmcLON9FUPoWJN+hXF15aOb8mPu/so SCyHCxiqiZJMOwFZJNr1SDCwH6vJQgLtUOHtwCpoC6MykRdVGBpkjmK+fH25Y4VTNvBf C/hBPZtTJq2ba6GZHtlLggIADRgJV6i4wLv9LJY5ZBURepzPo9Z9r77+Bd7B98eXk38x q20w== X-Gm-Message-State: AOJu0YzyhPbhw2wYs7ePr76z6oqYOb2TA5b0bX8dv4QLFBb8NAerHClG /zvksT9FwPOXeT3f65pvY3XlqNTr6IwtagOuANXyg5sXNVmScOm2nLIOgna0 X-Google-Smtp-Source: AGHT+IHijT2x7A4JSwELvSL9w/P2nD6EyZHqJgiVKIhb5FPMWdmoR1nFiHXt+j03ZeQqtsO5TbnpAw== X-Received: by 2002:a05:620a:6190:b0:785:bd4d:e219 with SMTP id or16-20020a05620a619000b00785bd4de219mr227560qkn.4.1707859498725; Tue, 13 Feb 2024 13:24:58 -0800 (PST) Received: from gauss.local (c-68-56-149-176.hsd1.mi.comcast.net. [68.56.149.176]) by smtp.gmail.com with ESMTPSA id g5-20020a37e205000000b007861bea2972sm1523016qki.6.2024.02.13.13.24.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 13:24:58 -0800 (PST) From: Leo Izen To: ffmpeg-devel@ffmpeg.org Date: Tue, 13 Feb 2024 16:24:53 -0500 Message-ID: <20240213212456.167386-1-leo.izen@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 0/3] [RFC] EXIF overhaul X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Leo Izen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: A few notes: - This includes an avpriv_ removal, so it won't be able to be merged until the ABI is bumped. Alternatively, I could add that avipriv_ back in as a wrapper around the actual API so it's not a blocker, and then we can remove it when the time comes to bump the ABI. - MakerNote inside TIFF files are not handled by this patch. I don't have any samples that lets me reliably special-case them based on manufacturer. MakerNote is, by spec, a binary blob, but in practice it's often a TIFF IFD, with arbitrary data before the IFD starts and arbitrary semantics on whether its IFD-offsets are relative to the start of the TIFF header or the start of the MakerNote. The lack of samples makes this hard to work around. See [1] for more details. Note that [1] links [2] but [2] is a deadlink. - We attach the EXIF buffer as-is from mjpeg, webp, or other files that treat it as a blob, but we still need to parse it in order to determine the display matrix orientation side data. If there's a better way to handle this, please suggest one. - AVFrameSideData must be flat, so we can't parse it and store an AVDictionary * pointer in its place, as convenient as that would be. [1] https://exiv2.org/makernote.html [2] http://www.exif.org/samples.html Leo Izen (3): various: change EXIF metadata into AVFrameSideData avcodec/pngdec: parse eXIf chunk avcodec/pngenc: write eXIf chunks fftools/ffprobe.c | 27 ++- libavcodec/Makefile | 1 + libavcodec/exif.c | 267 +++++++++++++++++++++++++++-- libavcodec/exif.h | 21 ++- libavcodec/exif_internal.h | 41 +++++ libavcodec/mjpegdec.c | 96 ++--------- libavcodec/mjpegdec.h | 2 +- libavcodec/pngdec.c | 35 ++++ libavcodec/pngenc.c | 4 + libavcodec/tiff.c | 19 +- libavcodec/tiff.h | 1 + libavcodec/webp.c | 38 ++-- libavformat/avidec.c | 4 +- libavutil/frame.c | 1 + libavutil/frame.h | 6 + tests/ref/fate/exif-image-embedded | 5 +- tests/ref/fate/exif-image-jpg | 91 +++++----- tests/ref/fate/exif-image-webp | 91 +++++----- 18 files changed, 521 insertions(+), 229 deletions(-) create mode 100644 libavcodec/exif_internal.h -- 2.43.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".