From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3D9C649583 for ; Tue, 13 Feb 2024 07:34:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7216268D1B9; Tue, 13 Feb 2024 09:34:40 +0200 (EET) Received: from wfhigh5-smtp.messagingengine.com (wfhigh5-smtp.messagingengine.com [64.147.123.156]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8D4A968D0B4 for ; Tue, 13 Feb 2024 09:34:33 +0200 (EET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfhigh.west.internal (Postfix) with ESMTP id 107681800082 for ; Tue, 13 Feb 2024 02:34:30 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 13 Feb 2024 02:34:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=itanimul.li; h= cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to; s=fm1; t=1707809670; x=1707896070; bh=9RhZIEt/UaGW6EXVVmh/Z CFwtP+s21DoK1wkh9bOPWQ=; b=DDzfvJfqM2RQChInz/omKp/SZrq3YEq+/8Q4e SBY3Yv+SJV3g8+THo9YJZiiNYzyrOx2hogm/002F68OSdps+c4wF+gXLdyMSmQvh dSwZur1xMdGdaSxryD3b+ps+1iS2wOqsnf4Goj7FPtIYtGFZ8G4WTanqOSo6isfy GO+93Drf9x0mdtarDMOzr/l4VXBB+QJAI8FoZDps4QKd6yMM4PCLR1UOq9VnJFX2 T+cJYBny2yuVOQmMt8+BLYHcxaYunSMMK0vJLUI3MM6r30bB1nUCKlbdWtB5LDUM DRpRHIaWyzlST7AyxNsdgz9rtgpbLQVUUTcef6Ozdwzak2wYw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1707809670; x=1707896070; bh=9RhZIEt/UaGW6EXVVmh/ZCFwtP+s 21DoK1wkh9bOPWQ=; b=amfYm1H5HVrAvRP8iuMmuu8eXaAh9DwoUEd+pvLti7BR u4MrR6QD2AVkqiPNDBrLnfz/EcbBSzbx8bt1stss1uG6XQH11Hnlb519HMxJGszF a4RXmlBTiJmUA9QcHSj1OiW3jX3QxwTH5fWx/kGHF6OlNKfEDLVg+n/+dzkQ1fsh fJqOJ/nJxDYK6G6gLGGuM0bGtO1uWz1tkSPEm2EIKDM4LBRRwUG9l3UR9neueltB 7+nvLk6SeEO5KBzGthji3nDbarld+johsGy2Pnb0VOP+VRNRQLgNBCQ5pMFdOT2O rF5AfBUxiRZSOGQStCDEQz8mxZ/1yXIRboz4Di003Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudeggdduuddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgggfestdekredtre dttdenucfhrhhomhepfdflrdcuffgvkhhkvghrfdcuoehjuggvkhesihhtrghnihhmuhhl rdhliheqnecuggftrfgrthhtvghrnhepueetgfdtuedvjeejjedvteelffeuhedtfeetud fglefhjeeukeetvddvtdevieeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepjhguvghksehithgrnhhimhhulhdrlhhi X-ME-Proxy: Feedback-ID: i84994747:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Tue, 13 Feb 2024 02:34:29 -0500 (EST) From: "J. Dekker" To: ffmpeg-devel@ffmpeg.org Date: Tue, 13 Feb 2024 08:34:25 +0100 Message-ID: <20240213073426.47433-1-jdek@itanimul.li> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/2] avdevice: deprecate opengl outdev X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Signed-off-by: J. Dekker --- These devices are fundamentally broken and usecases should be switched away from output devices in general. Discussion in the thread tended towards deprecation rather than immediate removal to give time for users to figure out the best alternatives for their usecase. libavdevice/opengl_enc.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/libavdevice/opengl_enc.c b/libavdevice/opengl_enc.c index b2ac6eb16a..0c81ccc1c4 100644 --- a/libavdevice/opengl_enc.c +++ b/libavdevice/opengl_enc.c @@ -224,6 +224,8 @@ typedef struct OpenGLContext { int picture_height; ///< Rendered height int window_width; int window_height; + + int warned; } OpenGLContext; static const struct OpenGLFormatDesc { @@ -1060,6 +1062,14 @@ static av_cold int opengl_write_header(AVFormatContext *h) AVStream *st; int ret; + if (!opengl->warned) { + av_log(opengl, AV_LOG_WARNING, + "The opengl output device is deprecated. For monitoring purposes in ffmpeg you can output to a file or use pipes and a video player.\n" + "Example: ffmpeg -i input.mkv -f nut - | ffplay \n" + ); + opengl->warned = 1; + } + if (h->nb_streams != 1 || par->codec_type != AVMEDIA_TYPE_VIDEO || (par->codec_id != AV_CODEC_ID_WRAPPED_AVFRAME && par->codec_id != AV_CODEC_ID_RAWVIDEO)) { -- 2.43.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".