Re: [FFmpeg-devel] [PATCH 2/4 v8] avformat/mov: add support for tile HEIF still images

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 2297 bytes --]

On Sun, Feb 11, 2024 at 06:10:06PM -0300, James Almer wrote:
> On 2/11/2024 6:08 PM, James Almer wrote:
> > On 2/11/2024 5:41 PM, Michael Niedermayer wrote:
> > > On Sun, Feb 11, 2024 at 03:56:59PM -0300, James Almer wrote:
> > > > Export tiles as streams, and the grid information as a Stream
> > > > Group of type
> > > > TILE_GRID.
> > > > This also enables exporting other stream items like thumbnails,
> > > > which may be
> > > > present in non tiled HEIF images too.
> > > > 
> > > > Based on a patch by Swaraj Hota
> > > > 
> > > > Signed-off-by: James Almer <jamrial@gmail.com>
> > > > ---
> > > >   libavformat/avformat.c |   8 +
> > > >   libavformat/avformat.h |   6 +
> > > >   libavformat/dump.c     |   2 +
> > > >   libavformat/internal.h |   5 +
> > > >   libavformat/isom.h     |  16 +-
> > > >   libavformat/mov.c      | 492 +++++++++++++++++++++++++++++++++++++----
> > > >   6 files changed, 484 insertions(+), 45 deletions(-)
> > > 
> > > git dislikes this:
> > > 
> > > git am -3
> > > 
> > > Applying: avformat/mov: add support for tile HEIF still images
> > > error: sha1 information is lacking or useless (libavformat/avformat.c).
> > > error: could not build fake ancestor
> > > Patch failed at 0001 avformat/mov: add support for tile HEIF still images
> > > Use 'git am --show-current-patch' to see the failed patch
> > > When you have resolved this problem, run "git am --continue".
> > > If you prefer to skip this patch, run "git am --skip" instead.
> > > To restore the original branch and stop patching, run "git am --abort".
> > 
> > I can't reproduce this. Tried to apply the patches as sent to the ml and
> > they still apply.
> 
> https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=10765 shows no
> issues.
> I also pushed it to https://github.com/jamrial/FFmpeg/commits/heif_new/ so
> you can test it.

It seems this was caused by prior applied patches

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".