[FFmpeg-devel] [PATCH] avcodec/avcodec: don't print coded dimensions if not set

[FFmpeg-devel] [PATCH] avcodec/avcodec: don't print coded dimensions if not set

[James Almer]

The avctx passed to avcodec_string() may have unset coded dimensions, as is
the case when called by av_dump_format() where the streams had all the needed
information at the container level, and as such no frames were decoded internally.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavcodec/avcodec.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libavcodec/avcodec.c b/libavcodec/avcodec.c
index b6d27ada21..a13b781996 100644
--- a/libavcodec/avcodec.c
+++ b/libavcodec/avcodec.c
@@ -625,6 +625,7 @@ void avcodec_string(char *buf, int buf_size, AVCodecContext *enc, int encode)
                        enc->width, enc->height);
 
             if (av_log_get_level() >= AV_LOG_VERBOSE &&
+                enc->coded_width && enc->coded_height &&
                 (enc->width != enc->coded_width ||
                  enc->height != enc->coded_height))
                 av_bprintf(&bprint, " (%dx%d)",
-- 
2.43.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't print coded dimensions if not set

[James Almer]

On 2/10/2024 2:39 PM, James Almer wrote:
> The avctx passed to avcodec_string() may have unset coded dimensions, as is
> the case when called by av_dump_format() where the streams had all the needed
> information at the container level, and as such no frames were decoded internally.
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>   libavcodec/avcodec.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/libavcodec/avcodec.c b/libavcodec/avcodec.c
> index b6d27ada21..a13b781996 100644
> --- a/libavcodec/avcodec.c
> +++ b/libavcodec/avcodec.c
> @@ -625,6 +625,7 @@ void avcodec_string(char *buf, int buf_size, AVCodecContext *enc, int encode)
>                          enc->width, enc->height);
>   
>               if (av_log_get_level() >= AV_LOG_VERBOSE &&
> +                enc->coded_width && enc->coded_height &&
>                   (enc->width != enc->coded_width ||
>                    enc->height != enc->coded_height))
>                   av_bprintf(&bprint, " (%dx%d)",

Will apply.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".