[FFmpeg-devel] [PATCH 1/2] avutil/pixfmt: Add AV_PIX_MAX_PLANES

[FFmpeg-devel] [PATCH 1/2] avutil/pixfmt: Add AV_PIX_MAX_PLANES

[Michael Niedermayer]

It seems we do not have a named identifier for the maximum planes of pixel formats

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavutil/pixfmt.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavutil/pixfmt.h b/libavutil/pixfmt.h
index 9c87571f49e..67422f02d02 100644
--- a/libavutil/pixfmt.h
+++ b/libavutil/pixfmt.h
@@ -32,6 +32,8 @@
 #define AVPALETTE_SIZE 1024
 #define AVPALETTE_COUNT 256
 
+#define AV_PIX_MAX_PLANES 4
+
 /**
  * Pixel format.
  *
-- 
2.17.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 2/2] avfilter/v360: Use AV_PIX_MAX_PLANES

[Michael Niedermayer]

Issue found through Coverity CID1457948

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavfilter/v360.h | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/libavfilter/v360.h b/libavfilter/v360.h
index 5d797ab828b..a984d470acc 100644
--- a/libavfilter/v360.h
+++ b/libavfilter/v360.h
@@ -160,14 +160,14 @@ typedef struct V360Context {
     int in_width, in_height;
     int out_width, out_height;
 
-    int pr_width[4], pr_height[4];
+    int pr_width[AV_PIX_MAX_PLANES], pr_height[AV_PIX_MAX_PLANES];
 
-    int in_offset_w[4], in_offset_h[4];
-    int out_offset_w[4], out_offset_h[4];
+    int in_offset_w[AV_PIX_MAX_PLANES], in_offset_h[AV_PIX_MAX_PLANES];
+    int out_offset_w[AV_PIX_MAX_PLANES], out_offset_h[AV_PIX_MAX_PLANES];
 
-    int planewidth[4], planeheight[4];
-    int inplanewidth[4], inplaneheight[4];
-    int uv_linesize[4];
+    int planewidth[AV_PIX_MAX_PLANES], planeheight[AV_PIX_MAX_PLANES];
+    int inplanewidth[AV_PIX_MAX_PLANES], inplaneheight[AV_PIX_MAX_PLANES];
+    int uv_linesize[AV_PIX_MAX_PLANES];
     int nb_planes;
     int nb_allocated;
     int elements;
@@ -176,7 +176,7 @@ typedef struct V360Context {
     int nb_threads;
 
     SliceXYRemap *slice_remap;
-    unsigned map[4];
+    unsigned map[AV_PIX_MAX_PLANES];
 
     int (*in_transform)(const struct V360Context *s,
                         const float *vec, int width, int height,
-- 
2.17.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/2] avutil/pixfmt: Add AV_PIX_MAX_PLANES

[Anton Khirnov]

Quoting Michael Niedermayer (2024-02-08 13:57:57)
> It seems we do not have a named identifier for the maximum planes of pixel formats
> 
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavutil/pixfmt.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libavutil/pixfmt.h b/libavutil/pixfmt.h
> index 9c87571f49e..67422f02d02 100644
> --- a/libavutil/pixfmt.h
> +++ b/libavutil/pixfmt.h
> @@ -32,6 +32,8 @@
>  #define AVPALETTE_SIZE 1024
>  #define AVPALETTE_COUNT 256
>  
> +#define AV_PIX_MAX_PLANES 4

I'd call it AV_VIDEO_MAX_PLANES.

Also, needs doxy,APIchanges, and minor bump.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/2] avutil/pixfmt: Add AV_PIX_MAX_PLANES

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 955 bytes --]

On Fri, Feb 16, 2024 at 02:39:33PM +0100, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2024-02-08 13:57:57)
> > It seems we do not have a named identifier for the maximum planes of pixel formats
> > 
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  libavutil/pixfmt.h | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/libavutil/pixfmt.h b/libavutil/pixfmt.h
> > index 9c87571f49e..67422f02d02 100644
> > --- a/libavutil/pixfmt.h
> > +++ b/libavutil/pixfmt.h
> > @@ -32,6 +32,8 @@
> >  #define AVPALETTE_SIZE 1024
> >  #define AVPALETTE_COUNT 256
> >  
> > +#define AV_PIX_MAX_PLANES 4
> 
> I'd call it AV_VIDEO_MAX_PLANES.
> 
> Also, needs doxy,APIchanges, and minor bump.

ok, will apply with all that

[...]

thx

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct answer.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".