From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7D1A947F66 for ; Mon, 5 Feb 2024 02:58:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1226268D13E; Mon, 5 Feb 2024 04:58:31 +0200 (EET) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7687668CD39 for ; Mon, 5 Feb 2024 04:58:24 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id BF3451BF204 for ; Mon, 5 Feb 2024 02:58:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1707101903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc; bh=vnt1uGxZV0MQ6vcXXcTXHAv6dciEMfRBGe8HBuZws0A=; b=AoK0LI36w2dLpgtx8AGSbmdwp9y+OoeJaraJ9qvb//BJ9ig+Rjsa0z1VPhBuRW4XQ4r8p9 gEu2hVWfnEIYB0kcsnUL7viHTPelShZHcOrr5Q+B79T4CwBDbPecL7erh6ZTvCn7KtmBM8 57BWCVipwy1aeYGANFqmTQO3qCJ1d2bpVUv5U5ZJCBU/1p7Z0dIwmSRDQWgBHm+6k3WaXI ckjaJOrvivMd7Sg4yA3Yd8LIryMAyPi1OjlXRt3k/eH0UTXKkUQgvi0M1z28rKFvqNQOOd DhnOA4xGWJ5C+vRy2iH/IwppYBg+wD+Jq89q5RAmWuK7XmrfFrzaDBwiF4nLMQ== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Mon, 5 Feb 2024 03:58:22 +0100 Message-Id: <20240205025823.4259-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 1/2] avcodec/ac3enc_template: add fbw_channels assert X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: fbw_channels must be > 0 as teh code is only run if cpl_enabled is set and that requires mode >= AC3_CHMODE_STEREO CID 718138 Uninitialized scalar variable assumes this assert to be false Signed-off-by: Michael Niedermayer --- libavcodec/ac3enc_template.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/ac3enc_template.c b/libavcodec/ac3enc_template.c index ce9ef58a330..34d07cc9e5b 100644 --- a/libavcodec/ac3enc_template.c +++ b/libavcodec/ac3enc_template.c @@ -223,6 +223,8 @@ static void apply_channel_coupling(AC3EncodeContext *s) } } + av_assert1(s->fbw_channels > 0); + /* calculate final coupling coordinates, taking into account reusing of coordinates in successive blocks */ for (bnd = 0; bnd < s->num_cpl_bands; bnd++) { -- 2.17.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".