From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 45BBD48B2F
	for <ffmpegdev@gitmailbox.com>; Sat,  3 Feb 2024 06:19:45 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 384BE68C7F2;
	Sat,  3 Feb 2024 08:19:43 +0200 (EET)
Received: from mail.overt.org (unknown [72.14.183.176])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3046068BDD5
 for <ffmpeg-devel@ffmpeg.org>; Sat,  3 Feb 2024 08:19:37 +0200 (EET)
Received: from authenticated-user (mail.overt.org [72.14.183.176])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest
 SHA256) (No client certificate requested)
 by mail.overt.org (Postfix) with ESMTPSA id DCE95605F4
 for <ffmpeg-devel@ffmpeg.org>; Sat,  3 Feb 2024 00:19:34 -0600 (CST)
Date: Fri, 2 Feb 2024 22:19:32 -0800
To: ffmpeg-devel@ffmpeg.org
Message-ID: <20240202221932.1f23af2b@fido7>
In-Reply-To: <NpVMiKG--3-9@lynne.ee>
References: <NpVMiKG--3-9@lynne.ee>
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH] configure: fix compilation with glslang
 14
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
From: Philip Langdale via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Philip Langdale <philipl@overt.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20240202221932.1f23af2b@fido7/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Wed, 31 Jan 2024 17:34:08 +0100 (CET)
Lynne <dev@lynne.ee> wrote:

> The configure check already had fallback for the previous version
> of glslang, which had different requirements for flags.
> This commit simply moves the flags needed for glslang 13 to the
> fallback, while first trying to use new flags for glslang 14.
> 
> This drops support for ~3 year old glslang versions, which
> I'm not sure had the complete C API we're using anyway.
> 
> Patch attached.
> 

LGTM.


--phil
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".