Re: [FFmpeg-devel] [PATCH 1/4] checkasm/rv34dsp: add rv34_inv_transform_dc test

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1741 bytes --]

On Fri, Feb 02, 2024 at 02:08:29PM +0200, Rémi Denis-Courmont wrote:
> 
> 
> Le 2 février 2024 01:42:20 GMT+02:00, Michael Niedermayer <michael@niedermayer.cc> a écrit :
> >On Wed, Jan 31, 2024 at 08:00:18PM +0800, flow gg wrote:
> >> 
> >
> >>  checkasm/Makefile   |    1 
> >>  checkasm/checkasm.c |    3 ++
> >>  checkasm/checkasm.h |    1 
> >>  checkasm/rv34dsp.c  |   65 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> >>  fate/checkasm.mak   |    1 
> >>  5 files changed, 71 insertions(+)
> >> e7eed6e25de9f313ddb3c0f3066f02f0671d3271  0001-checkasm-rv34dsp-add-rv34_inv_transform_dc-test.patch
> >> From 46a81051f49f6b4032815d5f123be8ff614033e2 Mon Sep 17 00:00:00 2001
> >> From: sunyuechi <sunyuechi@iscas.ac.cn>
> >> Date: Wed, 31 Jan 2024 19:00:23 +0800
> >> Subject: [PATCH 1/4] checkasm/rv34dsp: add rv34_inv_transform_dc test
> >
> >seems to fail here
> 
> Do you mean that the test is wrong or that it exposes a bug in the x86 optimisations (which wouldn't be the first occurrence)?
> 
> It's painful enough that RVV optimisations need to add checkasm tests for existing code. We can't be expected to fix x86 bugs on top.

i would assume theres some bug in the x86 side but i did not look
iam not suggesting flow gg needs to fix that just that before this test is
enabled on x86, the bug needs to be fixed

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Any man who breaks a law that conscience tells him is unjust and willingly 
accepts the penalty by staying in jail in order to arouse the conscience of 
the community on the injustice of the law is at that moment expressing the 
very highest respect for law. - Martin Luther King Jr

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".