From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 211E448AFF for ; Thu, 1 Feb 2024 13:10:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 22F3B68D05A; Thu, 1 Feb 2024 15:10:39 +0200 (EET) Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C2CB668C7B6 for ; Thu, 1 Feb 2024 15:10:31 +0200 (EET) Received: from haasn.dev (unknown [10.30.0.2]) by haasn.dev (Postfix) with ESMTP id 7FED44BE7D; Thu, 1 Feb 2024 14:10:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail; t=1706793031; bh=atjK7lYJvSgSRoxLyMwHGe/43JY4HC+HjTfc6VCbyLw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=E7uaeNNiPw5+FAD50aAf/0b0TfJf65zQZFe4TXFM2bwjwNlbuZ38ThL3OkA/T9h8F L2EEWQzl4QLKdKvKvLpFQ63YbP4XpOzeWDlvcU54IsN1SrAFNxbj1mjJRcoupOaCfG vmeiLUPY0PW9gom0nmTSBt/kmmqJcYUKFynSCX1E= Date: Thu, 1 Feb 2024 14:10:31 +0100 Message-ID: <20240201141031.GB21499@haasn.xyz> From: Niklas Haas To: FFmpeg development discussions and patches In-Reply-To: References: <20240110090547.69151-1-ffmpeg@haasn.xyz> <170626179485.8914.11156439406477457395@lain.khirnov.net> MIME-Version: 1.0 Content-Disposition: inline Subject: Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffplay: add missing YUV metadata to buffersrc X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Niklas Haas Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 26 Jan 2024 18:17:30 +0800 Zhao Zhili wrote: > > > > On Jan 26, 2024, at 17:36, Anton Khirnov wrote: > > > > Quoting Niklas Haas (2024-01-10 10:05:46) > >> From: Niklas Haas > >> > >> Fixes error spam from the `ffplay` tool since commit 2d555dc82d, caused > >> by an oversight on my part - I didn't notice during development that > >> `ffplay` goes through its own filtering code path separate from > >> fftools/ffmpeg_filter.c > > > > Wouldn't the same issue affect any other caller? > > Firstly, can avfilter support color range/space change from unspecified to a specified value > on the first frame? I think it should silent the log most of the cases. > > Secondly, log once for non-serious case. To clarify, commit 94422871fce3b90bebc95f5cae939fbbc4e33224 makes this message drop from WARNING to DEBUG verbosity for subsequent print-outs. So the error spam is no longer a major consideration, however it remains that ffplay needs to set the correct metadata for YUV colorspace negotiation to work inside the ffplay filter graph. (See the issue I linked in my other mail) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".