From: Niklas Haas <ffmpeg@haasn.xyz>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Niklas Haas <git@haasn.dev>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffplay: add missing YUV metadata to buffersrc
Date: Thu, 1 Feb 2024 14:10:31 +0100
Message-ID: <20240201141031.GB21499@haasn.xyz> (raw)
In-Reply-To: <tencent_9A4B8AE62D1090A6CBA7EA2ABA532B5C5606@qq.com>
On Fri, 26 Jan 2024 18:17:30 +0800 Zhao Zhili <quinkblack@foxmail.com> wrote:
>
>
> > On Jan 26, 2024, at 17:36, Anton Khirnov <anton@khirnov.net> wrote:
> >
> > Quoting Niklas Haas (2024-01-10 10:05:46)
> >> From: Niklas Haas <git@haasn.dev>
> >>
> >> Fixes error spam from the `ffplay` tool since commit 2d555dc82d, caused
> >> by an oversight on my part - I didn't notice during development that
> >> `ffplay` goes through its own filtering code path separate from
> >> fftools/ffmpeg_filter.c
> >
> > Wouldn't the same issue affect any other caller?
>
> Firstly, can avfilter support color range/space change from unspecified to a specified value
> on the first frame? I think it should silent the log most of the cases.
>
> Secondly, log once for non-serious case.
To clarify, commit 94422871fce3b90bebc95f5cae939fbbc4e33224 makes this
message drop from WARNING to DEBUG verbosity for subsequent print-outs.
So the error spam is no longer a major consideration, however it remains
that ffplay needs to set the correct metadata for YUV colorspace
negotiation to work inside the ffplay filter graph. (See the issue
I linked in my other mail)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-02-01 13:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 9:05 Niklas Haas
2024-01-10 9:05 ` [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: simplify buffersrc arg printing Niklas Haas
2024-01-26 9:36 ` [FFmpeg-devel] [PATCH 1/2] fftools/ffplay: add missing YUV metadata to buffersrc Anton Khirnov
2024-01-26 10:17 ` Zhao Zhili
2024-02-01 13:10 ` Niklas Haas [this message]
2024-02-01 12:52 ` Niklas Haas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201141031.GB21499@haasn.xyz \
--to=ffmpeg@haasn.xyz \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=git@haasn.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git