From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4E50448AEB for ; Thu, 1 Feb 2024 12:52:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6CD6368CE31; Thu, 1 Feb 2024 14:52:56 +0200 (EET) Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C278E68C6BB for ; Thu, 1 Feb 2024 14:52:49 +0200 (EET) Received: from haasn.dev (unknown [10.30.0.2]) by haasn.dev (Postfix) with ESMTP id DC6204BE7D; Thu, 1 Feb 2024 13:52:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail; t=1706791969; bh=hxTyB+1kDRH9p30VVNCgZH4m0ZNg+mtm2IcDKCM7IEg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XEvFtsRJ/J9woyn9zXMKR70oLRPnRAPGr/yUWzx7lwXsMHCqEg+tKGUk2lgxbsr6P +oXm2YY96cXQHeVmbh0nvNnleA9MM7oaOOIgsbucbI5h+hXZK8NJJ80XAAJoLdou4y 3Cg9UufoiEyrAcHoNl7BbDuFaeLbY48w6Vb5Wlvw= Date: Thu, 1 Feb 2024 13:52:48 +0100 Message-ID: <20240201135248.GB18964@haasn.xyz> From: Niklas Haas To: ffmpeg-devel@ffmpeg.org In-Reply-To: <20240110090547.69151-1-ffmpeg@haasn.xyz> References: <20240110090547.69151-1-ffmpeg@haasn.xyz> MIME-Version: 1.0 Content-Disposition: inline Subject: Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffplay: add missing YUV metadata to buffersrc X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Niklas Haas Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 10 Jan 2024 10:05:46 +0100 Niklas Haas wrote: > From: Niklas Haas > > Fixes error spam from the `ffplay` tool since commit 2d555dc82d, caused > by an oversight on my part - I didn't notice during development that > `ffplay` goes through its own filtering code path separate from > fftools/ffmpeg_filter.c > --- > fftools/ffplay.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/fftools/ffplay.c b/fftools/ffplay.c > index 17861e60be..0771326d76 100644 > --- a/fftools/ffplay.c > +++ b/fftools/ffplay.c > @@ -1881,10 +1881,12 @@ static int configure_video_filters(AVFilterGraph *graph, VideoState *is, const c > graph->scale_sws_opts = av_strdup(sws_flags_str); > > snprintf(buffersrc_args, sizeof(buffersrc_args), > - "video_size=%dx%d:pix_fmt=%d:time_base=%d/%d:pixel_aspect=%d/%d", > + "video_size=%dx%d:pix_fmt=%d:time_base=%d/%d:pixel_aspect=%d/%d:" > + "colorspace=%d:range=%d", > frame->width, frame->height, frame->format, > is->video_st->time_base.num, is->video_st->time_base.den, > - codecpar->sample_aspect_ratio.num, FFMAX(codecpar->sample_aspect_ratio.den, 1)); > + codecpar->sample_aspect_ratio.num, FFMAX(codecpar->sample_aspect_ratio.den, 1), > + frame->colorspace, frame->color_range); > if (fr.num && fr.den) > av_strlcatf(buffersrc_args, sizeof(buffersrc_args), ":frame_rate=%d/%d", fr.num, fr.den); > > -- > 2.43.0 > Will merge tomorrow if there is no further objection, especially as it now affects https://trac.ffmpeg.org/ticket/10839 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".