From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0E37F48FDF for ; Wed, 31 Jan 2024 01:58:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CC17468CE1C; Wed, 31 Jan 2024 03:58:14 +0200 (EET) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1361768BED3 for ; Wed, 31 Jan 2024 03:58:09 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 4D58B20005 for ; Wed, 31 Jan 2024 01:58:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1706666288; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f91ZETd+O28KG/Y/1fvGVBeDQGrUJitm0ore/fE7O8Q=; b=Dz+fWfTQjljqa6u6oxjsm0a5zhJNKaxLA5v8j7JNxT0/3eTANmEdSmEWspWnSum/EmdDd6 mMlhfXLeUab5sJ0f//1cDhBOWThCPQyQUhwJPVZ6fBF2f3XwIwt24Pr2hNJPrhJpykQdKR XSNR9/tvA2vVdxcpcRXI/YVqZflQGN0H2htLczSikBxLFFyGGWpH/Hi+gwoPk+N5paDub7 a9ctSvTpc/9Lpg6j6twoa8a5oEmChpwuo9qsF3bxSi+cv+jc8elEdpYBrcQFwhdvssEd9t SBPt1XLyZZbtACR5J/4S28OjL2bQS8jlNzE0MFVrrY8QN1QRcgK2qp+91422Rw== Date: Wed, 31 Jan 2024 02:58:07 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240131015807.GR6420@pb2> References: <20240130173218.63297-1-jamrial@gmail.com> <20240130173218.63297-3-jamrial@gmail.com> MIME-Version: 1.0 In-Reply-To: <20240130173218.63297-3-jamrial@gmail.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 3/7 v2] avformat/mov: make MOVStreamContext refcounted X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0248596716684860239==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0248596716684860239== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VtYI81D50x1Jkp2t" Content-Disposition: inline --VtYI81D50x1Jkp2t Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 30, 2024 at 02:32:14PM -0300, James Almer wrote: > This will be needed by the following commit. >=20 > Signed-off-by: James Almer > --- > libavformat/mov.c | 257 ++++++++++++++++++++++++++-------------------- > 1 file changed, 145 insertions(+), 112 deletions(-) The previous commits dont seem to build alone libavformat/mov.c: In function =E2=80=98heif_add_stream=E2=80=99: libavformat/mov.c:4931:60: error: =E2=80=98mov_free_stream_context=E2=80=99= undeclared (first use in this function); did you mean =E2=80=98ff_find_str= eam_index=E2=80=99? buf =3D av_buffer_create(data, sizeof(MOVStreamContext), mov_free_stre= am_context, c->fc, 0); ^~~~~~~~~~~~~~~= ~~~~~~~~ ff_find_stream_= index libavformat/mov.c:4931:60: note: each undeclared identifier is reported onl= y once for each function it appears in libavformat/mov.c:4942:10: error: implicit declaration of function =E2=80= =98mov_get_stream_context=E2=80=99; did you mean =E2=80=98ffio_init_read_co= ntext=E2=80=99? [-Werror=3Dimplicit-function-declaration] sc =3D mov_get_stream_context(st); And with this commit also not: libavcodec/libavcodec.a(bitstream_filters.o):(.data.rel.ro+0x90): undef= ined reference to `ff_iamf_stream_split_bsf' collect2: error: ld returned 1 exit status Makefile:133: recipe for target 'ffmpeg_g' failed make: *** [ffmpeg_g] Error 1 the next builds [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The worst form of inequality is to try to make unequal things equal. -- Aristotle --VtYI81D50x1Jkp2t Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZbmpJwAKCRBhHseHBAsP q5gMAJwP0h+8FKPyhelV29oeS0euKFysPwCdEv76uf9AxQ5abfWOzgau3K1YMWw= =K5h7 -----END PGP SIGNATURE----- --VtYI81D50x1Jkp2t-- --===============0248596716684860239== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0248596716684860239==--