Re: [FFmpeg-devel] [PATCH 3/7 v2] avformat/mov: make MOVStreamContext refcounted

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 3/7 v2] avformat/mov: make MOVStreamContext refcounted
Date: Wed, 31 Jan 2024 02:58:07 +0100
Message-ID: <20240131015807.GR6420@pb2> (raw)
In-Reply-To: <20240130173218.63297-3-jamrial@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1630 bytes --]

On Tue, Jan 30, 2024 at 02:32:14PM -0300, James Almer wrote:
> This will be needed by the following commit.
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavformat/mov.c | 257 ++++++++++++++++++++++++++--------------------
>  1 file changed, 145 insertions(+), 112 deletions(-)

The previous commits dont seem to build alone

libavformat/mov.c: In function ‘heif_add_stream’:
libavformat/mov.c:4931:60: error: ‘mov_free_stream_context’ undeclared (first use in this function); did you mean ‘ff_find_stream_index’?
     buf = av_buffer_create(data, sizeof(MOVStreamContext), mov_free_stream_context, c->fc, 0);
                                                            ^~~~~~~~~~~~~~~~~~~~~~~
                                                            ff_find_stream_index
libavformat/mov.c:4931:60: note: each undeclared identifier is reported only once for each function it appears in
libavformat/mov.c:4942:10: error: implicit declaration of function ‘mov_get_stream_context’; did you mean ‘ffio_init_read_context’? [-Werror=implicit-function-declaration]
     sc = mov_get_stream_context(st);

And with this commit also not:

    libavcodec/libavcodec.a(bitstream_filters.o):(.data.rel.ro+0x90): undefined reference to `ff_iamf_stream_split_bsf'
collect2: error: ld returned 1 exit status
Makefile:133: recipe for target 'ffmpeg_g' failed
make: *** [ffmpeg_g] Error 1

the next builds

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".