From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0F63748EB5 for ; Mon, 29 Jan 2024 19:24:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 562AE68D24C; Mon, 29 Jan 2024 21:24:31 +0200 (EET) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4075168D1F9 for ; Mon, 29 Jan 2024 21:24:24 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 7C1CCC0005 for ; Mon, 29 Jan 2024 19:24:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1706556263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9dc50eLbZ9LhCy1cdkwtGsNy6FhtHLSMVx7PjlVMlzM=; b=F/1OAtcaDcdp43Ct7+p9g/7saK0j1YLzYBnGtMoMmUYRx+f+Q4FkLINlhFi2+wRnQaTG5v c/P3/d0Bx6EwyPaQtvChCnmzXCzZsMFmXRJYFqIqZZGTn335Cr+r8USgXHm+pNwz6XfImv byZyG72zGzQyJHJeN0zUcETl8RoLcQeuD1D0kkbR2z4Gnbp9gC+505oV3ppOL5QOKfzjrZ z4pzrJvMFz3CglTKVCMYh8yJxhD0BT/pxbaN2wEJnwDC3guKe2oSOAaZZTrCPfkrhp3icK BYcKid5oCEiHiYOA+UJ16GjAdBnZhM8eLUhv128fm0894gyvQG5YYR7nNFZ77g== Date: Mon, 29 Jan 2024 20:24:21 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240129192421.GC6420@pb2> References: <20240128224141.GT6420@pb2> <35759608-96f9-4247-84aa-18bef03b864c@gmail.com> <20240129023127.GV6420@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec: Rename ff_kbd_window_init() as it will be needed from outside libavcodec" X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0416448994703469835==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0416448994703469835== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7Zmek6uG+MWXPTqW" Content-Disposition: inline --7Zmek6uG+MWXPTqW Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 29, 2024 at 10:09:52AM +0100, Vittorio Giovara wrote: > On Mon, Jan 29, 2024 at 8:58=E2=80=AFAM Andreas Rheinhardt < > andreas.rheinhardt@outlook.com> wrote: >=20 > > Michael Niedermayer: > > > On Sun, Jan 28, 2024 at 08:52:20PM -0300, James Almer wrote: > > >> On 1/28/2024 7:41 PM, Michael Niedermayer wrote: > > >>> On Sun, Jan 28, 2024 at 02:49:26PM +0100, Andreas Rheinhardt wrote: > > >>>> This reverts commits fd5aa93a37b3fa21195c6d7b22ef655124020e09 > > >>>> and cf00f60bab1f79213c274a6cd4357b32bd5c0101 > > >>>> ("avcodec/kbdwin: Support arbitrary sized windows"). > > >>>> > > >>>> The change in question has only been made for libavradio. > > >>>> in anticipation of merging it into the main tree. This has > > >>>> not happened, so this commit reverts the changes to kbdwin > > >>>> that are not used for anything else. In particular, these > > >>>> functions are no longer exported (as avpriv functions); > > >>>> notice that the fixed-point function has been exported > > >>>> despite having never been used outside of lavc. > > >>>> > > >>>> Signed-off-by: Andreas Rheinhardt > > >>>> --- > > >>>> libavcodec/aacdec_template.c | 8 ++++---- > > >>>> libavcodec/aactab.c | 4 ++-- > > >>>> libavcodec/ac3dec.c | 2 +- > > >>>> libavcodec/ac3enc_fixed.c | 2 +- > > >>>> libavcodec/ac3enc_float.c | 2 +- > > >>>> libavcodec/dolby_e.c | 4 ++-- > > >>>> libavcodec/kbdwin.c | 23 ++++++++--------------- > > >>>> libavcodec/kbdwin.h | 10 ++++------ > > >>>> 8 files changed, 23 insertions(+), 32 deletions(-) > > >>> > > >>> I still intend to work on SDR either within what people agreed to > > >>> (that is a separate library) or in form of a fork. > > >>> > > >>> For both it is easier if the functions it needs are accessible > > >>> > > >>> thx > > >> > > >> Renaming an ff_ symbol into avpriv_ can happen at any time. Renaming= an > > >> avpriv_ symbol to ff_ can only happen during a bump. So this patch is > > IMO > > >> ok. > > >> There's no warranty that whatever happens with SDR will happen before > > the > > >> next bump, so better remove as many exposed symbols as possible. > > > > > > You are missing something here. > > > > > > With the symbols, i can fork libavdevice and add SDR support. > > > Without the symbols, i cannot just do that. At least not cleanly > > > Because i need to replace libavcodec too and i need to extend its ABI > > > then. > > > This makes this more messy. > > > > > > > I would rather have you just copy the needed code into your fork of > > libavradio/libavdevice than add avpriv symbols (one of which was always > > unnecessary) for this. > > >=20 > Agreed, Michael is there any blocker for this to be done in your fork? Vittorio, Andreas I think you are correct, I will do that thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Concerning the gods, I have no means of knowing whether they exist or not or of what sort they may be, because of the obscurity of the subject, and the brevity of human life -- Protagoras --7Zmek6uG+MWXPTqW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZbf7ZQAKCRBhHseHBAsP qwkoAJ41wArhcHUj+1g65hTWuR9aaYM1RQCggD2UIb+Me4el5OhySJohR7f6hm0= =APNZ -----END PGP SIGNATURE----- --7Zmek6uG+MWXPTqW-- --===============0416448994703469835== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0416448994703469835==--