[FFmpeg-devel] [PATCH] avformat/wavenc: use strtoull for UMID conversion

[FFmpeg-devel] [PATCH] avformat/wavenc: use strtoull for UMID conversion

[Gyan Doshi]

Existing use of strtoll can lead to ERANGE errors leading to incorrect
storage of UMID.
---
 libavformat/wavenc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/wavenc.c b/libavformat/wavenc.c
index 82acb9ef0f..a41f40b449 100644
--- a/libavformat/wavenc.c
+++ b/libavformat/wavenc.c
@@ -129,7 +129,7 @@ static void bwf_write_bext_chunk(AVFormatContext *s)
 
         for (i = 0; i < len/16; i++) {
             memcpy(umidpart_str, tmp_tag->value + 2 + (i*16), 16);
-            umidpart = strtoll(umidpart_str, NULL, 16);
+            umidpart = strtoull(umidpart_str, NULL, 16);
             avio_wb64(s->pb, umidpart);
         }
         ffio_fill(s->pb, 0, 64 - i*8);
-- 
2.39.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/wavenc: use strtoull for UMID conversion

[Gyan Doshi]

On 2024-01-29 10:30 am, Gyan Doshi wrote:
> Existing use of strtoll can lead to ERANGE errors leading to incorrect
> storage of UMID.

Plan to push tomorrow.

Regards,
Gyan

> ---
>   libavformat/wavenc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/wavenc.c b/libavformat/wavenc.c
> index 82acb9ef0f..a41f40b449 100644
> --- a/libavformat/wavenc.c
> +++ b/libavformat/wavenc.c
> @@ -129,7 +129,7 @@ static void bwf_write_bext_chunk(AVFormatContext *s)
>   
>           for (i = 0; i < len/16; i++) {
>               memcpy(umidpart_str, tmp_tag->value + 2 + (i*16), 16);
> -            umidpart = strtoll(umidpart_str, NULL, 16);
> +            umidpart = strtoull(umidpart_str, NULL, 16);
>               avio_wb64(s->pb, umidpart);
>           }
>           ffio_fill(s->pb, 0, 64 - i*8);

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/wavenc: use strtoull for UMID conversion

[Gyan Doshi]

On 2024-02-02 03:34 pm, Gyan Doshi wrote:
>
>
> On 2024-01-29 10:30 am, Gyan Doshi wrote:
>> Existing use of strtoll can lead to ERANGE errors leading to incorrect
>> storage of UMID.
>
> Plan to push tomorrow.

Pushed as 7375a6ca7b4a4b223a71f85a772c64a34e60eabe

Regards,
Gyan

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".