From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4CF7748E10 for ; Mon, 29 Jan 2024 02:31:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7635968D1C0; Mon, 29 Jan 2024 04:31:36 +0200 (EET) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9D74968CD8E for ; Mon, 29 Jan 2024 04:31:29 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id E568DFF803 for ; Mon, 29 Jan 2024 02:31:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1706495489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZnRnXK60pkg5LroaAtU1dkA/9zvn3H6q7BHbGnsDExA=; b=KwJ4H2nEMwizwEQaCenmwpJpCMgsNqLgWK8MbIPnU1Lbg2Plid76cI+/aVZpX9/ZHQHG5H 0Zic7gJmEYKSq0uRGT7s6Auace2KJu+BswTWzRAt56DOe0W2kE/ArJGqwe/X9KfgsUvjGk teHod4l+ndrUghmWxx0qFB4Kwr2X5lXvJTOeTrlKpAyzCHBWVrffbMEjTcLVHXpACSO2e7 CbAsi1ThsAikrrmaDszW/eh1rWBnsUp3rCcOtzWXrcRyu4XMQDeIbneO+jBUIwEMHJlw2F zsAAvvn7oWW0kiXD57M9lsKwf9/Uccnqc5Vs8fAXBJ+yuUymL/bKzrF+VWIKlw== Date: Mon, 29 Jan 2024 03:31:27 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240129023127.GV6420@pb2> References: <20240128224141.GT6420@pb2> <35759608-96f9-4247-84aa-18bef03b864c@gmail.com> MIME-Version: 1.0 In-Reply-To: <35759608-96f9-4247-84aa-18bef03b864c@gmail.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec: Rename ff_kbd_window_init() as it will be needed from outside libavcodec" X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4945075406167606795==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4945075406167606795== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="w6btg7BHaKfOYq06" Content-Disposition: inline --w6btg7BHaKfOYq06 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 28, 2024 at 08:52:20PM -0300, James Almer wrote: > On 1/28/2024 7:41 PM, Michael Niedermayer wrote: > > On Sun, Jan 28, 2024 at 02:49:26PM +0100, Andreas Rheinhardt wrote: > > > This reverts commits fd5aa93a37b3fa21195c6d7b22ef655124020e09 > > > and cf00f60bab1f79213c274a6cd4357b32bd5c0101 > > > ("avcodec/kbdwin: Support arbitrary sized windows"). > > >=20 > > > The change in question has only been made for libavradio. > > > in anticipation of merging it into the main tree. This has > > > not happened, so this commit reverts the changes to kbdwin > > > that are not used for anything else. In particular, these > > > functions are no longer exported (as avpriv functions); > > > notice that the fixed-point function has been exported > > > despite having never been used outside of lavc. > > >=20 > > > Signed-off-by: Andreas Rheinhardt > > > --- > > > libavcodec/aacdec_template.c | 8 ++++---- > > > libavcodec/aactab.c | 4 ++-- > > > libavcodec/ac3dec.c | 2 +- > > > libavcodec/ac3enc_fixed.c | 2 +- > > > libavcodec/ac3enc_float.c | 2 +- > > > libavcodec/dolby_e.c | 4 ++-- > > > libavcodec/kbdwin.c | 23 ++++++++--------------- > > > libavcodec/kbdwin.h | 10 ++++------ > > > 8 files changed, 23 insertions(+), 32 deletions(-) > >=20 > > I still intend to work on SDR either within what people agreed to > > (that is a separate library) or in form of a fork. > >=20 > > For both it is easier if the functions it needs are accessible > >=20 > > thx >=20 > Renaming an ff_ symbol into avpriv_ can happen at any time. Renaming an > avpriv_ symbol to ff_ can only happen during a bump. So this patch is IMO > ok. > There's no warranty that whatever happens with SDR will happen before the > next bump, so better remove as many exposed symbols as possible. You are missing something here. With the symbols, i can fork libavdevice and add SDR support. Without the symbols, i cannot just do that. At least not cleanly Because i need to replace libavcodec too and i need to extend its ABI then. This makes this more messy. thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Never trust a computer, one day, it may think you are the virus. -- Compn --w6btg7BHaKfOYq06 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZbcN+wAKCRBhHseHBAsP q6xGAJ0a3aSfIL+fd1ntMC7GoDRRc2pVkACgmFdYM5eS81P9B9tTo5Pt9AVCHeg= =66Rl -----END PGP SIGNATURE----- --w6btg7BHaKfOYq06-- --===============4945075406167606795== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4945075406167606795==--