Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec: Rename ff_kbd_window_init() as it will be needed from outside libavcodec"
Date: Sun, 28 Jan 2024 23:41:41 +0100
Message-ID: <20240128224141.GT6420@pb2> (raw)
In-Reply-To: <AS8P250MB07448A987FA6B370DCDAF5CF8F7F2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>


[-- Attachment #1.1: Type: text/plain, Size: 1807 bytes --]

On Sun, Jan 28, 2024 at 02:49:26PM +0100, Andreas Rheinhardt wrote:
> This reverts commits fd5aa93a37b3fa21195c6d7b22ef655124020e09
> and cf00f60bab1f79213c274a6cd4357b32bd5c0101
> ("avcodec/kbdwin: Support arbitrary sized windows").
> 
> The change in question has only been made for libavradio.
> in anticipation of merging it into the main tree. This has
> not happened, so this commit reverts the changes to kbdwin
> that are not used for anything else. In particular, these
> functions are no longer exported (as avpriv functions);
> notice that the fixed-point function has been exported
> despite having never been used outside of lavc.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/aacdec_template.c |  8 ++++----
>  libavcodec/aactab.c          |  4 ++--
>  libavcodec/ac3dec.c          |  2 +-
>  libavcodec/ac3enc_fixed.c    |  2 +-
>  libavcodec/ac3enc_float.c    |  2 +-
>  libavcodec/dolby_e.c         |  4 ++--
>  libavcodec/kbdwin.c          | 23 ++++++++---------------
>  libavcodec/kbdwin.h          | 10 ++++------
>  8 files changed, 23 insertions(+), 32 deletions(-)

I still intend to work on SDR either within what people agreed to
(that is a separate library) or in form of a fork.

For both it is easier if the functions it needs are accessible

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Modern terrorism, a quick summary: Need oil, start war with country that
has oil, kill hundread thousand in war. Let country fall into chaos,
be surprised about raise of fundamantalists. Drop more bombs, kill more
people, be surprised about them taking revenge and drop even more bombs
and strip your own citizens of their rights and freedoms. to be continued

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2024-01-28 22:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-28 13:49 Andreas Rheinhardt
2024-01-28 13:50 ` [FFmpeg-devel] [PATCH 2/2] avcodec/aac_defines: Remove unused AAC_RENAME_32 Andreas Rheinhardt
2024-01-28 22:41 ` Michael Niedermayer [this message]
2024-01-28 23:52   ` [FFmpeg-devel] [PATCH 1/2] Revert "avcodec: Rename ff_kbd_window_init() as it will be needed from outside libavcodec" James Almer
2024-01-29  2:31     ` Michael Niedermayer
2024-01-29  7:59       ` Andreas Rheinhardt
2024-01-29  9:09         ` Vittorio Giovara
2024-01-29 19:24           ` Michael Niedermayer
2024-01-29 19:31             ` Michael Niedermayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240128224141.GT6420@pb2 \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git