From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9434148D79 for ; Thu, 25 Jan 2024 19:16:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 48C9168D0A0; Thu, 25 Jan 2024 21:16:37 +0200 (EET) Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 45E1968D001 for ; Thu, 25 Jan 2024 21:16:31 +0200 (EET) Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-5cf6d5117f9so4154281a12.2 for ; Thu, 25 Jan 2024 11:16:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706210188; x=1706814988; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=o6VIDYmQMl6Rb2gauoBYhGzcZ0OxYAKPyL7WuGtHIDk=; b=BrAZxT03a1bwjVOIY9QtgngoHyEllNIYvFEvmIYicbbZwnfYilL5oGJmgrSOHGammQ MwLxluP5rmDjeapgQASd1ElleeqttTvwau0cI/7wEsAzEQT68DTHcwFAB5iGqWMXy81C llK9ZU34GDoAGSOaxj45MJLAS0dDbHl4JCuMQddhS0GaWJxvbAMhou/w8tBNJ5//tn8+ TekcOE1uglIQa5uQn8LWPS6CslUhPFdh4MY04TJi9J9I+NUCJkxHF+UcEZmePyu7QTOz GexEWhe+SP5N5Cc160kAPS1hQ6NKEGEXxA2RI/sXq3gdrrD5e09UUpQ7kUcrfXiYH1f7 jpPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706210188; x=1706814988; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o6VIDYmQMl6Rb2gauoBYhGzcZ0OxYAKPyL7WuGtHIDk=; b=Uexi0yyvnnBNaHN3g49UkbbK0oM0iwXKWNjzWLxNLlwrTGJrgIXlOcQU4yc1e5QcZQ 06UvSMnJDEfkzjBTE/03aRNRhWMUtKAH3K4COPcSZBWPqUZlJe8dDaM3wC5mczfUgYax LZ5phPjlJnXi/PuAZd3a0NG5+lVJOQqD9orexEHyJ53UEVEfQgxpy+N0n5Q5e9D9lYKv nxyS1blzJcqRzVnJdGKtVoATm7gOGLgnaDxtO3C/+JkTjgfboDhR3J58SkQ81h9wvn6b 1emxYLb+6hYHWl4kuWDrjlNAoVYv4HlZz4mDkh0gcXFb5WFrVhC4NY7ohWOQzVR0qTrQ jJJA== X-Gm-Message-State: AOJu0YzOT2qc9kp+QpBH0pNExaT6GEUY2FdtFGhQYsQG+RyrXkD/oHwV ZfRK+St2Ytq7riMFVV/SBlYfIv9oWGAjX8vyDnHKfffMxcTUO5EYUIPiBzkM X-Google-Smtp-Source: AGHT+IFRh0y7DLfpGUtYa0BgRBXFN0UxroocTlmzXNw5HJfUr4ArNmHd9nlDWDYI2Z6GYi+4EOCwJA== X-Received: by 2002:a05:6a20:3ca3:b0:19c:4dce:bf21 with SMTP id b35-20020a056a203ca300b0019c4dcebf21mr164617pzj.34.1706210188341; Thu, 25 Jan 2024 11:16:28 -0800 (PST) Received: from localhost.localdomain (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id n9-20020aa78a49000000b006ddd22b79f6sm1590143pfa.120.2024.01.25.11.16.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 11:16:27 -0800 (PST) From: James Almer To: ffmpeg-devel@ffmpeg.org Date: Thu, 25 Jan 2024 16:16:30 -0300 Message-ID: <20240125191630.64824-1-jamrial@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240124145419.7980-2-jamrial@gmail.com> References: <20240124145419.7980-2-jamrial@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 2/4 v5] avformat: add a Tile Grid stream group type X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: This will be used to support tiled image formats like HEIF. Signed-off-by: James Almer --- Removed tile dimension arrays, as the same information can be fetched from the streams within the group. libavformat/avformat.c | 4 +++ libavformat/avformat.h | 65 ++++++++++++++++++++++++++++++++++++++++++ libavformat/dump.c | 36 +++++++++++++++++++++++ libavformat/options.c | 32 +++++++++++++++++++++ 4 files changed, 137 insertions(+) diff --git a/libavformat/avformat.c b/libavformat/avformat.c index 882927f7b1..c253bdbbad 100644 --- a/libavformat/avformat.c +++ b/libavformat/avformat.c @@ -100,6 +100,10 @@ void ff_free_stream_group(AVStreamGroup **pstg) av_iamf_mix_presentation_free(&stg->params.iamf_mix_presentation); break; } + case AV_STREAM_GROUP_PARAMS_TILE_GRID: + av_opt_free(stg->params.tile_grid); + av_freep(&stg->params.tile_grid); + break; default: break; } diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 5d0fe82250..184bb5b2ec 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -1018,10 +1018,74 @@ typedef struct AVStream { int pts_wrap_bits; } AVStream; +/** + * AVStreamGroupTileGrid holds information on how to combine several independent images in + * a single grid for presentation. + * + * Its size is not a part of the ABI. No new fields may be added to this struct + * without a major version bump. + */ +typedef struct AVStreamGroupTileGrid { + const AVClass *av_class; + + /** + * Amount of rows in the grid. + * + * Must be > 0. + */ + int tile_rows; + /** + * Amount of columns in the grid. + * + * Must be > 0. + */ + int tile_cols; + + /** + * Offset in pixels from the left edge of the grid where the actual image + * meant for presentation starts. + * + * This field must be >= 0 and <= the sum of widths of all images in a row. + */ + int horizontal_offset; + /** + * Offset in pixels from the top edge of the grid where the actual image + * meant for presentation starts. + * + * This field must be >= 0 and <= the sum of heights of all images in a + * column. + */ + int vertical_offset; + + /** + * Width of the final image for presentation. + * + * Must be > 0 and <= the sum of widths of all images in a row minus + * @ref horizontal_offset. + * When it's not equal the sum of widths of all images in a row, the result + * of said sum minus output_width minus @ref horizontal_offset is the + * amount of pixels to be cropped from the right edge of the final image + * before presentation. + */ + int output_width; + /** + * Height of the final image for presentation. + * + * Must be > 0 and <= the sum of heights of all images in a column minus + * @ref vertical_offset. + * When it's not equal the sum of heights of all images in a column, the + * result of said sum minus output_height minus @ref vertical_offset is the + * amount of pixels to be cropped from the right edge of the final image + * before presentation. + */ + int output_height; +} AVStreamGroupTileGrid; + enum AVStreamGroupParamsType { AV_STREAM_GROUP_PARAMS_NONE, AV_STREAM_GROUP_PARAMS_IAMF_AUDIO_ELEMENT, AV_STREAM_GROUP_PARAMS_IAMF_MIX_PRESENTATION, + AV_STREAM_GROUP_PARAMS_TILE_GRID, }; struct AVIAMFAudioElement; @@ -1062,6 +1126,7 @@ typedef struct AVStreamGroup { union { struct AVIAMFAudioElement *iamf_audio_element; struct AVIAMFMixPresentation *iamf_mix_presentation; + struct AVStreamGroupTileGrid *tile_grid; } params; /** diff --git a/libavformat/dump.c b/libavformat/dump.c index aff51b43f6..ef4a8df6fe 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -22,6 +22,7 @@ #include #include +#include "libavutil/avstring.h" #include "libavutil/channel_layout.h" #include "libavutil/display.h" #include "libavutil/iamf.h" @@ -720,6 +721,41 @@ static void dump_stream_group(const AVFormatContext *ic, uint8_t *printed, } } break; + case AV_STREAM_GROUP_PARAMS_TILE_GRID: { + const AVStreamGroupTileGrid *tile_grid = stg->params.tile_grid; + AVCodecContext *avctx = avcodec_alloc_context3(NULL); + const char *ptr = NULL; + av_log(NULL, AV_LOG_INFO, " Tile Grid:"); + av_log(NULL, AV_LOG_VERBOSE, " %d rows, %d columns,", tile_grid->tile_rows, tile_grid->tile_cols); + if (avctx && stg->nb_streams && !avcodec_parameters_to_context(avctx, stg->streams[0]->codecpar)) { + int size = tile_grid->tile_rows * tile_grid->tile_cols; + int coded_width = 0, coded_height = 0; + avctx->width = tile_grid->output_width; + avctx->height = tile_grid->output_height; + for (int j = 0; j < tile_grid->tile_cols; j++) + coded_width += stg->streams[j]->codecpar->width; + for (int j = 0; j < size; j += tile_grid->tile_cols) + coded_height += stg->streams[j]->codecpar->height; + avctx->coded_width = coded_width; + avctx->coded_height = coded_height; + if (ic->dump_separator) + av_opt_set(avctx, "dump_separator", ic->dump_separator, 0); + buf[0] = 0; + avcodec_string(buf, sizeof(buf), avctx, is_output); + ptr = av_stristr(buf, " "); + } + avcodec_free_context(&avctx); + if (ptr) + av_log(NULL, AV_LOG_INFO, "%s", ptr); + av_log(NULL, AV_LOG_INFO, "\n"); + dump_metadata(NULL, stg->metadata, " ", AV_LOG_INFO); + for (int i = 0; i < stg->nb_streams; i++) { + const AVStream *st = stg->streams[i]; + dump_stream_format(ic, st->index, i, index, is_output, AV_LOG_VERBOSE); + printed[st->index] = 1; + } + break; + } } default: break; diff --git a/libavformat/options.c b/libavformat/options.c index 75ec86ce05..9e83ef0d41 100644 --- a/libavformat/options.c +++ b/libavformat/options.c @@ -337,6 +337,26 @@ fail: return NULL; } +#define FLAGS AV_OPT_FLAG_ENCODING_PARAM | AV_OPT_FLAG_VIDEO_PARAM +#define OFFSET(x) offsetof(AVStreamGroupTileGrid, x) +static const AVOption tile_grid_options[] = { + { "tile_rows", NULL, OFFSET(tile_rows), AV_OPT_TYPE_INT, { .i64 = 1 }, 1, INT_MAX, FLAGS }, + { "tile_cols", NULL, OFFSET(tile_cols), AV_OPT_TYPE_INT, { .i64 = 1 }, 1, INT_MAX, FLAGS }, + { "horizontal_offset", NULL, OFFSET(horizontal_offset), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, INT_MAX, FLAGS }, + { "vertical_offset", NULL, OFFSET(vertical_offset), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, INT_MAX, FLAGS }, + { "output_size", "size of the output image", OFFSET(output_width), AV_OPT_TYPE_IMAGE_SIZE, + { .str = NULL }, 0, INT_MAX, FLAGS }, + { NULL }, +}; +#undef FLAGS +#undef OFFSET + +static const AVClass tile_grid_class = { + .class_name = "AVStreamGroupTileGrid", + .version = LIBAVUTIL_VERSION_INT, + .option = tile_grid_options, +}; + static void *stream_group_child_next(void *obj, void *prev) { AVStreamGroup *stg = obj; @@ -346,6 +366,8 @@ static void *stream_group_child_next(void *obj, void *prev) return stg->params.iamf_audio_element; case AV_STREAM_GROUP_PARAMS_IAMF_MIX_PRESENTATION: return stg->params.iamf_mix_presentation; + case AV_STREAM_GROUP_PARAMS_TILE_GRID: + return stg->params.tile_grid; default: break; } @@ -368,6 +390,9 @@ static const AVClass *stream_group_child_iterate(void **opaque) case AV_STREAM_GROUP_PARAMS_IAMF_MIX_PRESENTATION: ret = av_iamf_mix_presentation_get_class(); break; + case AV_STREAM_GROUP_PARAMS_TILE_GRID: + ret = &tile_grid_class; + break; default: break; } @@ -429,6 +454,13 @@ AVStreamGroup *avformat_stream_group_create(AVFormatContext *s, if (!stg->params.iamf_mix_presentation) goto fail; break; + case AV_STREAM_GROUP_PARAMS_TILE_GRID: + stg->params.tile_grid = av_mallocz(sizeof(*stg->params.tile_grid)); + if (!stg->params.tile_grid) + goto fail; + stg->params.tile_grid->av_class = &tile_grid_class; + av_opt_set_defaults(stg->params.tile_grid); + break; default: goto fail; } -- 2.43.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".