[FFmpeg-devel] [PATCH 18/31] fftools/ffmpeg_dec: pass forced/estimated framerate though DecoderOpts

[Anton Khirnov <anton@khirnov.net>]

Stop reading them from InputStream.

This is a step towards decoupling Decoder and InputStream.
---
 fftools/ffmpeg.h       |  7 +++++++
 fftools/ffmpeg_dec.c   | 15 ++++++++++-----
 fftools/ffmpeg_demux.c |  6 ++++++
 3 files changed, 23 insertions(+), 5 deletions(-)

diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h
index b4288e7352..106f943a2b 100644
--- a/fftools/ffmpeg.h
+++ b/fftools/ffmpeg.h
@@ -284,6 +284,9 @@ enum DecoderFlags {
     DECODER_FLAG_FIX_SUB_DURATION = (1 << 0),
     // input timestamps are unreliable (guessed by demuxer)
     DECODER_FLAG_TS_UNRELIABLE    = (1 << 1),
+    // decoder should override timestamps by fixed framerate
+    // from DecoderOpts.framerate
+    DECODER_FLAG_FRAMERATE_FORCED = (1 << 2),
 };
 
 typedef struct DecoderOpts {
@@ -294,6 +297,10 @@ typedef struct DecoderOpts {
     enum AVHWDeviceType         hwaccel_device_type;
     char                       *hwaccel_device;
     enum AVPixelFormat          hwaccel_output_format;
+
+    // Either forced (when DECODER_FLAG_FRAMERATE_FORCED is set) or
+    // estimated (otherwise) video framerate.
+    AVRational                  framerate;
 } DecoderOpts;
 
 typedef struct Decoder {
diff --git a/fftools/ffmpeg_dec.c b/fftools/ffmpeg_dec.c
index babfeb1b96..937e969988 100644
--- a/fftools/ffmpeg_dec.c
+++ b/fftools/ffmpeg_dec.c
@@ -45,6 +45,8 @@ typedef struct DecoderPriv {
     // override output video sample aspect ratio with this value
     AVRational       sar_override;
 
+    AVRational       framerate_in;
+
     // a combination of DECODER_FLAG_*, provided to dec_open()
     int              flags;
 
@@ -220,6 +222,7 @@ static int64_t video_duration_estimate(const InputStream *ist, const AVFrame *fr
 {
     const DecoderPriv    *dp = dp_from_dec(ist->decoder);
     const int  ts_unreliable = dp->flags & DECODER_FLAG_TS_UNRELIABLE;
+    const int      fr_forced = dp->flags & DECODER_FLAG_FRAMERATE_FORCED;
     int64_t codec_duration = 0;
 
     // XXX lavf currently makes up frame durations when they are not provided by
@@ -229,7 +232,7 @@ static int64_t video_duration_estimate(const InputStream *ist, const AVFrame *fr
     // durations, then this should be simplified.
 
     // prefer frame duration for containers with timestamps
-    if (frame->duration > 0 && (!ts_unreliable || ist->framerate.num))
+    if (frame->duration > 0 && (!ts_unreliable || fr_forced))
         return frame->duration;
 
     if (dp->dec_ctx->framerate.den && dp->dec_ctx->framerate.num) {
@@ -257,8 +260,8 @@ static int64_t video_duration_estimate(const InputStream *ist, const AVFrame *fr
         return codec_duration;
 
     // try average framerate
-    if (ist->st->avg_frame_rate.num && ist->st->avg_frame_rate.den) {
-        int64_t d = av_rescale_q(1, av_inv_q(ist->st->avg_frame_rate),
+    if (dp->framerate_in.num && dp->framerate_in.den) {
+        int64_t d = av_rescale_q(1, av_inv_q(dp->framerate_in),
                                  frame->time_base);
         if (d > 0)
             return d;
@@ -330,10 +333,10 @@ static int video_frame_process(InputStream *ist, AVFrame *frame)
     frame->pts = frame->best_effort_timestamp;
 
     // forced fixed framerate
-    if (ist->framerate.num) {
+    if (dp->flags & DECODER_FLAG_FRAMERATE_FORCED) {
         frame->pts       = AV_NOPTS_VALUE;
         frame->duration  = 1;
-        frame->time_base = av_inv_q(ist->framerate);
+        frame->time_base = av_inv_q(dp->framerate_in);
     }
 
     // no timestamp available - extrapolate from previous frame duration
@@ -961,6 +964,8 @@ int dec_open(InputStream *ist, Scheduler *sch, unsigned sch_idx,
     dp->dec.class  = &dec_class;
     dp->log_parent = ist;
 
+    dp->framerate_in            = o->framerate;
+
     dp->hwaccel_id              = o->hwaccel_id;
     dp->hwaccel_device_type     = o->hwaccel_device_type;
     dp->hwaccel_output_format   = o->hwaccel_output_format;
diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c
index 5ee07f706b..2a34f97545 100644
--- a/fftools/ffmpeg_demux.c
+++ b/fftools/ffmpeg_demux.c
@@ -907,6 +907,12 @@ static int ist_use(InputStream *ist, int decoding_needed)
         ds->dec_opts.flags = (!!ist->fix_sub_duration * DECODER_FLAG_FIX_SUB_DURATION) |
                              (!!(d->f.ctx->iformat->flags & AVFMT_NOTIMESTAMPS) * DECODER_FLAG_TS_UNRELIABLE);
 
+        if (ist->framerate.num) {
+            ds->dec_opts.flags     |= DECODER_FLAG_FRAMERATE_FORCED;
+            ds->dec_opts.framerate  = ist->framerate;
+        } else
+            ds->dec_opts.framerate  = ist->st->avg_frame_rate;
+
         ret = dec_open(ist, d->sch, ds->sch_idx_dec,
                        &ist->decoder_opts, &ds->dec_opts);
         if (ret < 0)
-- 
2.42.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".