From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7E8BD48C5D for ; Tue, 23 Jan 2024 19:07:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9272F68CEC1; Tue, 23 Jan 2024 21:07:12 +0200 (EET) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 117E168C25D for ; Tue, 23 Jan 2024 21:07:05 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 101741C0009 for ; Tue, 23 Jan 2024 19:07:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1706036825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3tZN2ScjOL/CbJudZVl1WuAg8OHCEagqxJ11vCm1QR0=; b=QLV/5MwmoeO5Jvb8XHRBeh8i9fDRgFG56sCSHQ0m3k3mJjI+QM4s5tT/70p+86zqQ2BX2C nbpYxKQmenh63RUk9m1/Ayqm+0i17cbxqmtVXonZdQXQ2U6O0Ff1+7j2rERAQC9Ob9kJ0D xIJ77Y3wVTSP3nySRTQ7xNhZcwAavUkzUJSXbdV39EStg7i6fTgGKEDJLGd2+yAM+v9zEy 7fOAcUyzVii07/Yv4S9f0mv+opAMQkDM2P9bbjZOgkjCl8qBArXxL5PABViunUXxRJInHT H+m7CHHvN+6b2XatK25zUQ4wkJj5UeIq4Dd/nPLyCyy2Xyci3CD5TxbPaOlmDg== Date: Tue, 23 Jan 2024 20:07:04 +0100 From: Michael Niedermayer To: ffmpeg-devel@ffmpeg.org Message-ID: <20240123190704.GL1833374@pb2> References: <20231211164227.163BB4115B0@natalya.videolan.org> MIME-Version: 1.0 In-Reply-To: <20231211164227.163BB4115B0@natalya.videolan.org> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] checkasm: test for abs_pow34 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3770947252582577341==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3770947252582577341== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FxlYARId5dseejUu" Content-Disposition: inline --FxlYARId5dseejUu Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 11, 2023 at 04:42:26PM +0000, sunyuechi wrote: > ffmpeg | branch: master | sunyuechi | Tue Nov 28 = 14:08:12 2023 +0800| [1c3620b2bbe73db9239fcf605e8f535b58f03b86] | committer= : R=E9mi Denis-Courmont > > checkasm: test for abs_pow34 > > Signed-off-by: R=E9mi Denis-Courmont > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=3Dcommit;h=3D1c3620b2b= be73db9239fcf605e8f535b58f03b86 > --- > > tests/checkasm/Makefile | 1 + > tests/checkasm/aacencdsp.c | 70 ++++++++++++++++++++++++++++++++++++++++= ++++++ > tests/checkasm/checkasm.c | 3 ++ > tests/checkasm/checkasm.h | 1 + > tests/fate/checkasm.mak | 3 +- > 5 files changed, 77 insertions(+), 1 deletion(-) [...] > +static void test_abs_pow34(AACEncContext *s) { > +#define BUF_SIZE 1024 > + LOCAL_ALIGNED_32(float, in, [BUF_SIZE]); > + > + declare_func(void, float *, const float *, int); > + > + randomize_float(in, BUF_SIZE); > + > + if (check_func(s->abs_pow34, "abs_pow34")) { > + LOCAL_ALIGNED_32(float, out, [BUF_SIZE]); > + LOCAL_ALIGNED_32(float, out2, [BUF_SIZE]); > + > + call_ref(out, in, BUF_SIZE); > + call_new(out2, in, BUF_SIZE); > + > + if (memcmp(out, out2, BUF_SIZE * sizeof(float)) !=3D 0) > + fail(); This is wrong if one of the functions is implemented in C C does not specify float to give bitexact results. Any equality check with float thats expected to end in a reproduceable outcome is generally wrong it also fails in practice TEST checkasm-aacencdsp Test checkasm-aacencdsp failed. Look at tests/data/fate/checkasm-aacencdsp.= err for details. src/tests/Makefile:308: recipe for target 'fate-checkasm-aacencdsp' failed make: *** [fate-checkasm-aacencdsp] Error 1 checkasm: using random seed 2523748868 SSE: abs_pow34_sse (aacencdsp.c:55) - aacencdsp.abs_pow34 [FAILED] checkasm: 1 of 1 tests have failed threads=3D1 thats on plain simple x86-32 thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Breaking DRM is a little like attempting to break through a door even though the window is wide open and the only thing in the house is a bunch of things you dont want and which you would get tomorrow for free anyway --FxlYARId5dseejUu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZbAOVAAKCRBhHseHBAsP q7JOAKCAfKvVMTsEN0exToX8R/uTU7EoCACgkehxYCjKDYQdtsrKb2fSjzLLIys= =llyx -----END PGP SIGNATURE----- --FxlYARId5dseejUu-- --===============3770947252582577341== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3770947252582577341==--