From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1644D489C5 for ; Mon, 22 Jan 2024 18:09:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D9DB868D068; Mon, 22 Jan 2024 20:09:16 +0200 (EET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 24D8F6800D8 for ; Mon, 22 Jan 2024 20:09:11 +0200 (EET) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1d746856d85so6369475ad.0 for ; Mon, 22 Jan 2024 10:09:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705946948; x=1706551748; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=UjYIY2NYYMkEvDza6Rwre0IoqI6W/QJeU5RFry0wtWo=; b=a6roovQiz6GbXag+FGbrF3phAja3Fz4m4tQoebneQkK9fYO99PbJErJ5d2yHLdQFu5 qnaT7MIdcBc8gdQ2aw34fy6VqBazzIQMtZ4BSD5VbOQixlhHQGZcUujVFRweAIKWWVqD tytFwqxBoJSDF+HKJlmUEyq0Ly15Tgh7VbcNJ/rTVxFc7bMXdWTQABhy30YcSaUvP/gh uLRpoOsU3/mp8GYjG61QzXNbkQOLr69LZFYJuwM/E2oN/0fTioWqALsnm6V6EgLrC76z XXum+EcbDPIc6rhRCIlAjEZqpLWMV2kI707orWHftEZDcP8ZQ6QBrONLs/LsshbhUsWF CHTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705946948; x=1706551748; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UjYIY2NYYMkEvDza6Rwre0IoqI6W/QJeU5RFry0wtWo=; b=hPDBKHh6M2ZzTL360O4Em0fHmo+LcDvmD5msUUh7Lbk4ErSlHZCSKh9zInrytqUxQY 8+F1LKptHfbfMWfcGL13c07ltWGx2k4HzY9plGi1tTbibdKxuOez11k5VMQufXIxzfs2 bmUMWHoYPt//22IMTF9TjqnLO5hWsy0UDRdiNINyCYsd45BGWgp6SwFJDIPDaK5oTS7r g9xtf/8akYaAaPlGm00FOltK76FA4KYoMTUn/fVsyrZPRb3dLYCjKGQJ3VsWhbHTEiuA +dHDnCy2C7rc5e+ly+AX2JJbDegHDupWvj3y+gNF12DZ0uAkyyHO8KmooDRh12SzyrgP xdfQ== X-Gm-Message-State: AOJu0YxzdBttcMTuiynKD5rSGKAoc0SIjA9UnXC2egKG/ZJvXF7pWmlM uMIBNjwpnDP9FCxa96G7FHgdVUoYqgMZybNtBU3bLh7aB2keYXyJREN2WSJf X-Google-Smtp-Source: AGHT+IGGu/DTZrBF7k3pBHf9wmi5UsjIVGeJe+zpv/bvAGm5rfWo51CPEUgp/KZbZ6UKtNmOgZjUsg== X-Received: by 2002:a17:902:6a89:b0:1d5:7a46:91f7 with SMTP id n9-20020a1709026a8900b001d57a4691f7mr2243555plk.120.1705946948032; Mon, 22 Jan 2024 10:09:08 -0800 (PST) Received: from localhost.localdomain (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id bj7-20020a170902850700b001d4bb7cdc11sm7477520plb.88.2024.01.22.10.09.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 10:09:06 -0800 (PST) From: James Almer To: ffmpeg-devel@ffmpeg.org Date: Mon, 22 Jan 2024 15:09:00 -0300 Message-ID: <20240122180902.4555-1-jamrial@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/3 v3] avformat: add a Tile Grid stream group type X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: This will be used to support tiled image formats like HEIF. Signed-off-by: James Almer --- Moved the struct to libavformat. It can be moved to libavutil if we decide to reuse it. libavformat/avformat.c | 8 ++++ libavformat/avformat.h | 86 ++++++++++++++++++++++++++++++++++++++++++ libavformat/dump.c | 42 +++++++++++++++++++++ libavformat/options.c | 32 ++++++++++++++++ 4 files changed, 168 insertions(+) diff --git a/libavformat/avformat.c b/libavformat/avformat.c index 882927f7b1..58dfa0746a 100644 --- a/libavformat/avformat.c +++ b/libavformat/avformat.c @@ -100,6 +100,14 @@ void ff_free_stream_group(AVStreamGroup **pstg) av_iamf_mix_presentation_free(&stg->params.iamf_mix_presentation); break; } + case AV_STREAM_GROUP_PARAMS_TILE_GRID: { + if (stg->params.tile_grid) { + av_freep(&stg->params.tile_grid->tile_width); + av_freep(&stg->params.tile_grid->tile_height); + } + av_freep(&stg->params.tile_grid); + break; + } default: break; } diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 5d0fe82250..ab9a3fc6be 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -1022,11 +1022,96 @@ enum AVStreamGroupParamsType { AV_STREAM_GROUP_PARAMS_NONE, AV_STREAM_GROUP_PARAMS_IAMF_AUDIO_ELEMENT, AV_STREAM_GROUP_PARAMS_IAMF_MIX_PRESENTATION, + AV_STREAM_GROUP_PARAMS_TILE_GRID, }; struct AVIAMFAudioElement; struct AVIAMFMixPresentation; +/** + * AVTileGrid holds information on how to combine several independent images in + * a single grid for presentation. + * + * Its size is not a part of the ABI. No new fields may be added to this struct + * without a major version bump. + */ +typedef struct AVTileGrid { + const AVClass *av_class; + + /** + * Amount of rows in the grid. + * + * Must be > 0. + */ + int tile_rows; + /** + * Amount of columns in the grid. + * + * Must be > 0. + */ + int tile_cols; + + /** + * A @ref tile_rows * @ref tile_cols sized array of width values for each + * tile in the grid, in row major order. + * The sum of tile width values must be consistent across all rows. + * + * Must be allocated with the av_malloc() family of functions, and will be + * freed by av_tile_grid_free(). + */ + int *tile_width; + + /** + * A @ref tile_rows * @ref tile_cols sized array of height values for each + * tile in the grid, in row major order. + * The sum of tile height values must be consistent across all columns. + * + * Must be allocated with the av_malloc() family of functions, and will be + * freed by av_tile_grid_free(). + */ + int *tile_height; + + /** + * Offset in pixels from the left edge of the grid where the actual image + * meant for presentation starts. + * + * This field must be >= 0 and <= the sum of values for a row in the + * tile_width array minus @ref output_width. + */ + int horizontal_offset; + /** + * Offset in pixels from the top edge of the grid where the actual image meant + * for presentation starts. + * + * This field must be >= 0 and <= the sum of values for a column in the + * tile_height array minus @ref output_height. + */ + int vertical_offset; + + /** + * Width of the final image for presentation. + * + * Must be > 0 and <= the sum of values for a row in the tile_width array + * minus @ref horizontal_offset. + * When it's not equal to the sum of values for a row in the tile_width array, + * the result of said sum minus output_width minus @ref horizontal_offset is + * the amount of pixels to be cropped from the right edge of the final image + * before presentation. + */ + int output_width; + /** + * Height of the final image for presentation. + * + * Must be > 0 and <= the sum of values for a column in the tile_height array + * minus @ref vertical_offset. + * When it's not equal to the sum of values for a column in the tile_height, + * the result of said sum minus output_height minus @ref vertical_offset is + * the amount of pixels to be cropped from the bottom edge of the final image + * before presentation. + */ + int output_height; +} AVTileGrid; + typedef struct AVStreamGroup { /** * A class for @ref avoptions. Set by avformat_stream_group_create(). @@ -1062,6 +1147,7 @@ typedef struct AVStreamGroup { union { struct AVIAMFAudioElement *iamf_audio_element; struct AVIAMFMixPresentation *iamf_mix_presentation; + struct AVTileGrid *tile_grid; } params; /** diff --git a/libavformat/dump.c b/libavformat/dump.c index aff51b43f6..5a8b5d7160 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -22,6 +22,7 @@ #include #include +#include "libavutil/avstring.h" #include "libavutil/channel_layout.h" #include "libavutil/display.h" #include "libavutil/iamf.h" @@ -513,6 +514,10 @@ static void dump_sidedata(void *ctx, const AVStream *st, const char *indent, av_log(ctx, log_level, "SMPTE ST 12-1:2014: "); dump_s12m_timecode(ctx, st, sd, log_level); break; + case AV_PKT_DATA_TILE_INFO: + av_log(ctx, log_level, "HEIF tile info: tile %u/%u", + AV_RL32(sd->data) + 1U, AV_RL32(sd->data + 4)); + break; default: av_log(ctx, log_level, "unknown side data type %d " "(%"SIZE_SPECIFIER" bytes)", sd->type, sd->size); @@ -639,6 +644,8 @@ static void dump_stream_format(const AVFormatContext *ic, int i, av_log(NULL, log_level, " (still image)"); if (st->disposition & AV_DISPOSITION_NON_DIEGETIC) av_log(NULL, log_level, " (non-diegetic)"); + if (st->disposition & AV_DISPOSITION_TILE) + av_log(NULL, log_level, " (tile)"); av_log(NULL, log_level, "\n"); dump_metadata(NULL, st->metadata, extra_indent, log_level); @@ -720,6 +727,41 @@ static void dump_stream_group(const AVFormatContext *ic, uint8_t *printed, } } break; + case AV_STREAM_GROUP_PARAMS_TILE_GRID: { + const AVTileGrid *tile_grid = stg->params.tile_grid; + AVCodecContext *avctx = avcodec_alloc_context3(NULL); + const char *ptr = NULL; + av_log(NULL, AV_LOG_INFO, " Tile Grid:"); + av_log(NULL, AV_LOG_VERBOSE, " %d rows, %d columns,", tile_grid->tile_rows, tile_grid->tile_cols); + if (avctx && stg->nb_streams && !avcodec_parameters_to_context(avctx, stg->streams[0]->codecpar)) { + int size = tile_grid->tile_rows * tile_grid->tile_cols; + int coded_width = 0, coded_height = 0; + avctx->width = tile_grid->output_width; + avctx->height = tile_grid->output_height; + for (int j = 0; j < tile_grid->tile_cols; j++) + coded_width += tile_grid->tile_width[j]; + for (int j = 0; j < size; j += tile_grid->tile_cols) + coded_height += tile_grid->tile_height[j]; + avctx->coded_width = coded_width; + avctx->coded_height = coded_height; + if (ic->dump_separator) + av_opt_set(avctx, "dump_separator", ic->dump_separator, 0); + buf[0] = 0; + avcodec_string(buf, sizeof(buf), avctx, is_output); + ptr = av_stristr(buf, " "); + } + avcodec_free_context(&avctx); + if (ptr) + av_log(NULL, AV_LOG_INFO, "%s", ptr); + av_log(NULL, AV_LOG_INFO, "\n"); + dump_metadata(NULL, stg->metadata, " ", AV_LOG_INFO); + for (int i = 0; i < stg->nb_streams; i++) { + const AVStream *st = stg->streams[i]; + dump_stream_format(ic, st->index, i, index, is_output, AV_LOG_VERBOSE); + printed[st->index] = 1; + } + break; + } } default: break; diff --git a/libavformat/options.c b/libavformat/options.c index 75ec86ce05..31620013c6 100644 --- a/libavformat/options.c +++ b/libavformat/options.c @@ -337,6 +337,26 @@ fail: return NULL; } +#define FLAGS AV_OPT_FLAG_ENCODING_PARAM | AV_OPT_FLAG_VIDEO_PARAM +#define OFFSET(x) offsetof(AVTileGrid, x) +static const AVOption tile_grid_options[] = { + { "tile_rows", NULL, OFFSET(tile_rows), AV_OPT_TYPE_INT, { .i64 = 1 }, 1, INT_MAX, FLAGS }, + { "tile_cols", NULL, OFFSET(tile_cols), AV_OPT_TYPE_INT, { .i64 = 1 }, 1, INT_MAX, FLAGS }, + { "horizontal_offset", NULL, OFFSET(horizontal_offset), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, INT_MAX, FLAGS }, + { "vertical_offset", NULL, OFFSET(vertical_offset), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, INT_MAX, FLAGS }, + { "output_size", "size of the output image", OFFSET(output_width), AV_OPT_TYPE_IMAGE_SIZE, + { .str = NULL }, 0, INT_MAX, FLAGS }, + { NULL }, +}; +#undef FLAGS +#undef OFFSET + +static const AVClass tile_grid_class = { + .class_name = "AVTileGrid", + .version = LIBAVUTIL_VERSION_INT, + .option = tile_grid_options, +}; + static void *stream_group_child_next(void *obj, void *prev) { AVStreamGroup *stg = obj; @@ -346,6 +366,8 @@ static void *stream_group_child_next(void *obj, void *prev) return stg->params.iamf_audio_element; case AV_STREAM_GROUP_PARAMS_IAMF_MIX_PRESENTATION: return stg->params.iamf_mix_presentation; + case AV_STREAM_GROUP_PARAMS_TILE_GRID: + return stg->params.tile_grid; default: break; } @@ -368,6 +390,9 @@ static const AVClass *stream_group_child_iterate(void **opaque) case AV_STREAM_GROUP_PARAMS_IAMF_MIX_PRESENTATION: ret = av_iamf_mix_presentation_get_class(); break; + case AV_STREAM_GROUP_PARAMS_TILE_GRID: + ret = &tile_grid_class; + break; default: break; } @@ -429,6 +454,13 @@ AVStreamGroup *avformat_stream_group_create(AVFormatContext *s, if (!stg->params.iamf_mix_presentation) goto fail; break; + case AV_STREAM_GROUP_PARAMS_TILE_GRID: + stg->params.tile_grid = av_mallocz(sizeof(*stg->params.tile_grid)); + if (!stg->params.tile_grid) + goto fail; + stg->params.tile_grid->av_class = &tile_grid_class; + av_opt_set_defaults(stg->params.tile_grid); + break; default: goto fail; } -- 2.43.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".