From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 7B37A48969
	for <ffmpegdev@gitmailbox.com>; Mon, 22 Jan 2024 14:34:20 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1D91068CF0F;
	Mon, 22 Jan 2024 16:34:17 +0200 (EET)
Received: from devianza.investici.org (unknown [198.167.222.108])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0A3E668ABB5
 for <ffmpeg-devel@ffmpeg.org>; Mon, 22 Jan 2024 16:34:10 +0200 (EET)
Received: from mx2.investici.org (unknown [127.0.0.1])
 by devianza.investici.org (Postfix) with ESMTP id 4TJXm10Jltz6vKW
 for <ffmpeg-devel@ffmpeg.org>; Mon, 22 Jan 2024 14:34:09 +0000 (UTC)
Received: from [198.167.222.108] (mx2.investici.org [198.167.222.108])
 (Authenticated sender: mehw.is.me@inventati.org) by localhost (Postfix) with
 ESMTPSA id 4TJXm05GH5z6vJN
 for <ffmpeg-devel@ffmpeg.org>; Mon, 22 Jan 2024 14:34:08 +0000 (UTC)
Date: Mon, 22 Jan 2024 15:34:09 +0100
To: ffmpeg-devel@ffmpeg.org
Message-ID: <20240122153409.318a74cd@pineapple>
X-Mailer: Claws Mail 4.2.0 (GTK 3.24.39; x86_64-pc-linux-gnu)
In-Reply-To: <69fee92-3969-d1a3-59e6-5a7d5baada1@martin.st>
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH] configure: autodetect libglslang ldflags
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
From: Matthew White via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Matthew White <mehw.is.me@inventati.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20240122153409.318a74cd@pineapple/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

> Also, how does this work when cross compiling - won't the "glslang" binary 
> be for the foreign cross target? Or is it something like the sdl-config 
> script which is a local shell script that can give relevant build flags (a 
> design preceding pkg-config)?

I don't have an answer to that, in FFmpeg's configure I saw using something like
`[ -x "$(command -v gzip)" ] && enable gzip`, so I replicated it to check on the
glslang's binary.  I guess that who is ready to cross compile may try this patch
with glslang installed to tell what's happening.

I worked on this fix in GNU/Linux Gentoo.  Trying both glslang 14.0.0 and 13.1.1
only the latter requires "-lOSDependent -lHLSL -lOGLCompiler".  I configured the
compilation with `./configure --enable-libglslang`, the stub flags/libraries are
not required for glslang 14.0.0.  I can compile FFmpeg 6.1.1 by backporting this
patch.

This patch may be dropped altogether by locking FFmpeg on glslang 14.0.0 and up,
and removing the stub "-lOSDependent -lHLSL -lOGLCompiler" flags/libraries.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".