From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D3166488E3 for ; Sun, 21 Jan 2024 21:02:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CB13768CFAC; Sun, 21 Jan 2024 23:02:07 +0200 (EET) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 139E768CD68 for ; Sun, 21 Jan 2024 23:02:02 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 31692FF802 for ; Sun, 21 Jan 2024 21:02:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1705870921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LJ2HEjSgc1qZXni1lgzUqrdZBTWZ63wXY6622QqXw1E=; b=La02CQk9gAJt5SkBfAHvlBAv4vssGlWDwOuXXwYB2vHIzIPV63Gno7/Faq3Mwl37fQKVVZ OvuGelTisLbN9tS+UdhuEE0hwEu1OvnAmgMBgA1+Wog3RZheYmEbzSu3/zisRj+jC1kgag Yr5IRvFidV+iRi/b8FKQ4aQ8u7WGJC31e6gdlAoql/Da/PqX8sTGEZb7K1l9TEiHvs4LR4 X91nAei7GV9ts7HoCHh+gpVT3XXUc19IW4HKdc2Y1LxwOrdyR4UO2cy7O3w0J9gTFckxSa fK5uVGRb62BvPQKeaUFth0ykXN1WRqFYr3afhMWd9PC+z7GaJQwpCMkk+xZ14g== Date: Sun, 21 Jan 2024 22:02:00 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240121210200.GY6420@pb2> References: <52ca345f-f482-4b74-887c-84f541b9fab8@gmail.com> MIME-Version: 1.0 In-Reply-To: <52ca345f-f482-4b74-887c-84f541b9fab8@gmail.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] liavcodec: add bit-rate support to RoQ video encoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0859500514244494479==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0859500514244494479== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bT3EhHLNivzL+hyp" Content-Disposition: inline --bT3EhHLNivzL+hyp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 21, 2024 at 11:19:43PM +0300, Victor Luchits wrote: > One can now use the bitrate option (-b) to specify bit rate of the video > stream in the RoQ encoder. The option only becomes effective for values > above 800kbit/s, which is roughly equivalent to bandwidth of a 1x-speed > CD-ROM drive, minus the bandwidth taken up by stereo DPCM stream. Values > below this threshold produce visually inadequate results. >=20 > Original patch by Joseph Fenton aka Chilly Willy >=20 > Signed-off-by: Victor Luchits [...] > diff --git a/libavcodec/roqvideodec.c b/libavcodec/roqvideodec.c > index bfc69a65c9..07d6b8bb8f 100644 > --- a/libavcodec/roqvideodec.c > +++ b/libavcodec/roqvideodec.c > @@ -70,6 +70,7 @@ static void roqvideo_decode_frame(RoqContext *ri, > GetByteContext *gb) > chunk_start =3D bytestream2_tell(gb); > xpos =3D ypos =3D 0; > + ri->key_frame =3D 1; > if (chunk_size > bytestream2_get_bytes_left(gb)) { > av_log(ri->logctx, AV_LOG_ERROR, "Chunk does not fit in input > buffer\n"); > @@ -92,12 +93,14 @@ static void roqvideo_decode_frame(RoqContext *ri, > GetByteContext *gb) > switch(vqid) { There seems to be some line wraping problem please repost the patch without linewraping / extra newlines Applying: liavcodec: add bit-rate support to RoQ video encoder error: corrupt patch at line 20 error: could not build fake ancestor Patch failed at 0001 liavcodec: add bit-rate support to RoQ video encoder Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have never wished to cater to the crowd; for what I know they do not approve, and what they approve I do not know. -- Epicurus --bT3EhHLNivzL+hyp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZa2GQQAKCRBhHseHBAsP qys5AJ9muY57770lofMHgR2kXLfMVhb1HwCggqF1jxKNLeTWnEQZkypHOfogTP4= =od27 -----END PGP SIGNATURE----- --bT3EhHLNivzL+hyp-- --===============0859500514244494479== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0859500514244494479==--