Re: [FFmpeg-devel] [PATCH] liavcodec: add bit-rate support to RoQ video encoder

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 2011 bytes --]

On Sun, Jan 21, 2024 at 11:19:43PM +0300, Victor Luchits wrote:
> One can now use the bitrate option (-b) to specify bit rate of the video
> stream in the RoQ encoder. The option only becomes effective for values
> above 800kbit/s, which is roughly equivalent to bandwidth of a 1x-speed
> CD-ROM drive, minus the bandwidth taken up by stereo DPCM stream. Values
> below this threshold produce visually inadequate results.
> 
> Original patch by Joseph Fenton aka Chilly Willy
> 
> Signed-off-by: Victor Luchits <vluchits@gmail.com>

[...]

> diff --git a/libavcodec/roqvideodec.c b/libavcodec/roqvideodec.c
> index bfc69a65c9..07d6b8bb8f 100644
> --- a/libavcodec/roqvideodec.c
> +++ b/libavcodec/roqvideodec.c
> @@ -70,6 +70,7 @@ static void roqvideo_decode_frame(RoqContext *ri,
> GetByteContext *gb)
>       chunk_start = bytestream2_tell(gb);
>      xpos = ypos = 0;
> +    ri->key_frame = 1;
>       if (chunk_size > bytestream2_get_bytes_left(gb)) {
>          av_log(ri->logctx, AV_LOG_ERROR, "Chunk does not fit in input
> buffer\n");
> @@ -92,12 +93,14 @@ static void roqvideo_decode_frame(RoqContext *ri,
> GetByteContext *gb)
>                   switch(vqid) {

There seems to be some line wraping problem

please repost the patch without linewraping / extra newlines

Applying: liavcodec: add bit-rate support to RoQ video encoder
error: corrupt patch at line 20
error: could not build fake ancestor
Patch failed at 0001 liavcodec: add bit-rate support to RoQ video encoder
Use 'git am --show-current-patch' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".


thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".