From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat: add a Tile Grid stream group type
Date: Fri, 19 Jan 2024 22:22:00 +0100
Message-ID: <20240119212200.GV6420@pb2> (raw)
In-Reply-To: <20240117204133.11142-2-jamrial@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1482 bytes --]
On Wed, Jan 17, 2024 at 05:41:33PM -0300, James Almer wrote:
> This will be used to support tiled image formats like HEIF.
>
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
> libavformat/avformat.c | 5 +++++
> libavformat/avformat.h | 3 +++
> libavformat/dump.c | 36 ++++++++++++++++++++++++++++++++++++
> libavformat/options.c | 9 +++++++++
> 4 files changed, 53 insertions(+)
Iam sure ive forgotten something but this fails build
libavformat/dump.c: In function ‘dump_stream_group’:
libavformat/dump.c:722:9: error: too many arguments to function ‘dump_metadata’
dump_metadata(NULL, stg->metadata, " ", AV_LOG_INFO);
^~~~~~~~~~~~~
libavformat/dump.c:166:13: note: declared here
static void dump_metadata(void *ctx, const AVDictionary *m, const char *indent)
^~~~~~~~~~~~~
libavformat/dump.c:746:13: error: too many arguments to function ‘dump_stream_format’
dump_stream_format(ic, st->index, i, index, is_output, AV_LOG_VERBOSE);
^~~~~~~~~~~~~~~~~~
libavformat/dump.c:522:13: note: declared here
static void dump_stream_format(const AVFormatContext *ic, int i,
^~~~~~~~~~~~~~~~~~
ffbuild/common.mak:81: recipe for target 'libavformat/dump.o' failed
make: *** [libavformat/dump.o] Error 1
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Avoid a single point of failure, be that a person or equipment.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-01-19 21:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 20:41 [FFmpeg-devel] [PATCH 1/2] avutil: add a Tile Grid API James Almer
2024-01-17 20:41 ` [FFmpeg-devel] [PATCH 2/2] avformat: add a Tile Grid stream group type James Almer
2024-01-19 21:22 ` Michael Niedermayer [this message]
2024-01-19 21:24 ` James Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240119212200.GV6420@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git