* [FFmpeg-devel] [PATCH 1/2] avutil: add a Tile Grid API
@ 2024-01-17 20:41 James Almer
2024-01-17 20:41 ` [FFmpeg-devel] [PATCH 2/2] avformat: add a Tile Grid stream group type James Almer
0 siblings, 1 reply; 4+ messages in thread
From: James Almer @ 2024-01-17 20:41 UTC (permalink / raw)
To: ffmpeg-devel
This includes a struct and helpers. It will be used to support container level
tiled image formats like HEIF, but should be generic enough for general usage.
Signed-off-by: James Almer <jamrial@gmail.com>
---
libavutil/Makefile | 2 +
libavutil/tile.c | 72 +++++++++++++++++++++++++
libavutil/tile.h | 132 +++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 206 insertions(+)
create mode 100644 libavutil/tile.c
create mode 100644 libavutil/tile.h
diff --git a/libavutil/Makefile b/libavutil/Makefile
index e7709b97d0..380d706cfe 100644
--- a/libavutil/Makefile
+++ b/libavutil/Makefile
@@ -82,6 +82,7 @@ HEADERS = adler32.h \
spherical.h \
stereo3d.h \
threadmessage.h \
+ tile.h \
time.h \
timecode.h \
timestamp.h \
@@ -172,6 +173,7 @@ OBJS = adler32.o \
spherical.o \
stereo3d.o \
threadmessage.o \
+ tile.o \
time.o \
timecode.o \
tree.o \
diff --git a/libavutil/tile.c b/libavutil/tile.c
new file mode 100644
index 0000000000..d6a95d85ed
--- /dev/null
+++ b/libavutil/tile.c
@@ -0,0 +1,72 @@
+/*
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * FFmpeg is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with FFmpeg; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+#include <stdint.h>
+#include <limits.h>
+
+#include "log.h"
+#include "mem.h"
+#include "opt.h"
+#include "tile.h"
+
+#define FLAGS AV_OPT_FLAG_ENCODING_PARAM | AV_OPT_FLAG_VIDEO_PARAM
+#define OFFSET(x) offsetof(AVTileGrid, x)
+static const AVOption tile_grid_options[] = {
+ { "type", NULL, OFFSET(type), AV_OPT_TYPE_INT,
+ { .i64 = AV_TILE_DIMENSION_TYPE_UNIFORM },
+ AV_TILE_DIMENSION_TYPE_UNIFORM, AV_TILE_DIMENSION_TYPE_VARIABLE, FLAGS, "type" },
+ { "uniform", NULL, 0, AV_OPT_TYPE_CONST,
+ { .i64 = AV_TILE_DIMENSION_TYPE_UNIFORM }, .unit = "type" },
+ { "variable", NULL, 0, AV_OPT_TYPE_CONST,
+ { .i64 = AV_TILE_DIMENSION_TYPE_VARIABLE }, .unit = "type" },
+ { "tile_rows", NULL, OFFSET(tile_rows), AV_OPT_TYPE_INT64, { .i64 = 0 }, 0, UINT_MAX, FLAGS },
+ { "tile_cols", NULL, OFFSET(tile_cols), AV_OPT_TYPE_INT64, { .i64 = 0 }, 0, UINT_MAX, FLAGS },
+ { "output_size", "size of the output image", OFFSET(output_width), AV_OPT_TYPE_IMAGE_SIZE,
+ { .str = NULL }, 0, INT_MAX, FLAGS },
+ { NULL },
+};
+
+static const AVClass tile_grid_class = {
+ .class_name = "AVTileGrid",
+ .version = LIBAVUTIL_VERSION_INT,
+ .option = tile_grid_options,
+};
+
+const AVClass *av_tile_grid_get_class(void)
+{
+ return &tile_grid_class;
+}
+
+AVTileGrid *av_tile_grid_alloc(void)
+{
+ return av_mallocz(sizeof(AVTileGrid));
+}
+
+void av_tile_grid_free(AVTileGrid **ptile_grid)
+{
+ AVTileGrid *tile_grid = *ptile_grid;
+
+ if (!tile_grid)
+ return;
+
+ if (tile_grid->type == AV_TILE_DIMENSION_TYPE_VARIABLE) {
+ av_freep(&tile_grid->w.tile_widths);
+ av_freep(&tile_grid->h.tile_heights);
+ }
+ av_freep(ptile_grid);
+}
diff --git a/libavutil/tile.h b/libavutil/tile.h
new file mode 100644
index 0000000000..fb8af0d56f
--- /dev/null
+++ b/libavutil/tile.h
@@ -0,0 +1,132 @@
+/*
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * FFmpeg is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with FFmpeg; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+#ifndef AVUTIL_TILE_H
+#define AVUTIL_TILE_H
+
+#include <stdint.h>
+
+#include "log.h"
+
+/**
+ * @defgroup lavu_tile_grid Tile grid paremeters
+ * @{
+ */
+
+enum AVTileGridType {
+ AV_TILE_DIMENSION_TYPE_UNIFORM, ///< All tiles have the same size
+ AV_TILE_DIMENSION_TYPE_VARIABLE, ///< Tiles may have variable size
+};
+
+typedef struct AVTileGrid {
+ const AVClass *av_class;
+
+ int tile_rows; ///< rows in the final grid
+ int tile_cols; ///< cols in the final grid
+
+ enum AVTileGridType type;
+
+ union {
+ /**
+ * Height of every tile.
+ * This member must be used when the type is AV_TILE_DIMENSION_TYPE_UNIFORM.
+ */
+ int tile_height;
+ /**
+ * A @ref tile_rows * @ref tile_cols sized array of height values for each
+ * tile in the grid, in row major order.
+ * This member must be used when the type is AV_TILE_DIMENSION_TYPE_VARIABLE
+ *
+ * Must be allocated with the av_malloc() family of functions, and will be
+ * freed by av_tile_grid_free().
+ */
+ int *tile_heights;
+ } h;
+
+ union {
+ /**
+ * Width of every tile.
+ * This member must be used when the type is AV_TILE_DIMENSION_TYPE_UNIFORM.
+ */
+ int tile_width;
+ /**
+ * A @ref tile_rows * @ref tile_cols sized array of width values for each
+ * tile in the grid, in row major order.
+ * This member must be used when the type is AV_TILE_DIMENSION_TYPE_VARIABLE
+ *
+ * Must be allocated with the av_malloc() family of functions, and will be
+ * freed by av_tile_grid_free().
+ */
+ int *tile_widths;
+ } w;
+
+ /**
+ * Width of the final image for presentation.
+ *
+ * When @ref type is AV_TILE_DIMENSION_TYPE_UNIFORM, this field must be > 0
+ * and <= tile_width * tile_cols.
+ * When it's not equal to tile_width * tile_cols, the result of
+ * (tile_width * tile_cols) - output_width is the amount of pixels to be
+ * cropped from the right edge of the final image before presentation.
+ *
+ * When @ref type is AV_TILE_DIMENSION_TYPE_VARIABLE, this field must be > 0
+ * and <= the sum of all values in the tile_widths array.
+ * When it's not equal to the sum of all values in the tile_widths array,
+ * the result of said sum minus output_width is the amount of pixels to be
+ * cropped from the right edge of the final image before presentation.
+ */
+ int output_width;
+ /**
+ * Height of the final image for presentation.
+ *
+ * When @ref type is AV_TILE_DIMENSION_TYPE_UNIFORM, this field must be > 0
+ * and <= tile_height * tile_rows.
+ * When it's not equal to tile_height * tile_rows, the result of
+ * (tile_height * tile_rows) - output_width is the amount of pixels to be
+ * cropped from the bottom edge of the final image before presentation.
+ *
+ * When @ref type is AV_TILE_DIMENSION_TYPE_VARIABLE, this field must be > 0
+ * and <= the sum of all values in the tile_heights array.
+ * When it's not equal to the sum of all values in the tile_heights array,
+ * the result of said sum minus output_height is the amount of pixels to be
+ * cropped from the bottom edge of the final image before presentation.
+ */
+ int output_height;
+} AVTileGrid;
+
+const AVClass *av_tile_grid_get_class(void);
+
+/**
+ * Allocates a AVTileGrid, and initializes its fields with default values.
+ * Must be freed with av_tile_grid_free().
+ */
+AVTileGrid *av_tile_grid_alloc(void);
+
+/**
+ * Free an AVTileGrid and all its contents.
+ *
+ * @param tile_grid pointer to pointer to an allocated AVTileGrid.
+ * upon return, *tile_grid will be set to NULL.
+ */
+void av_tile_grid_free(AVTileGrid **tile_grid);
+
+/**
+ * @}
+ */
+
+#endif /* AVUTIL_TILE_H */
--
2.43.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* [FFmpeg-devel] [PATCH 2/2] avformat: add a Tile Grid stream group type
2024-01-17 20:41 [FFmpeg-devel] [PATCH 1/2] avutil: add a Tile Grid API James Almer
@ 2024-01-17 20:41 ` James Almer
2024-01-19 21:22 ` Michael Niedermayer
0 siblings, 1 reply; 4+ messages in thread
From: James Almer @ 2024-01-17 20:41 UTC (permalink / raw)
To: ffmpeg-devel
This will be used to support tiled image formats like HEIF.
Signed-off-by: James Almer <jamrial@gmail.com>
---
libavformat/avformat.c | 5 +++++
libavformat/avformat.h | 3 +++
libavformat/dump.c | 36 ++++++++++++++++++++++++++++++++++++
libavformat/options.c | 9 +++++++++
4 files changed, 53 insertions(+)
diff --git a/libavformat/avformat.c b/libavformat/avformat.c
index 882927f7b1..a7bd959db5 100644
--- a/libavformat/avformat.c
+++ b/libavformat/avformat.c
@@ -30,6 +30,7 @@
#include "libavutil/opt.h"
#include "libavutil/pixfmt.h"
#include "libavutil/samplefmt.h"
+#include "libavutil/tile.h"
#include "libavcodec/avcodec.h"
#include "libavcodec/codec.h"
#include "libavcodec/bsf.h"
@@ -100,6 +101,10 @@ void ff_free_stream_group(AVStreamGroup **pstg)
av_iamf_mix_presentation_free(&stg->params.iamf_mix_presentation);
break;
}
+ case AV_STREAM_GROUP_PARAMS_TILE_GRID: {
+ av_tile_grid_free(&stg->params.tile_grid);
+ break;
+ }
default:
break;
}
diff --git a/libavformat/avformat.h b/libavformat/avformat.h
index 5d0fe82250..f259ad1367 100644
--- a/libavformat/avformat.h
+++ b/libavformat/avformat.h
@@ -1022,10 +1022,12 @@ enum AVStreamGroupParamsType {
AV_STREAM_GROUP_PARAMS_NONE,
AV_STREAM_GROUP_PARAMS_IAMF_AUDIO_ELEMENT,
AV_STREAM_GROUP_PARAMS_IAMF_MIX_PRESENTATION,
+ AV_STREAM_GROUP_PARAMS_TILE_GRID,
};
struct AVIAMFAudioElement;
struct AVIAMFMixPresentation;
+struct AVTileGrid;
typedef struct AVStreamGroup {
/**
@@ -1062,6 +1064,7 @@ typedef struct AVStreamGroup {
union {
struct AVIAMFAudioElement *iamf_audio_element;
struct AVIAMFMixPresentation *iamf_mix_presentation;
+ struct AVTileGrid *tile_grid;
} params;
/**
diff --git a/libavformat/dump.c b/libavformat/dump.c
index aff51b43f6..84884121a1 100644
--- a/libavformat/dump.c
+++ b/libavformat/dump.c
@@ -22,6 +22,7 @@
#include <stdio.h>
#include <stdint.h>
+#include "libavutil/avstring.h"
#include "libavutil/channel_layout.h"
#include "libavutil/display.h"
#include "libavutil/iamf.h"
@@ -35,6 +36,7 @@
#include "libavutil/spherical.h"
#include "libavutil/stereo3d.h"
#include "libavutil/timecode.h"
+#include "libavutil/tile.h"
#include "libavcodec/avcodec.h"
@@ -720,6 +722,40 @@ static void dump_stream_group(const AVFormatContext *ic, uint8_t *printed,
}
}
break;
+ case AV_STREAM_GROUP_PARAMS_TILE_GRID: {
+ const AVTileGrid *tile_grid = stg->params.tile_grid;
+ AVCodecContext *avctx = avcodec_alloc_context3(NULL);
+ const char *ptr = NULL;
+ av_log(NULL, AV_LOG_INFO, " Tile Grid:");
+ dump_metadata(NULL, stg->metadata, " ", AV_LOG_INFO);
+ if (avctx && stg->nb_streams && !avcodec_parameters_to_context(avctx, ic->streams[0]->codecpar)) {
+ avctx->width = tile_grid->output_width;
+ avctx->height = tile_grid->output_height;
+ avctx->coded_width = FFALIGN(tile_grid->output_width, tile_grid->w.tile_width);
+ avctx->coded_height = FFALIGN(tile_grid->output_height, tile_grid->h.tile_height);
+ if (ic->dump_separator)
+ av_opt_set(avctx, "dump_separator", ic->dump_separator, 0);
+ buf[0] = 0;
+ avcodec_string(buf, sizeof(buf), avctx, is_output);
+ ptr = av_stristr(buf, " ");
+ }
+ avcodec_free_context(&avctx);
+ if (ptr) {
+ ptr++;
+ av_log(NULL, AV_LOG_INFO, " %s", ptr);
+ av_log(NULL, AV_LOG_VERBOSE, ",");
+ }
+ av_log(NULL, AV_LOG_VERBOSE, " %d rows, %d columns, tile size %dx%d",
+ tile_grid->tile_rows, tile_grid->tile_cols,
+ tile_grid->w.tile_width, tile_grid->h.tile_height);
+ av_log(NULL, AV_LOG_INFO, "\n");
+ for (int i = 0; i < stg->nb_streams; i++) {
+ const AVStream *st = stg->streams[i];
+ dump_stream_format(ic, st->index, i, index, is_output, AV_LOG_VERBOSE);
+ printed[st->index] = 1;
+ }
+ break;
+ }
}
default:
break;
diff --git a/libavformat/options.c b/libavformat/options.c
index e79ae221d9..dd33ea3470 100644
--- a/libavformat/options.c
+++ b/libavformat/options.c
@@ -30,6 +30,7 @@
#include "libavutil/internal.h"
#include "libavutil/intmath.h"
#include "libavutil/opt.h"
+#include "libavutil/tile.h"
/**
* @file
@@ -367,6 +368,9 @@ static const AVClass *stream_group_child_iterate(void **opaque)
case AV_STREAM_GROUP_PARAMS_IAMF_MIX_PRESENTATION:
ret = av_iamf_mix_presentation_get_class();
break;
+ case AV_STREAM_GROUP_PARAMS_TILE_GRID:
+ ret = av_tile_grid_get_class();
+ break;
default:
break;
}
@@ -427,6 +431,11 @@ AVStreamGroup *avformat_stream_group_create(AVFormatContext *s,
if (!stg->params.iamf_mix_presentation)
goto fail;
break;
+ case AV_STREAM_GROUP_PARAMS_TILE_GRID:
+ stg->params.tile_grid = av_tile_grid_alloc();
+ if (!stg->params.tile_grid)
+ goto fail;
+ break;
default:
goto fail;
}
--
2.43.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH 2/2] avformat: add a Tile Grid stream group type
2024-01-17 20:41 ` [FFmpeg-devel] [PATCH 2/2] avformat: add a Tile Grid stream group type James Almer
@ 2024-01-19 21:22 ` Michael Niedermayer
2024-01-19 21:24 ` James Almer
0 siblings, 1 reply; 4+ messages in thread
From: Michael Niedermayer @ 2024-01-19 21:22 UTC (permalink / raw)
To: FFmpeg development discussions and patches
[-- Attachment #1.1: Type: text/plain, Size: 1482 bytes --]
On Wed, Jan 17, 2024 at 05:41:33PM -0300, James Almer wrote:
> This will be used to support tiled image formats like HEIF.
>
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
> libavformat/avformat.c | 5 +++++
> libavformat/avformat.h | 3 +++
> libavformat/dump.c | 36 ++++++++++++++++++++++++++++++++++++
> libavformat/options.c | 9 +++++++++
> 4 files changed, 53 insertions(+)
Iam sure ive forgotten something but this fails build
libavformat/dump.c: In function ‘dump_stream_group’:
libavformat/dump.c:722:9: error: too many arguments to function ‘dump_metadata’
dump_metadata(NULL, stg->metadata, " ", AV_LOG_INFO);
^~~~~~~~~~~~~
libavformat/dump.c:166:13: note: declared here
static void dump_metadata(void *ctx, const AVDictionary *m, const char *indent)
^~~~~~~~~~~~~
libavformat/dump.c:746:13: error: too many arguments to function ‘dump_stream_format’
dump_stream_format(ic, st->index, i, index, is_output, AV_LOG_VERBOSE);
^~~~~~~~~~~~~~~~~~
libavformat/dump.c:522:13: note: declared here
static void dump_stream_format(const AVFormatContext *ic, int i,
^~~~~~~~~~~~~~~~~~
ffbuild/common.mak:81: recipe for target 'libavformat/dump.o' failed
make: *** [libavformat/dump.o] Error 1
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Avoid a single point of failure, be that a person or equipment.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH 2/2] avformat: add a Tile Grid stream group type
2024-01-19 21:22 ` Michael Niedermayer
@ 2024-01-19 21:24 ` James Almer
0 siblings, 0 replies; 4+ messages in thread
From: James Almer @ 2024-01-19 21:24 UTC (permalink / raw)
To: ffmpeg-devel
On 1/19/2024 6:22 PM, Michael Niedermayer wrote:
> On Wed, Jan 17, 2024 at 05:41:33PM -0300, James Almer wrote:
>> This will be used to support tiled image formats like HEIF.
>>
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>> libavformat/avformat.c | 5 +++++
>> libavformat/avformat.h | 3 +++
>> libavformat/dump.c | 36 ++++++++++++++++++++++++++++++++++++
>> libavformat/options.c | 9 +++++++++
>> 4 files changed, 53 insertions(+)
>
> Iam sure ive forgotten something but this fails build
My bad, i sent "avformat/dump: only print streams within a group in
verbose levels" as a patch independent of this set, but it goes before
these two patches.
>
> libavformat/dump.c: In function ‘dump_stream_group’:
> libavformat/dump.c:722:9: error: too many arguments to function ‘dump_metadata’
> dump_metadata(NULL, stg->metadata, " ", AV_LOG_INFO);
> ^~~~~~~~~~~~~
> libavformat/dump.c:166:13: note: declared here
> static void dump_metadata(void *ctx, const AVDictionary *m, const char *indent)
> ^~~~~~~~~~~~~
> libavformat/dump.c:746:13: error: too many arguments to function ‘dump_stream_format’
> dump_stream_format(ic, st->index, i, index, is_output, AV_LOG_VERBOSE);
> ^~~~~~~~~~~~~~~~~~
> libavformat/dump.c:522:13: note: declared here
> static void dump_stream_format(const AVFormatContext *ic, int i,
> ^~~~~~~~~~~~~~~~~~
> ffbuild/common.mak:81: recipe for target 'libavformat/dump.o' failed
> make: *** [libavformat/dump.o] Error 1
>
> [...]
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-19 21:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-17 20:41 [FFmpeg-devel] [PATCH 1/2] avutil: add a Tile Grid API James Almer
2024-01-17 20:41 ` [FFmpeg-devel] [PATCH 2/2] avformat: add a Tile Grid stream group type James Almer
2024-01-19 21:22 ` Michael Niedermayer
2024-01-19 21:24 ` James Almer
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git