From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 07D5B486CF for ; Tue, 16 Jan 2024 00:21:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 71C8E68CFDD; Tue, 16 Jan 2024 02:21:04 +0200 (EET) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 69CED68CF90 for ; Tue, 16 Jan 2024 02:20:57 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id D328C60003 for ; Tue, 16 Jan 2024 00:20:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1705364457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XCtgqhzr1c4heCMDlFURa5nRL3b+7Dog7oE97ZmmYTQ=; b=oC8Rp9hA0oyNzKDuziNt1K7Pu9bcZf08lgfD7llCuXRUb3BQ5FlwCFhhKOxDjVOeaLUezN tM/m460dyOkdRRxmV44C8ey6KQ+kdqW0N/wtMtIF8DW3iEMXSk06X9m70VOnURQY5uN8Lo 8WarL40pXGrtUeQHbB/DzOa5Tc12twvVOI/BY6vvSOTcVEltFH1gKVSfrWmcslrfoALnwe poa47NsxddlEJw5lsLZhts18bALfOa0ZLSwxxqGaSsTu8Ufhmv7P0DIucGAOk6pAEDm9zf CkwZDB7S42192+WeszdL17Vu5Q9t1nI/aSteJ40CVWX4Xa6VRed7RSWIzt67dw== Date: Tue, 16 Jan 2024 01:20:56 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240116002056.GL6420@pb2> References: <20240113182218.GE6420@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/rtsp: Send mode=record instead of mode=receive in Transport header X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6875293981972139222==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6875293981972139222== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0lQD6nQFU9C6sjiy" Content-Disposition: inline --0lQD6nQFU9C6sjiy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 15, 2024 at 10:37:25PM +0200, Paul Orlyk wrote: > Fixes server compatibility issues with rtspclientsink GStreamer plugin. >=20 > > From specification: > RFC 7826 "Real-Time Streaming Protocol Version 2.0" (https://datatracker.= ietf.org/doc/html/rfc7826), section 18.54: > mode: The mode parameter indicates the methods to be supported for > this session. The currently defined valid value is "PLAY". If > not provided, the default is "PLAY". The "RECORD" value was > defined in RFC 2326; in this specification, it is unspecified > but reserved. RECORD and other values may be specified in the > future. > RFC 2326 "Real Time Streaming Protocol (RTSP)" (https://datatracker.ietf.= org/doc/html/rfc2326), section 12.39: > mode: > The mode parameter indicates the methods to be supported for > this session. Valid values are PLAY and RECORD. If not > provided, the default is PLAY. >=20 > mode=3Dreceive was always like this, from the initial commit 'a8ad6ffa rt= sp: Add listen mode'. >=20 > For comparison, Wowza was used to push RTSP stream to. Both GStreamer and= FFmpeg had no issues. > Here is the capture of Wowza responding to SETUP request: > 200 OK > CSeq: 3 > Server: Wowza Streaming Engine 4.8.26+4 build20231212155517 > Cache-Control: no-cache > Expires: Mon, 15 Jan 2024 19:40:31 GMT > Transport: RTP/AVP/UDP;unicast;client_port=3D11640-11641;mode=3Drecord;so= urce=3D172.17.0.2;server_port=3D6976-6977 > Date: Mon, 15 Jan 2024 19:40:31 GMT > Session: 1401457689;timeout=3D60 >=20 > Test setup: > Server: ffmpeg -loglevel trace -y -rtsp_flags listen -i rtsp://0.0.0.= 0:30800/live.stream t.mp4 > FFmpeg client: ffmpeg -re -i "Big Buck Bunny - FULL HD 30FPS.mp4" -c:= v libx264 -f rtsp rtsp://127.0.0.1:30800/live.stream > GStreamer client: gst-launch-1.0 videotestsrc is-live=3Dtrue pattern= =3Dsmpte ! queue ! videorate ! videoscale ! video/x-raw,width=3D640,height= =3D360,framerate=3D60/1 ! timeoverlay font-desc=3D"Sans, 84" halignment=3Dc= enter valignment=3Dcenter ! queue ! videoconvert ! tee name=3Dt t. ! x264en= c bitrate=3D9000 pass=3Dcbr speed-preset=3Dultrafast byte-stream=3Dfalse ke= y-int-max=3D15 threads=3D1 ! video/x-h264,profile=3Dbaseline ! queue ! rsin= k. audiotestsrc ! voaacenc ! queue ! rsink. t. ! queue ! autovideosink rtsp= clientsink name=3Drsink location=3Drtsp://localhost:30800/live.stream >=20 > Test results: > modified FFmpeg client -> stock server : ok > stock FFmpeg client -> modified server : ok > modified FFmpeg client -> modified server : ok > GStreamer client -> modified server : ok >=20 > Signed-off-by: Paul Orlyk > --- > libavformat/rtspdec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Thats a nice commit message will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Whats the most studid thing your enemy could do ? Blow himself up Whats the most studid thing you could do ? Give up your rights and freedom because your enemy blew himself up. --0lQD6nQFU9C6sjiy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZaXL4QAKCRBhHseHBAsP q1U0AKCXIhjO+iEwzi6cAtb3jSyDdJidnACeL5beQLMrHJRynoVR0gwchB+yK+k= =L2Yc -----END PGP SIGNATURE----- --0lQD6nQFU9C6sjiy-- --===============6875293981972139222== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6875293981972139222==--