From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 97DED475F5 for ; Fri, 12 Jan 2024 22:41:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B953F68CDF3; Sat, 13 Jan 2024 00:41:56 +0200 (EET) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DDD7A68C99B for ; Sat, 13 Jan 2024 00:41:49 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id E148F1C0003 for ; Fri, 12 Jan 2024 22:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1705099309; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2I5HgFIbmoDLLz3OucTxyZVBZRjL1ttQTiAlrRevrVU=; b=pBV3G9N4kxmPpI9Avxo5eaenFNlNULIdA9cEXbYUVZQ7nHocE7A0ps1V9R7dR62xghMmr2 mrmR4kDaot0Q20QlFcLGtV45H/NxCg6YuJaCqUARspSiD60SSOWZWsmU/8vaO1oRBE23km 5udgAwsCZFVxhyNCS4mVeKd2DyO0GnykioXqoEVSZp2t5dqboh4JZh03K2RYZZ0cGOHPTE MMhJNjnkomncAivZCXkM72pjG4+bRURP7jKF4UvCa/B1eXteqetBJTIhtCU06JKYOR3lqV IpAz84AATG3SwPsutuEBJYMQsuQT5zB8/0e7BRb05Nvq6AxrC1wnGv6XQuwz5g== Date: Fri, 12 Jan 2024 23:41:48 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240112224148.GC6420@pb2> References: MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vsrc_testsrc: fix colorchart black stripe X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1723515091332393616==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1723515091332393616== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PBahemduq+tlkfF3" Content-Disposition: inline --PBahemduq+tlkfF3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 12, 2024 at 01:58:03PM +0200, Vladimir Petrov wrote: > There is a typo at 'libavfilter/vsrc_testsrc.c' in > 'colorchart_fill_picture()' regarding patch height when using > colorchart test image source. With current default size 64x64 all is > fine, but when move to any non-square patch size, there is unexpected > behavior: >=20 > Test examples: >=20 > [Blackstripe on bottom if height > width] > ffmpeg -f lavfi -i colorchart=3Dduration=3D30:rate=3D25:patch_size=3D120x= 144 > -f mp4 -c:v libx264 colorchart1.m4v >=20 > [Segmentation fault if height < width] > ffmpeg -f lavfi -i colorchart=3Dduration=3D30:rate=3D25:patch_size=3D120x= 100 > -f mp4 -c:v libx264 colorchart2.m4v > vsrc_testsrc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > 0a5e124445e68daed7d6481a25cc877d45696b8e 0001-avfilter-vsrc_testsrc-fix-= colorchart-black-stripe.patch > From c484a4976c54083770c8749f954394c35dfd9c63 Mon Sep 17 00:00:00 2001 > From: Vladimir Petrov > Date: Tue, 9 Jan 2024 18:42:19 +0200 > Subject: [PATCH] avfilter/vsrc_testsrc: fix colorchart black stripe >=20 > Fixed blackstripe on bottom or segmentation fault in case > when patch width and height differ. >=20 > Signed-off-by: Vladimir Petrov > --- > libavfilter/vsrc_testsrc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Take away the freedom of one citizen and you will be jailed, take away the freedom of all citizens and you will be congratulated by your peers in Parliament. --PBahemduq+tlkfF3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZaHAJAAKCRBhHseHBAsP qzdJAJ9JyvhEg6/VFa0rZOyfVqMbTGIDYgCeI0wohbL/BwQQDr1knf+XWkATZ8U= =oXmW -----END PGP SIGNATURE----- --PBahemduq+tlkfF3-- --===============1723515091332393616== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1723515091332393616==--