From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 07FE7463C2 for ; Fri, 12 Jan 2024 21:10:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E22A268AA16; Fri, 12 Jan 2024 23:10:54 +0200 (EET) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E7F1568CA86 for ; Fri, 12 Jan 2024 23:10:47 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 4B09D20002 for ; Fri, 12 Jan 2024 21:10:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1705093847; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=c8Le5kqLU3H46bPlS6LsygkYinbFOqCTjwQnXkUX33A=; b=jpR/yA/4WzjWR83nb61Z6kgV9j3PpJcEoQC9gWkMt0DdKajmhV3h6Zjd2tUcNwXsZhGpJb 9YJSzsDeP6wOX35DdMS06ZTm87CEORSTmoNFAkknpS9O69Ry5OdBaFpwL+AXlUuIzmukyO r56OC3oCFf5+qMyuGMOThuMZEs2XzpubLAj+jA+KLwrJF+txCssDRdzylu0J5enbN7OG7r THT4pdaXZ3yJ3yRq+ph5ecyVmZDAE4QyNv03Mm+eqj8gQDXSqyQNECrkxkqZ5YfPzg8CBP cpq6T6n/upcL2GhFhuEUfMvi3+cr1WR0w+bWkBUwarDnnCC+t2QWTrnDZyy/MQ== Date: Fri, 12 Jan 2024 22:10:46 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240112211046.GB6420@pb2> References: <20240112082950.41637-1-ffmpeg@haasn.xyz> <20240112082950.41637-7-ffmpeg@haasn.xyz> MIME-Version: 1.0 In-Reply-To: <20240112082950.41637-7-ffmpeg@haasn.xyz> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 06/11] fftools/ffmpeg_filter: simplify choose_pix_fmts X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5118050672815356929==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5118050672815356929== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7P56bi/sLaUnWouk" Content-Disposition: inline --7P56bi/sLaUnWouk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 12, 2024 at 09:26:03AM +0100, Niklas Haas wrote: > From: Niklas Haas >=20 > The only meaningful difference between choose_pix_fmts and the default > code was the inclusion of an extra branch for `keep_pix_fmt` being true. >=20 > However, in this case, we either: > 1. Force the specific `ofp->format` that we inherited from > ofilter_bind_ost, or if no format was set: > 2. Print an empty format list >=20 > Both of these goals can be accomplished by simply moving the decision > logic to ofilter_bind_ost, to avoid setting any format list when > keep_pix_fmt is enabled. This is arguably cleaner as it moves format > selection logic to a single function. In the case of branch 1, nothing > else needs to be done as we already force the format provided in > ofp->format, if any is set. Add an assertion to verify this assumption > just in case. >=20 > (Side note: The "choose_*" family of functions are arguably misnomers, > as they should really be called "print_*" - their current behavior is to > print the relevant format lists to the `vf/af_format` filter arguments) > --- > fftools/ffmpeg_filter.c | 49 ++++++++--------------------------------- > 1 file changed, 9 insertions(+), 40 deletions(-) =2E/ffmpeg -y -i fate-suite/lena.pnm -pix_fmt +yuv444p -vf scale -strict -1= -bitexact -threads 2 -thread_type slice file-2s-444.jpg Assertion !ost->keep_pix_fmt || (!ofp->format && !ofp->formats) failed at f= ftools/ffmpeg_filter.c:1240 Aborted (core dumped) [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have never wished to cater to the crowd; for what I know they do not approve, and what they approve I do not know. -- Epicurus --7P56bi/sLaUnWouk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZaGqzgAKCRBhHseHBAsP q3MHAJ4gfI47r2sOzp/kXpO2VPSwqoFeaACfVaYyX6zeg81/JI99xiLjtR6ODa0= =Fg0W -----END PGP SIGNATURE----- --7P56bi/sLaUnWouk-- --===============5118050672815356929== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5118050672815356929==--