From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F307740ECB for ; Fri, 12 Jan 2024 19:07:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 43D5D68CCC9; Fri, 12 Jan 2024 21:07:19 +0200 (EET) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6684568AB9C for ; Fri, 12 Jan 2024 21:07:12 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 0A2C9FF803 for ; Fri, 12 Jan 2024 19:07:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1705086431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Gs4LMNr6FQC8EC2wGYaoyeyqkH4jazF30WSmcQ6A1z4=; b=QTUh8jzBmuigY+XhFEwrLLHv+bMswTspVIIOwMwZsimLQowIKYHx+Y/BQIeq6gxvu1msSd DUDbhp2aPHXY1rqM8FOSfVWMMyxkYwAJqx7C85NMFt5q5cpoxC35QZMhO8RdLXpYXoYxB1 ei6t/3zZUwSvEipq8tBAMQwAENJpiAY0NFsqYr/kzyzg1T79eeM/XdXNKYDj3JWwafHIAO y/lFrcd7btcAmthzFum6o5Da4c+G7goYjMqCGagALwG/oelT2Oe2Qz/1uKMclPFMH2wsoQ imVyqHTCmxbe1cd2crcPYcc+3AzDr1K2Vtk+0gkuw3J1SODfU67KQG7Y+W/AZA== Date: Fri, 12 Jan 2024 20:07:10 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240112190710.GZ6420@pb2> References: <20231228193329.GV6420@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avformat/rtsp: Fix server compatibility issues with rtspclientsink GStreamer plugin X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7468409427681866722==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7468409427681866722== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/f6zQSFn2S4aOoS1" Content-Disposition: inline --/f6zQSFn2S4aOoS1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 03, 2024 at 02:51:36PM +0200, Paul Orlyk wrote: > On 12/28/23 21:33, Michael Niedermayer wrote: > > On Wed, Dec 27, 2023 at 03:44:09PM +0200, Paul Orlyk wrote: > > > mode field in Transport header can be sent in upper case so make stri= ng > > > comparison case insensitive. > > > Also, GStreamer expects to see mode=3Drecord instead of mode=3Dreceiv= e in > > > Transport header in response. > > >=20 > > > Signed-off-by: Paul Orlyk > > > --- > > > libavformat/rtsp.c | 4 ++-- > > > libavformat/rtspdec.c | 4 ++-- > > > 2 files changed, 4 insertions(+), 4 deletions(-) > > >=20 > > > diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c > > > index 583f5338e8..61e24a5c7a 100644 > > > --- a/libavformat/rtsp.c > > > +++ b/libavformat/rtsp.c > > > @@ -1012,8 +1012,8 @@ static void rtsp_parse_transport(AVFormatContex= t *s, > > > if (*p =3D=3D '=3D') { > > > p++; > > > get_word_sep(buf, sizeof(buf), ";, ", &p); > > > - if (!strcmp(buf, "record") || > > > - !strcmp(buf, "receive")) > > > + if (!av_strcasecmp(buf, "record") || > > > + !av_strcasecmp(buf, "receive")) > > > th->mode_record =3D 1; > > > } > > > } > > > diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c > > > index 39fd92fb66..d6a223cbc6 100644 > > > --- a/libavformat/rtspdec.c > > > +++ b/libavformat/rtspdec.c > > > @@ -303,7 +303,7 @@ static int rtsp_read_setup(AVFormatContext*s, cha= r* > > > host, char *controlurl) > > > rtsp_st->interleaved_min =3D request.transports[0].interlea= ved_min; > > patch is damaged by linebreaks > >=20 > >=20 > > [...] >=20 >=20 > Sorry for that. Please find it attached. > rtsp.c | 4 ++-- > rtspdec.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > 8ed5709b8c5cb30aeaa18d609b86b9be0557a06e 0001-avformat-rtsp-Fix-server-c= ompatibility-issues-with-r.patch > From 156ceeded6cd076b781205adc034144186a9a7ea Mon Sep 17 00:00:00 2001 > From: Paul Orlyk > Date: Wed, 27 Dec 2023 15:30:20 +0200 > Subject: [PATCH] avformat/rtsp: Fix server compatibility issues with > rtspclientsink GStreamer plugin >=20 > mode field in Transport header can be sent in upper case so make string c= omparison case insensitive. > Also, GStreamer expects to see mode=3Drecord instead of mode=3Dreceive in= Transport header in response. It appears to me that these are 2 seperate issues ? if its 2 patches, i can apply the av_strcasecmp(). For the receive vs record i would prefer to see some quote from a RFC inste= ad of just an implementation thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you fake or manipulate statistics in a paper in physics you will never get a job again. If you fake or manipulate statistics in a paper in medicin you will get a job for life at the pharma industry. --/f6zQSFn2S4aOoS1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZaGN0gAKCRBhHseHBAsP q3pVAJ9pRbT+OJZck525FRJ5V5TYWCU9ugCeLTHsPtiZaKpa7+xqRskdkOnc7BA= =y5iG -----END PGP SIGNATURE----- --/f6zQSFn2S4aOoS1-- --===============7468409427681866722== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7468409427681866722==--