From: Niklas Haas <ffmpeg@haasn.xyz>
To: ffmpeg-devel@ffmpeg.org
Cc: Niklas Haas <git@haasn.dev>
Subject: [FFmpeg-devel] [PATCH 02/11] avfilter/buffersrc: allow promoting color range to MPEG
Date: Fri, 12 Jan 2024 09:25:59 +0100
Message-ID: <20240112082950.41637-3-ffmpeg@haasn.xyz> (raw)
In-Reply-To: <20240112082950.41637-1-ffmpeg@haasn.xyz>
From: Niklas Haas <git@haasn.dev>
Otherwise, passing an UNSPECIFIED frame to am MPEG-only filter graph
would trigger insertion of an unnecessary vf_scale filter, which would
perform a memcpy to convert between the two.
This is safe to do because unspecified YUV frames are already
universally assumed to be MPEG range, in particular by swscale.
---
libavfilter/buffersrc.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c
index e10653c866..ee0c89ef05 100644
--- a/libavfilter/buffersrc.c
+++ b/libavfilter/buffersrc.c
@@ -492,8 +492,14 @@ static int query_formats(AVFilterContext *ctx)
if ((ret = ff_add_format(&color_spaces, c->color_space)) < 0 ||
(ret = ff_set_common_color_spaces(ctx, color_spaces)) < 0)
return ret;
- if ((ret = ff_add_format(&color_ranges, c->color_range)) < 0 ||
- (ret = ff_set_common_color_ranges(ctx, color_ranges)) < 0)
+ if ((ret = ff_add_format(&color_ranges, c->color_range)) < 0)
+ return ret;
+ if (c->color_range == AVCOL_RANGE_UNSPECIFIED) {
+ /* allow implicitly promoting unspecified to mpeg */
+ if ((ret = ff_add_format(&color_ranges, AVCOL_RANGE_MPEG)) < 0)
+ return ret;
+ }
+ if ((ret = ff_set_common_color_ranges(ctx, color_ranges)) < 0)
return ret;
}
break;
--
2.43.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-01-12 8:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 8:25 [FFmpeg-devel] [PATCH 00/11] YUVJ removal Niklas Haas
2024-01-12 8:25 ` [FFmpeg-devel] [PATCH 01/11] avfilter/buffersrc: promote unspecified color metadata Niklas Haas
2024-01-12 8:25 ` Niklas Haas [this message]
2024-01-12 8:26 ` [FFmpeg-devel] [PATCH 03/11] avfilter/vf_tiltandshift: check outlink->color_range Niklas Haas
2024-01-12 8:26 ` [FFmpeg-devel] [PATCH 04/11] avcodec: add YUV color space metadata to AVCodec Niklas Haas
2024-01-12 8:26 ` [FFmpeg-devel] [PATCH 05/11] avcodec: set color_ranges for all video encoders Niklas Haas
2024-01-12 8:26 ` [FFmpeg-devel] [PATCH 06/11] fftools/ffmpeg_filter: simplify choose_pix_fmts Niklas Haas
2024-01-12 21:10 ` Michael Niedermayer
2024-02-05 17:14 ` Niklas Haas
2024-01-12 8:26 ` [FFmpeg-devel] [PATCH 07/11] fftools/ffmpeg_filter: propagate codec yuv metadata to filters Niklas Haas
2024-01-12 8:26 ` [FFmpeg-devel] [PATCH 08/11] tests/fate: force MPEG range for rawvideo tests Niklas Haas
2024-01-12 8:26 ` [FFmpeg-devel] [PATCH 09/11] lavfi/lavu/lavc: remove YUVJ pixel formats Niklas Haas
2024-01-12 8:26 ` [FFmpeg-devel] [PATCH 10/11] avutil/pixdesc: remove old yuvj pixel format check Niklas Haas
2024-01-12 8:26 ` [FFmpeg-devel] [PATCH 11/11] avcodec/encode: enforce AVCodec capabilities at encode time Niklas Haas
2024-01-12 20:59 ` [FFmpeg-devel] [PATCH 00/11] YUVJ removal Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240112082950.41637-3-ffmpeg@haasn.xyz \
--to=ffmpeg@haasn.xyz \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=git@haasn.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git