From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5360F48190 for ; Thu, 11 Jan 2024 03:17:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 79C0B68CF86; Thu, 11 Jan 2024 05:17:26 +0200 (EET) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ABB4B68CD77 for ; Thu, 11 Jan 2024 05:17:19 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id B3CE3240002 for ; Thu, 11 Jan 2024 03:17:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1704943038; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vyGCIMF1Yu5JJkh+H0rRT7KVZc1bN0l+/uA+YqrJeQ4=; b=ob88Hi5EmoLG/R9Jt+avnmAeMUsg8okQMOKAZMmTKOwZqz3QyyM6OoPtGHasbfRMqRbczl 14Aou3KVaIadTK9R3G9IUd+4gKUfy+D7wwzn+bhWynWlBi8zuHzcDIDUUf2ie785TwBhMe RiXEOI43jNyUh/7SEXR53vNtUYCbneNJiVgD6YlUvllU3O6xlNqSi1rzdQd8StGdci3oB3 CNFFRmQQR3L3xxeJ5spvdObszZ/OziltcIRdAEhJEAslL5BXou0RLnPq6bcbkWzMEFyCtK mLtYJq8rxzK9peo9hS14LF0BdXB9tu7DL0I8KaZpVlgjqFXVvxdWLYiZSQ6HLg== Date: Thu, 11 Jan 2024 04:17:17 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240111031717.GW6420@pb2> References: <20240107213100.16205-1-jamrial@gmail.com> <20240107213100.16205-4-jamrial@gmail.com> <20240110030518.GS6420@pb2> <26382cca-3bb1-4b5e-96b6-ce9cdd857466@gmail.com> MIME-Version: 1.0 In-Reply-To: <26382cca-3bb1-4b5e-96b6-ce9cdd857466@gmail.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 4/4] fate: add raw IAMF tests X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1188520551733971761==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1188520551733971761== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OWfq5nj5qxV/LOV7" Content-Disposition: inline --OWfq5nj5qxV/LOV7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 10, 2024 at 09:52:28AM -0300, James Almer wrote: > On 1/10/2024 12:05 AM, Michael Niedermayer wrote: > > On Sun, Jan 07, 2024 at 06:31:00PM -0300, James Almer wrote: > > > Covers muxing from raw pcm audio input into FLAC, using several scala= ble layouts, > > > and demuxing the result. > > >=20 > > > Signed-off-by: James Almer > > > --- > > > tests/Makefile | 7 +- > > > tests/fate/iamf.mak | 31 ++++++ > > > tests/filtergraphs/iamf_5_1 | 4 + > > > tests/filtergraphs/iamf_5_1_2 | 5 + > > > tests/filtergraphs/iamf_5_1_4 | 6 ++ > > > tests/filtergraphs/iamf_7_1_4 | 7 ++ > > > tests/ref/fate/iamf-5_1_4 | 98 ++++++++++++++++++ > > > tests/ref/fate/iamf-7_1_4 | 114 ++++++++++++++++++= +++ > > > tests/ref/fate/iamf-stereo | 18 ++++ > > > tests/streamgroups/audio_element-5_1_4 | 7 ++ > > > tests/streamgroups/audio_element-7_1_4 | 6 ++ > > > tests/streamgroups/audio_element-stereo | 3 + > > > tests/streamgroups/mix_presentation-5_1_4 | 2 + > > > tests/streamgroups/mix_presentation-7_1_4 | 2 + > > > tests/streamgroups/mix_presentation-stereo | 3 + > > > 15 files changed, 312 insertions(+), 1 deletion(-) > > > create mode 100644 tests/fate/iamf.mak > > > create mode 100644 tests/filtergraphs/iamf_5_1 > > > create mode 100644 tests/filtergraphs/iamf_5_1_2 > > > create mode 100644 tests/filtergraphs/iamf_5_1_4 > > > create mode 100644 tests/filtergraphs/iamf_7_1_4 > > > create mode 100644 tests/ref/fate/iamf-5_1_4 > > > create mode 100644 tests/ref/fate/iamf-7_1_4 > > > create mode 100644 tests/ref/fate/iamf-stereo > > > create mode 100644 tests/streamgroups/audio_element-5_1_4 > > > create mode 100644 tests/streamgroups/audio_element-7_1_4 > > > create mode 100644 tests/streamgroups/audio_element-stereo > > > create mode 100644 tests/streamgroups/mix_presentation-5_1_4 > > > create mode 100644 tests/streamgroups/mix_presentation-7_1_4 > > > create mode 100644 tests/streamgroups/mix_presentation-stereo > >=20 > > Iam probably missing some dependancies but, reporting anyway > > this fails fate: > >=20 > > [aist#0:0/pcm_s16le @ 0x5645f5820680] Guessed Channel Layout: stereo > > Input #0, wav, from 'ffmpeg/tests/data/asynth-44100-2.wav': > > Duration: 00:00:06.00, bitrate: 1411 kb/s > > Stream #0:0: Audio: pcm_s16le ([1][0][0][0] / 0x0001), 44100 Hz, 2 c= hannels, s16, 1411 kb/s > > [in#0/wav @ 0x5645f5812400] Codec AVOption idct (select IDCT implementa= tion) has not been used for any stream. The most likely reason is either wr= ong type (e.g. a video option with no video streams) or that it is a privat= e option of some decoder which was not actually used for any stream. > > [out#0/iamf @ 0x5645f585af80] Codec AVOption dct (DCT algorithm) has no= t been used for any stream. The most likely reason is either wrong type (e.= g. a video option with no video streams) or that it is a private option of = some encoder which was not actually used for any stream. > > [out#0/iamf @ 0x5645f585af80] Codec AVOption idct (select IDCT implemen= tation) has not been used for any stream. The most likely reason is either = wrong type (e.g. a video option with no video streams) or that it is a priv= ate option of some encoder which was not actually used for any stream. > > [out#0/iamf @ 0x5645f585af80] Invalid or missing stream group index in = submix element specification "stg=3D0:parameter_id=3D100:headphones_renderi= ng_mode=3Dstereo:annotations=3Den-us=3DScalable_Submix" > > Error opening output file ffmpeg/tests/data/fate/iamf-stereo.iamf. > > Error opening output files: Invalid argument > > threads=3D1 > > tests/Makefile:317: recipe for target 'fate-iamf-stereo' failed > > make: *** [fate-iamf-stereo] Error 234 > >=20 > > thx >=20 > I can't reproduce this. Tried with these four patches using current master > and it works. > Could it be strtoll misbehaving? Can you check what values are in idx, > oc->nb_stream_groups, and endptr? didnt had time to look its 4am i need to eat and go to bed :) but a quick test with this: diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index 1b42ac9a1d7..224e9e8268e 100644 --- a/fftools/ffmpeg_mux_init.c +++ b/fftools/ffmpeg_mux_init.c @@ -2113,8 +2113,10 @@ static int of_parse_iamf_submixes(Muxer *mux, AVStre= amGroup *stg, char *ptr) char *endptr =3D NULL; int64_t idx =3D -1; - if (e =3D av_dict_get(dict, "stg", NULL, 0)) + if (e =3D av_dict_get(dict, "stg", NULL, 0)) { idx =3D strtoll(e->value, &endptr, 0); + av_log(0,0, "B idx:%"PRId64" NSG:%d endptr: %p endptr:= %s value:%s\n", idx, oc->nb_stream_groups, endptr, endptr, e->value); + } av_dict_set(&dict, "stg", NULL, 0); if (!endptr || *endptr || idx < 0 || idx >=3D oc->nb_strea= m_groups - 1 || oc->stream_groups[idx]->type !=3D AV_STREAM_GROUP_PARA= MS_IAMF_AUDIO_ELEMENT) { @@ -2245,6 +2247,7 @@ static int of_parse_group_token(Muxer *mux, const cha= r *token, char *ptr) while (e =3D av_dict_get(dict, "stg", e, 0)) { char *endptr; int64_t idx =3D strtoll(e->value, &endptr, 0); + av_log(0,0, "idx:%"PRId64" NSG:%d endptr:%s\n", idx, oc->nb_stream= _groups, endptr); if (*endptr || idx < 0 || idx >=3D oc->nb_stream_groups - 1) { av_log(mux, AV_LOG_ERROR, "Invalid stream group index %"PRId64= "\n", idx); ret =3D AVERROR(EINVAL); i get: [aist#0:0/pcm_s16le @ 0x55ae216e6680] Guessed Channel Layout: stereo Input #0, wav, from 'ffmpeg/tests/data/asynth-44100-2.wav': Duration: 00:00:06.00, bitrate: 1411 kb/s Stream #0:0: Audio: pcm_s16le ([1][0][0][0] / 0x0001), 44100 Hz, 2 channe= ls, s16, 1411 kb/s [in#0/wav @ 0x55ae216d8400] Codec AVOption idct (select IDCT implementation= ) has not been used for any stream. The most likely reason is either wrong = type (e.g. a video option with no video streams) or that it is a private op= tion of some decoder which was not actually used for any stream. [out#0/iamf @ 0x55ae21720f80] Codec AVOption dct (DCT algorithm) has not be= en used for any stream. The most likely reason is either wrong type (e.g. a= video option with no video streams) or that it is a private option of some= encoder which was not actually used for any stream. [out#0/iamf @ 0x55ae21720f80] Codec AVOption idct (select IDCT implementati= on) has not been used for any stream. The most likely reason is either wron= g type (e.g. a video option with no video streams) or that it is a private = option of some encoder which was not actually used for any stream. idx:0 NSG:2 endptr: B idx:0 NSG:2 endptr: 0x55ae21728b81 endptr: value:0 [out#0/iamf @ 0x55ae21720f80] Invalid or missing stream group index in subm= ix element specification "stg=3D0:parameter_id=3D100:headphones_rendering_m= ode=3Dstereo:annotations=3Den-us=3DScalable_Submix" Error opening output file ffmpeg/tests/data/fate/iamf-stereo.iamf. Error opening output files: Invalid argument threads=3D1 tests/Makefile:317: recipe for target 'fate-iamf-stereo' failed make: *** [fate-iamf-stereo] Error 234 i also see other failures: make: *** [fate-iamf-stereo] Error 234 make: *** [fate-iamf-5_1_4] Error 234 make: *** [fate-iamf-7_1_4] Error 234 thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB He who knows, does not speak. He who speaks, does not know. -- Lao Tsu --OWfq5nj5qxV/LOV7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZZ9dtgAKCRBhHseHBAsP q0EpAJ9a8Shz6BkLMfE2+wfy+DS3SCZBjACdH8cvuAAUqsd5VoARrGPGlzz+lmE= =7VbA -----END PGP SIGNATURE----- --OWfq5nj5qxV/LOV7-- --===============1188520551733971761== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1188520551733971761==--