From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 281194813B for ; Wed, 10 Jan 2024 13:15:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6849E68CE07; Wed, 10 Jan 2024 15:15:47 +0200 (EET) Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0437668CC25 for ; Wed, 10 Jan 2024 15:15:40 +0200 (EET) Received: from haasn.dev (unknown [10.30.0.2]) by haasn.dev (Postfix) with ESMTP id B861A414B5 for ; Wed, 10 Jan 2024 14:15:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail; t=1704892540; bh=wSAlAMTNoRx5WhIB0fwIJyLWLJwZ9b6fbfvW7eIanvk=; h=Date:From:To:Subject:In-Reply-To:References:From; b=tLzvW3fl7h28UTXR84LzOE+GTfFSW4Nl+c+oZ47DXF5WKSnA3/TknBFUnKfe9tvBY A317cmfyWHiw5S1EYTY0Vb56s4J1veegREvWxflgwAOFbP377vjYN4w1f5A8cPdm4R CjUX2lo7KfWc6gmdcg6S0RII14J5sgTHdMPlNKcE= Date: Wed, 10 Jan 2024 14:15:40 +0100 Message-ID: <20240110141540.GB92986@haasn.xyz> From: Niklas Haas To: FFmpeg development discussions and patches In-Reply-To: References: <20231113153234.8812-1-ffmpeg@haasn.xyz> MIME-Version: 1.0 Content-Disposition: inline Subject: Re: [FFmpeg-devel] [PATCH 1/3] swscale: don't assign range converters for float X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 27 Nov 2023 02:10:11 +0000 "Chen, Wenbin" wrote: > > > From: Niklas Haas > > > > > > This logic was incongruent with logic used elsewhere, where floating > > > point formats are explicitly exempted from range conversion. Fixes an > > > issue where floating point formats were not going through special > > > unscaled converters even when it was otherwise possible. > > > --- > > > libswscale/swscale.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/libswscale/swscale.c b/libswscale/swscale.c > > > index 46ba68fe6a..a66db22767 100644 > > > --- a/libswscale/swscale.c > > > +++ b/libswscale/swscale.c > > > @@ -534,7 +534,8 @@ av_cold void ff_sws_init_range_convert(SwsContext > > > *c) > > > { > > > c->lumConvertRange = NULL; > > > c->chrConvertRange = NULL; > > > - if (c->srcRange != c->dstRange && !isAnyRGB(c->dstFormat)) { > > > + if (c->srcRange != c->dstRange && !isAnyRGB(c->dstFormat) && > > > + !isFloat(c->srcFormat) && !isFloat(c->dstFormat)) { > > > if (c->dstBpc <= 14) { > > > if (c->srcRange) { > > > c->lumConvertRange = lumRangeFromJpeg_c; > > > -- > > > 2.42.0 > > > > > > > This patchset works for me. Thanks for your quick fixing. > > Ping. When can this patchset be merged? Hi, do you still need this patch, now that YUV negotiation means vf_scale no longer changes the filter range dynamically? > > Thanks > Wenbin > > > > > _______________________________________________ > > > ffmpeg-devel mailing list > > > ffmpeg-devel@ffmpeg.org > > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > > > To unsubscribe, visit link above, or email > > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".