From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id DA71E48C06
	for <ffmpegdev@gitmailbox.com>; Wed, 10 Jan 2024 09:48:41 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 184E768CCE9;
	Wed, 10 Jan 2024 11:48:38 +0200 (EET)
Received: from haasn.dev (haasn.dev [78.46.187.166])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C481068C2DC
 for <ffmpeg-devel@ffmpeg.org>; Wed, 10 Jan 2024 11:48:30 +0200 (EET)
Received: from haasn.dev (unknown [10.30.0.2])
 by haasn.dev (Postfix) with ESMTP id 761FE414B5;
 Wed, 10 Jan 2024 10:48:30 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail;
 t=1704880110; bh=u0reX5H8d34MTpYerzFcJwfEtc+6R3+7tzsxKF6XpsY=;
 h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
 b=n/St1JpCVfUKiORipHQNK3Bgp5uZrhSjjSNfL4077ANupeBauXxmUR4aHMgD5RT23
 o92DhKtbT36x719amySNNXCEd3V1VjE6MiLU11TY3zpYx8Kw92ZDe94WFhCM3Zf3yG
 bqw936RJAd4s+oSA0HVO9Q/HixZnY7+OF/+s+ICE=
Date: Wed, 10 Jan 2024 10:48:30 +0100
Message-ID: <20240110104830.GB76112@haasn.xyz>
From: Niklas Haas <ffmpeg@haasn.xyz>
To: ffmpeg-devel@ffmpeg.org
In-Reply-To: <tencent_069E53099C71CB9C260F508426E427FBEA06@qq.com>
References: <tencent_069E53099C71CB9C260F508426E427FBEA06@qq.com>
MIME-Version: 1.0
Content-Disposition: inline
Subject: Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffplay: fix missing
 hw_frames_ctx when config avfilter
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Zhao Zhili <zhilizhao@tencent.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20240110104830.GB76112@haasn.xyz/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Tue, 09 Jan 2024 23:41:00 +0800 Zhao Zhili <quinkblack@foxmail.com> wrote:
> From: Zhao Zhili <zhilizhao@tencent.com>
> 
> ---
>  fftools/ffplay.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/fftools/ffplay.c b/fftools/ffplay.c
> index 17861e60be..3c378bca2c 100644
> --- a/fftools/ffplay.c
> +++ b/fftools/ffplay.c
> @@ -1858,6 +1858,10 @@ static int configure_video_filters(AVFilterGraph *graph, VideoState *is, const c
>      const AVDictionaryEntry *e = NULL;
>      int nb_pix_fmts = 0;
>      int i, j;
> +    AVBufferSrcParameters *par = av_buffersrc_parameters_alloc();
> +
> +    if (!par)
> +        return AVERROR(ENOMEM);
>  
>      for (i = 0; i < renderer_info.num_texture_formats; i++) {
>          for (j = 0; j < FF_ARRAY_ELEMS(sdl_texture_format_map) - 1; j++) {
> @@ -1893,6 +1897,10 @@ static int configure_video_filters(AVFilterGraph *graph, VideoState *is, const c
>                                              "ffplay_buffer", buffersrc_args, NULL,
>                                              graph)) < 0)
>          goto fail;
> +    par->hw_frames_ctx = frame->hw_frames_ctx;
> +    ret = av_buffersrc_parameters_set(filt_src, par);
> +    if (ret < 0)
> +        goto fail;
>  
>      ret = avfilter_graph_create_filter(&filt_out,
>                                         avfilter_get_by_name("buffersink"),
> @@ -1959,6 +1967,7 @@ static int configure_video_filters(AVFilterGraph *graph, VideoState *is, const c
>      is->out_video_filter = filt_out;
>  
>  fail:
> +    av_freep(&par);
>      return ret;
>  }
>  
> -- 
> 2.25.1

LGTM.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".