Re: [FFmpeg-devel] [PATCH 4/4] fate: add raw IAMF tests

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 3830 bytes --]

On Sun, Jan 07, 2024 at 06:31:00PM -0300, James Almer wrote:
> Covers muxing from raw pcm audio input into FLAC, using several scalable layouts,
> and demuxing the result.
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  tests/Makefile                             |   7 +-
>  tests/fate/iamf.mak                        |  31 ++++++
>  tests/filtergraphs/iamf_5_1                |   4 +
>  tests/filtergraphs/iamf_5_1_2              |   5 +
>  tests/filtergraphs/iamf_5_1_4              |   6 ++
>  tests/filtergraphs/iamf_7_1_4              |   7 ++
>  tests/ref/fate/iamf-5_1_4                  |  98 ++++++++++++++++++
>  tests/ref/fate/iamf-7_1_4                  | 114 +++++++++++++++++++++
>  tests/ref/fate/iamf-stereo                 |  18 ++++
>  tests/streamgroups/audio_element-5_1_4     |   7 ++
>  tests/streamgroups/audio_element-7_1_4     |   6 ++
>  tests/streamgroups/audio_element-stereo    |   3 +
>  tests/streamgroups/mix_presentation-5_1_4  |   2 +
>  tests/streamgroups/mix_presentation-7_1_4  |   2 +
>  tests/streamgroups/mix_presentation-stereo |   3 +
>  15 files changed, 312 insertions(+), 1 deletion(-)
>  create mode 100644 tests/fate/iamf.mak
>  create mode 100644 tests/filtergraphs/iamf_5_1
>  create mode 100644 tests/filtergraphs/iamf_5_1_2
>  create mode 100644 tests/filtergraphs/iamf_5_1_4
>  create mode 100644 tests/filtergraphs/iamf_7_1_4
>  create mode 100644 tests/ref/fate/iamf-5_1_4
>  create mode 100644 tests/ref/fate/iamf-7_1_4
>  create mode 100644 tests/ref/fate/iamf-stereo
>  create mode 100644 tests/streamgroups/audio_element-5_1_4
>  create mode 100644 tests/streamgroups/audio_element-7_1_4
>  create mode 100644 tests/streamgroups/audio_element-stereo
>  create mode 100644 tests/streamgroups/mix_presentation-5_1_4
>  create mode 100644 tests/streamgroups/mix_presentation-7_1_4
>  create mode 100644 tests/streamgroups/mix_presentation-stereo

Iam probably missing some dependancies but, reporting anyway
this fails fate:

[aist#0:0/pcm_s16le @ 0x5645f5820680] Guessed Channel Layout: stereo
Input #0, wav, from 'ffmpeg/tests/data/asynth-44100-2.wav':
  Duration: 00:00:06.00, bitrate: 1411 kb/s
  Stream #0:0: Audio: pcm_s16le ([1][0][0][0] / 0x0001), 44100 Hz, 2 channels, s16, 1411 kb/s
[in#0/wav @ 0x5645f5812400] Codec AVOption idct (select IDCT implementation) has not been used for any stream. The most likely reason is either wrong type (e.g. a video option with no video streams) or that it is a private option of some decoder which was not actually used for any stream.
[out#0/iamf @ 0x5645f585af80] Codec AVOption dct (DCT algorithm) has not been used for any stream. The most likely reason is either wrong type (e.g. a video option with no video streams) or that it is a private option of some encoder which was not actually used for any stream.
[out#0/iamf @ 0x5645f585af80] Codec AVOption idct (select IDCT implementation) has not been used for any stream. The most likely reason is either wrong type (e.g. a video option with no video streams) or that it is a private option of some encoder which was not actually used for any stream.
[out#0/iamf @ 0x5645f585af80] Invalid or missing stream group index in submix element specification "stg=0:parameter_id=100:headphones_rendering_mode=stereo:annotations=en-us=Scalable_Submix"
Error opening output file ffmpeg/tests/data/fate/iamf-stereo.iamf.
Error opening output files: Invalid argument
threads=1
tests/Makefile:317: recipe for target 'fate-iamf-stereo' failed
make: *** [fate-iamf-stereo] Error 234

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".