[FFmpeg-devel] [PATCH] avcodec/vvc_thread: don't use an anonymous union

[FFmpeg-devel] [PATCH] avcodec/vvc_thread: don't use an anonymous union

[James Almer]

Should fix compilation with old GCC.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavcodec/vvc/vvc_thread.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavcodec/vvc/vvc_thread.c b/libavcodec/vvc/vvc_thread.c
index db901585a4..31c931f050 100644
--- a/libavcodec/vvc/vvc_thread.c
+++ b/libavcodec/vvc/vvc_thread.c
@@ -54,7 +54,7 @@ typedef struct VVCTask {
     union {
         struct VVCTask *next;                //for executor debug only
         AVTask task;
-    };
+    } u;
 
     VVCTaskStage stage;
 
@@ -107,7 +107,7 @@ static void add_task(VVCContext *s, VVCTask *t)
 
     atomic_fetch_add(&ft->nb_scheduled_tasks, 1);
 
-    av_executor_execute(s->executor, &t->task);
+    av_executor_execute(s->executor, &t->u.task);
 }
 
 static void task_init(VVCTask *t, VVCTaskStage stage, VVCFrameContext *fc, const int rx, const int ry)
-- 
2.43.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/vvc_thread: don't use an anonymous union

[Nuo Mi]

On Sun, Jan 7, 2024 at 3:38 AM James Almer <jamrial@gmail.com> wrote:

> Should fix compilation with old GCC.
>
> Signed-off-by: James Almer <jamrial@gmail.com>
>
LGTM

> ---
>  libavcodec/vvc/vvc_thread.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/vvc/vvc_thread.c b/libavcodec/vvc/vvc_thread.c
> index db901585a4..31c931f050 100644
> --- a/libavcodec/vvc/vvc_thread.c
> +++ b/libavcodec/vvc/vvc_thread.c
> @@ -54,7 +54,7 @@ typedef struct VVCTask {
>      union {
>          struct VVCTask *next;                //for executor debug only
>          AVTask task;
> -    };
> +    } u;
>
>      VVCTaskStage stage;
>
> @@ -107,7 +107,7 @@ static void add_task(VVCContext *s, VVCTask *t)
>
>      atomic_fetch_add(&ft->nb_scheduled_tasks, 1);
>
> -    av_executor_execute(s->executor, &t->task);
> +    av_executor_execute(s->executor, &t->u.task);
>  }
>
>  static void task_init(VVCTask *t, VVCTaskStage stage, VVCFrameContext
> *fc, const int rx, const int ry)
> --
> 2.43.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".