From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 29ADD47F3B for ; Fri, 5 Jan 2024 21:35:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 09EDF68CDE1; Fri, 5 Jan 2024 23:35:40 +0200 (EET) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9D63B68CCC8 for ; Fri, 5 Jan 2024 23:35:33 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id C9B98240002 for ; Fri, 5 Jan 2024 21:35:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1704490533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7TT90y54kSUEpzBnR6EiIrZQrH3nHJBVbl9UEuegj28=; b=V0e3JutcB8QxnczLjdcyaRJm5fOFfhkl5vjXOIUkomm2YmE6F8fOdpkt/gFN0STiECs9wO ZMRm2qJLzBcySgI/LG9jyLB3B4nczz1hYp9QrA6J7hDk1xTp+MgFKdFiwvtKQS2dCW/PBL g7l6YloLvDUN6RKF26NqAkMjnTS0mqdojzH8l6W/JdLC5lsoyxtQ/OM3JISASz2EXqzSAc bnM1bogxH2do5ysrd2VZF8dENgNcmitCdOZB9beo0pVplC9aQ8IVC48TZI52odSOvcozrG tZ+cir2HplyagvI+oyIKdNgPl4zALGP9msjJ4sQGouMd0EfPbK5vzI5us2HtUw== Date: Fri, 5 Jan 2024 22:35:31 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240105213531.GG6420@pb2> References: <74f9b1f3-698d-7a3d-1a5-1b43f88ea9f2@softwolves.pp.se> MIME-Version: 1.0 In-Reply-To: <74f9b1f3-698d-7a3d-1a5-1b43f88ea9f2@softwolves.pp.se> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] configure: Remove dcbzl check for e500v1 and e500v2 architectures X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7131720672386134959==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7131720672386134959== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eC/ZNrsTjQGziECw" Content-Disposition: inline --eC/ZNrsTjQGziECw Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 26, 2022 at 11:51:44AM +0100, Peter Krefting wrote: > The DCBZL instruction is not available for the e500v1 and e500v2 > architectures, but may still be recognized by the toolchain, so we need to > remove the test for it explicitly for these architectures. >=20 > References: PowerPC=E2=84=A2 e500 Core Family Reference Manual (Freescale) >=20 > Found-by: St=C3=A5le Kristoffersen > Compare: Commit d5733936d857ce5c7d28c0bc9e89a2e2548f8895 > --- > configure | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > This was originally fixed by commit d5733936d857ce5c7d28c0bc9e89a2e2548f8= 895 > in version 2.2, but later broke in a merge which introduced a "disable dc= bzl", > forgot to check for it in the ppc branch. >=20 > diff --git a/configure b/configure > index 7a62f0c248..5d01833f40 100755 > --- a/configure > +++ b/configure > @@ -6058,7 +6058,9 @@ elif enabled ppc; then >=20 > enable local_aligned >=20 > - check_inline_asm dcbzl '"dcbzl 0, %0" :: "r"(0)' > + if enabled dcbzl; then > + check_inline_asm dcbzl '"dcbzl 0, %0" :: "r"(0)' > + fi something like this disabled dcbzl || check_inline_asm dcbzl '"dcbzl 0, %0" :: "r"(0)' seems more clear what this is supposed to do is to disable the instruction when it was explicitly disabled for the target CPU thx {...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Awnsering whenever a program halts or runs forever is On a turing machine, in general impossible (turings halting problem). On any real computer, always possible as a real computer has a finite number of states N, and will either halt in less than N cycles or never halt. --eC/ZNrsTjQGziECw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZZh2IAAKCRBhHseHBAsP q3t2AJ9rQiBccvhAmWCflkrAIczQc+fz0ACfUwO5AD6bUR/N0ZoZew9RTGAYC5E= =7RV3 -----END PGP SIGNATURE----- --eC/ZNrsTjQGziECw-- --===============7131720672386134959== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7131720672386134959==--