Re: [FFmpeg-devel] [PATCH] avfilter/vf_pad: respect frame colorspace tag in RGB to YUV conversion

From: Leo Izen <leo.izen@gmail.com>
To: FFmpeg Development <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_pad: respect frame colorspace tag in RGB to YUV conversion
Date: Mon, 4 Sep 2023 07:21:45 -0400
Message-ID: <202395a7-8372-4ff6-9488-d7579c2c060e@gmail.com> (raw)
In-Reply-To: <20230827195115.105591-1-leo.izen@gmail.com>

On 8/27/23 15:51, Leo Izen wrote:
> vf_pad calls ff_draw_init, which assumes BT.709 and TV range for its
> YUV matricies. Since the filter only accepts RGB inputs for the color
> argument, it needs to convert them to YUV for YUV input video, and it
> should respect the tagged colormatrix when doing such a conversion, but
> it does not. It can do this by calling ff_draw_init2, and this patch
> causes the filter to re-init when the first frame is received, as that
> is when that colormatrix tag becomes available.
> 
> If the filter is not initialized before the first frame, then an
> assertion will fail in avfilter.c when it does sanity checks on
> input/output dimensions, so the original initialization cannot be
> skipped.
> 
> Signed-off-by: Leo Izen <leo.izen@gmail.com>
> ---
>   libavfilter/vf_pad.c | 21 ++++++++++++++++-----
>   1 file changed, 16 insertions(+), 5 deletions(-)
> 

Bumping, thanks.

- Leo Izen (Traneptora)

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".