Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/6] lavc/codec2utils: Use actual libcodec2 version
Date: Fri, 29 Dec 2023 00:30:40 +0100
Message-ID: <20231228233040.GB6420@pb2> (raw)
In-Reply-To: <5b7a1751e643ed9032ca380bd1a4d882592c8c09.camel@haerdin.se>


[-- Attachment #1.1: Type: text/plain, Size: 2054 bytes --]

On Thu, Dec 28, 2023 at 10:21:23PM +0100, Tomas Härdin wrote:
> tor 2023-12-28 klockan 21:29 +0100 skrev Michael Niedermayer:
> > On Thu, Dec 28, 2023 at 07:43:09PM +0100, Tomas Härdin wrote:
> > > libcodec2 has reached 1.X so it's about time the bindings receive
> > > some
> > > attention. This patchset also includes some much-needed tests.
> > > Where do
> > > I submit files for inclusion in FATE again? They are very small as
> > > is
> > > to be expected from a codec that runs at 700-3200 bit/s
> > > 
> > > /Tomas
> > 
> > >  codec2utils.h |    6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > a79a98f8ffc27ca6d79c9d373957fa0bdc985ef2  0001-lavc-codec2utils-
> > > Use-actual-libcodec2-version.patch
> > > From 7205e741aaadc354b403010c97f9cd803eec612d Mon Sep 17 00:00:00
> > > 2001
> > > From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= <git@haerdin.se>
> > > Date: Wed, 27 Dec 2023 17:32:21 +0100
> > > Subject: [PATCH 1/6] lavc/codec2utils: Use actual libcodec2 version
> > 
> > This breaks build here
> > 
> > CC      libavformat/codec2.o
> > In file included from libavformat/codec2.c:24:0:
> > ./libavcodec/codec2utils.h:26:10: fatal error: codec2/version.h: No
> > such file or directory
> >  #include <codec2/version.h>
> >           ^~~~~~~~~~~~~~~~~~
> 
> What version of libcodec2 are you using? I don't think we can rely on
> versions that don't expose version information, which only comes about
> because I explicitly told them to please expose it in a header. I don't
> think we can even probe version at configure time otherwise.
> 
> libcodec2-dev on Debian bookworm works for me

i think theres no libcodec2* on the box and this header is used outside
checks for libcodec2* ...

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-12-28 23:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-28 18:43 Tomas Härdin
2023-12-28 18:43 ` [FFmpeg-devel] [PATCH 2/6] lavf/codec2: Compute duration from filesize Tomas Härdin
2023-12-28 18:44 ` [FFmpeg-devel] [PATCH 3/6] lavf/codec2: Allow versions between 0.8 and 1.X Tomas Härdin
2023-12-28 18:44 ` [FFmpeg-devel] [PATCH 4/6] lavf/codec2: Multiple of block_align -> not corrupt Tomas Härdin
2023-12-28 18:45 ` [FFmpeg-devel] [PATCH 5/6] lavf/codec2: Silence warnings when either muxer/demuxer is disabled Tomas Härdin
2023-12-28 18:48 ` [FFmpeg-devel] [PATCH 6/6] Add FATE tests for codec2, codec2raw and libcodec2 wrapper Tomas Härdin
2023-12-29 10:40   ` Andreas Rheinhardt
2023-12-29 12:40     ` Tomas Härdin
2023-12-30 16:02     ` Tomas Härdin
2023-12-30 16:55       ` Tomas Härdin
2023-12-28 20:29 ` [FFmpeg-devel] [PATCH 1/6] lavc/codec2utils: Use actual libcodec2 version Michael Niedermayer
2023-12-28 21:21   ` Tomas Härdin
2023-12-28 23:30     ` Michael Niedermayer [this message]
2023-12-29 12:43       ` Tomas Härdin
2023-12-30 16:00       ` Tomas Härdin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231228233040.GB6420@pb2 \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git