From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9566D46966 for ; Thu, 28 Dec 2023 19:49:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 56D3968CC70; Thu, 28 Dec 2023 21:49:07 +0200 (EET) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9996468C416 for ; Thu, 28 Dec 2023 21:49:01 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id B99CFFF803 for ; Thu, 28 Dec 2023 19:49:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1703792940; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Mfa6u+A4JY5O/RVpWQxEkEK00jswtBQ3P++NeLtxCGc=; b=bPtlaywcUo2KYg6NgKQqVu35bbMB4muc5k1U3VcaCCITbecYotSj/qEi3gEp8QWkQyaMuo bxOR0KAnTSdqMdztFG5r9YUxyKcHUGZxUGvvFMQHLMfJsEV/X5XYqJXh5nKw7vgTkamW/Y AsMyKDis7lf3l5v6yFFjj/ZXIu646NBvHvshjpRTVdhTudo5uwjfeuBmU+b8TaYqQunTNu /TEA5FOTRiYqPvcYz/y7u/rIWA3U9/vILXyHZKLRpx5FJc3jDnIb+l5fSfyQ6tZSaLPlwf E4C/02Qv2EepE49dFEbNFvcNTuMYn6rBxWLYeeuulaTmn/1zQSkwSVrrbdtTXA== Date: Thu, 28 Dec 2023 20:48:59 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20231228194859.GW6420@pb2> References: <20231226163731.4147-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 1/3] avcodec/osq: Implement flush() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0849146883741715756==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0849146883741715756== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JQJYpj0es6mGpGbU" Content-Disposition: inline --JQJYpj0es6mGpGbU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 26, 2023 at 08:09:54PM +0100, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: out of array access > > Fixes: 62164/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_OSQ_fuzz= er-6227491892887552 > > Fixes: 62164/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_OSQ_fuzz= er-6268561729126400 > > Fixes: 62164/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_OSQ_fuzz= er-6414805046788096 > > Fixes: 62164/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_OSQ_fuzz= er-6538151088488448 > > Fixes: 62164/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_OSQ_fuzz= er-6608131540779008 > >=20 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz= /tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/osq.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > >=20 > > diff --git a/libavcodec/osq.c b/libavcodec/osq.c > > index 435f3ea7f69..abe15c97f18 100644 > > --- a/libavcodec/osq.c > > +++ b/libavcodec/osq.c > > @@ -61,6 +61,15 @@ typedef struct OSQContext { > > int pkt_offset; > > } OSQContext; > > =20 > > +static void osq_flush(AVCodecContext *avctx) > > +{ > > + OSQContext *s =3D avctx->priv_data; > > + > > + s->bitstream_size =3D 0; > > + s->pkt_offset =3D 0; > > + av_packet_unref(s->pkt); >=20 > s->pkt is the same as avctx->internal->in_pkt which is unreferenced > generically upon flush. So this is unnecessary. will apply without this thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Nations do behave wisely once they have exhausted all other alternatives.= =20 -- Abba Eban --JQJYpj0es6mGpGbU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZY3RJQAKCRBhHseHBAsP q9lsAJ4mxk5sGLSNFKcD+a2GXAyTJeTtfQCeOc8BO/x10TWlanJ5bmuRluRRX34= =OXsZ -----END PGP SIGNATURE----- --JQJYpj0es6mGpGbU-- --===============0849146883741715756== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0849146883741715756==--