From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 76ED247E4A for ; Thu, 28 Dec 2023 19:33:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D3AA568CC45; Thu, 28 Dec 2023 21:33:38 +0200 (EET) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CD89468CC16 for ; Thu, 28 Dec 2023 21:33:31 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 636F2E0002 for ; Thu, 28 Dec 2023 19:33:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1703792010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=opGJLLk3L6KzVYL5wCc/pkAjZuaJxCsiZ7HcZuS1pYM=; b=SrZHta51vj5/FEztnJcDAEQm+HLMjmP6bYeOrSOzb5VOayqt36F0j/dpm7N4K6iSRUC0UR AhEgVv8vwlsMYl+EYyRu2Zct/mw06WdybVdUuTfRabhcNSIWLgA6VDgcOxTCYS10Wda2hF ykDLhmYvhlN9VPQK9CVeSoKy+U/W5iP7iSvWVRNpais7oSWQw/n1e5QYvdv8ah/Aul6FcS qGq/2dJO7s07dBLrn2msn/YhdPnYb65D96roUq0zjPKuX3ojKXBm50YKnSCTd/B3RjETrJ 5c/7bPzDUb0mM30PQrW3EX3zRmESMNcpZD4QPV183UaFB2KxPEpX/Xmin0D92w== Date: Thu, 28 Dec 2023 20:33:29 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20231228193329.GV6420@pb2> References: MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avformat/rtsp: Fix server compatibility issues with rtspclientsink GStreamer plugin X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8795961598993218490==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8795961598993218490== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="t98UOKzcpBZ5uth4" Content-Disposition: inline --t98UOKzcpBZ5uth4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 27, 2023 at 03:44:09PM +0200, Paul Orlyk wrote: > mode field in Transport header can be sent in upper case so make string > comparison case insensitive. > Also, GStreamer expects to see mode=3Drecord instead of mode=3Dreceive in > Transport header in response. >=20 > Signed-off-by: Paul Orlyk > --- > libavformat/rtsp.c | 4 ++-- > libavformat/rtspdec.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c > index 583f5338e8..61e24a5c7a 100644 > --- a/libavformat/rtsp.c > +++ b/libavformat/rtsp.c > @@ -1012,8 +1012,8 @@ static void rtsp_parse_transport(AVFormatContext *s, > if (*p =3D=3D '=3D') { > p++; > get_word_sep(buf, sizeof(buf), ";, ", &p); > - if (!strcmp(buf, "record") || > - !strcmp(buf, "receive")) > + if (!av_strcasecmp(buf, "record") || > + !av_strcasecmp(buf, "receive")) > th->mode_record =3D 1; > } > } > diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c > index 39fd92fb66..d6a223cbc6 100644 > --- a/libavformat/rtspdec.c > +++ b/libavformat/rtspdec.c > @@ -303,7 +303,7 @@ static int rtsp_read_setup(AVFormatContext *s, char* > host, char *controlurl) > rtsp_st->interleaved_min =3D request.transports[0].interleaved_m= in; patch is damaged by linebreaks [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I am the wisest man alive, for I know one thing, and that is that I know nothing. -- Socrates --t98UOKzcpBZ5uth4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZY3NggAKCRBhHseHBAsP qymxAKCNEIhLuTjfoNrLumhx+ybGACpChQCggm/h9wswpw6f8zowFLN5Fy5BSWA= =qA3T -----END PGP SIGNATURE----- --t98UOKzcpBZ5uth4-- --===============8795961598993218490== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8795961598993218490==--