Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Abhishek Ojha <abhishek.ojha@savoirfairelinux.com>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] Pipewiregrab patch
Date: Wed, 27 Dec 2023 11:25:04 -0500
Message-ID: <20231227162504.690730-3-abhishek.ojha@savoirfairelinux.com> (raw)
In-Reply-To: <20231227162504.690730-1-abhishek.ojha@savoirfairelinux.com>

I wanted to express my sincere gratitude to the entire FFMPEG community for
promptly reviewing the [1] patch I submitted.

Leo,
Your insightful comments and suggestions have been invaluable in improving the
quality of the code. I appreciate your time and effort to thoroughly assessing
the patch.I wanted to inform you that I have diligently incorporated all the
review comments provided for the recent patch submission. Your feedback has
been immensely helpful in refining the code and enhancing its overall quality.

Paul B Mahol,
Thanks for the review comments. Changes are incorporated and requesting you to
please review the updated patch.

llyyr,
Thank you for testing the patch and sharing your review comments. Two patches
were submitted simultaneously, and the [2] second patch addresses the issue you
mentioned in your comments. However, I am still in need of review comments
specifically for the second patch, I'm uncertain if this approach is the
optimal solution for resolving the issue and would greatly appreciate your
feedback on it.

As a newcomer to the community, I realized that my receive email settings were
not enabled, which unfortunately prevented me from replying in the original
mail chain. Hence starting new mail chain.


[1] https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2023-September/314633.html
[2] https://ffmpeg.org//pipermail/ffmpeg-devel/2023-September/314632.html

Refrences:
1. https://pipewire.org/
2. https://github.com/flatpak/xdg-desktop-portal/
3. https://docs.pipewire.org/video-src-reneg_8c-example.html
4. https://webrtc.googlesource.com/src/+/8d9d575920a906bbf2a7b4c5b10f0ccf046f1cb8/modules/desktop_capture/linux/base_capturer_pipewire.cc

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2023-12-27 16:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-27 16:25 [FFmpeg-devel] [PATCH 1/2] libavdevice/pipewiregrab: add pipewire based grab Abhishek Ojha
2023-12-27 16:25 ` [FFmpeg-devel] [PATCH 2/2] configure: disable locale use in spa plugin Abhishek Ojha
2023-12-28 17:25   ` Rémi Denis-Courmont
2023-12-27 16:25 ` Abhishek Ojha [this message]
2024-01-25  9:52 ` [FFmpeg-devel] [PATCH 1/2] libavdevice/pipewiregrab: add pipewire based grab Anton Khirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231227162504.690730-3-abhishek.ojha@savoirfairelinux.com \
    --to=abhishek.ojha@savoirfairelinux.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git