From: Abhishek Ojha <abhishek.ojha@savoirfairelinux.com> To: ffmpeg-devel@ffmpeg.org Cc: Abhishek Ojha <abhishek.ojha@savoirfairelinux.com> Subject: [FFmpeg-devel] [PATCH 2/2] configure: disable locale use in spa plugin Date: Wed, 27 Dec 2023 11:25:03 -0500 Message-ID: <20231227162504.690730-2-abhishek.ojha@savoirfairelinux.com> (raw) In-Reply-To: <20231227162504.690730-1-abhishek.ojha@savoirfairelinux.com> This commit requires to resolve the compilation error of pipewiregrab because Pipewire's spa plugin is requesting locale_t extension to compile. Which was added in POSIX 2008 but ffmpeg is using POSIX 2001 due to which spa plugin complains. __LOCALE_C_ONLY flag is set to disable the locale usage in spa plugin. Adding it in configure file fix both the library test and source compilation issue. Not sure if this is the right approach to fix the issue. Feedback/Suggestions will be highly appreciated. Signed-off-by: Abhishek Ojha <abhishek.ojha@savoirfairelinux.com> --- configure | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure b/configure index 375327d5fa..442d004258 100755 --- a/configure +++ b/configure @@ -7106,6 +7106,8 @@ if enabled libxcb; then enabled libxcb_xfixes && check_pkg_config libxcb_xfixes xcb-xfixes xcb/xfixes.h xcb_xfixes_get_cursor_image fi +# _POSIX_C_SOURCE=200112 doesn't support locale +add_cppflags -D__LOCALE_C_ONLY enabled libpipewire && check_pkg_config libpipewire "libpipewire-0.3 >= 0.3.40" pipewire/pipewire.h pw_init if enabled libpipewire; then enabled libgio_unix && check_pkg_config libgio_unix gio-unix-2.0 gio/gio.h g_main_loop_new -- 2.34.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-12-27 16:25 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-12-27 16:25 [FFmpeg-devel] [PATCH 1/2] libavdevice/pipewiregrab: add pipewire based grab Abhishek Ojha 2023-12-27 16:25 ` Abhishek Ojha [this message] 2023-12-28 17:25 ` [FFmpeg-devel] [PATCH 2/2] configure: disable locale use in spa plugin Rémi Denis-Courmont 2023-12-27 16:25 ` [FFmpeg-devel] Pipewiregrab patch Abhishek Ojha 2024-01-25 9:52 ` [FFmpeg-devel] [PATCH 1/2] libavdevice/pipewiregrab: add pipewire based grab Anton Khirnov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231227162504.690730-2-abhishek.ojha@savoirfairelinux.com \ --to=abhishek.ojha@savoirfairelinux.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git