From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Paul B Mahol <onemda@gmail.com>
Subject: [FFmpeg-devel] [PATCH 4/4] avfilter/af_stereotools: round-up max size of buffer
Date: Mon, 25 Dec 2023 00:26:24 +0100
Message-ID: <20231224232624.30355-4-michael@niedermayer.cc> (raw)
In-Reply-To: <20231224232624.30355-1-michael@niedermayer.cc>
From: Paul B Mahol <onemda@gmail.com>
Fixes: out of array access
Fixes: tickets/10747/poc14ffmpeg
Found-by: Zeng Yunxiang and Song Jiaxuan
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
libavfilter/af_stereotools.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/af_stereotools.c b/libavfilter/af_stereotools.c
index 4bcd696cf90..915edecc539 100644
--- a/libavfilter/af_stereotools.c
+++ b/libavfilter/af_stereotools.c
@@ -119,7 +119,7 @@ static int config_input(AVFilterLink *inlink)
AVFilterContext *ctx = inlink->dst;
StereoToolsContext *s = ctx->priv;
- s->length = FFALIGN(inlink->sample_rate / 10, 2);
+ s->length = FFALIGN((inlink->sample_rate + 9) / 10, 2);
if (!s->buffer)
s->buffer = av_calloc(s->length, sizeof(*s->buffer));
if (!s->buffer)
--
2.17.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-12-24 23:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-24 23:26 [FFmpeg-devel] [PATCH 1/4] avfilter/af_stereowiden: Round length to nearest Michael Niedermayer
2023-12-24 23:26 ` [FFmpeg-devel] [PATCH 2/4] avfilter/avf_showspectrum: fix off by 1 error Michael Niedermayer
2023-12-24 23:26 ` [FFmpeg-devel] [PATCH 3/4] avfilter/vf_gradfun: Do not overread last line Michael Niedermayer
2023-12-24 23:26 ` Michael Niedermayer [this message]
2023-12-29 0:19 ` [FFmpeg-devel] [PATCH 1/4] avfilter/af_stereowiden: Round length to nearest Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231224232624.30355-4-michael@niedermayer.cc \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=onemda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git