From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH 3/3] avcodec/takdsp: fix const correctness
Date: Fri, 22 Dec 2023 09:12:32 -0300
Message-ID: <20231222121232.324-3-jamrial@gmail.com> (raw)
In-Reply-To: <20231222121232.324-1-jamrial@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>
---
libavcodec/riscv/takdsp_init.c | 4 ++--
libavcodec/takdsp.c | 6 +++---
libavcodec/takdsp.h | 6 +++---
libavcodec/x86/takdsp_init.c | 12 ++++++------
tests/checkasm/takdsp.c | 6 +++---
5 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/libavcodec/riscv/takdsp_init.c b/libavcodec/riscv/takdsp_init.c
index 0b4ec18086..2d5c974459 100644
--- a/libavcodec/riscv/takdsp_init.c
+++ b/libavcodec/riscv/takdsp_init.c
@@ -25,8 +25,8 @@
#include "libavutil/riscv/cpu.h"
#include "libavcodec/takdsp.h"
-void ff_decorrelate_ls_rvv(int32_t *p1, int32_t *p2, int length);
-void ff_decorrelate_sr_rvv(int32_t *p1, int32_t *p2, int length);
+void ff_decorrelate_ls_rvv(const int32_t *p1, int32_t *p2, int length);
+void ff_decorrelate_sr_rvv(int32_t *p1, const int32_t *p2, int length);
av_cold void ff_takdsp_init_riscv(TAKDSPContext *dsp)
{
diff --git a/libavcodec/takdsp.c b/libavcodec/takdsp.c
index 25cac558ce..51b6658de4 100644
--- a/libavcodec/takdsp.c
+++ b/libavcodec/takdsp.c
@@ -23,7 +23,7 @@
#include "takdsp.h"
#include "config.h"
-static void decorrelate_ls(int32_t *p1, int32_t *p2, int length)
+static void decorrelate_ls(const int32_t *p1, int32_t *p2, int length)
{
int i;
@@ -34,7 +34,7 @@ static void decorrelate_ls(int32_t *p1, int32_t *p2, int length)
}
}
-static void decorrelate_sr(int32_t *p1, int32_t *p2, int length)
+static void decorrelate_sr(int32_t *p1, const int32_t *p2, int length)
{
int i;
@@ -58,7 +58,7 @@ static void decorrelate_sm(int32_t *p1, int32_t *p2, int length)
}
}
-static void decorrelate_sf(int32_t *p1, int32_t *p2, int length, int dshift, int dfactor)
+static void decorrelate_sf(int32_t *p1, const int32_t *p2, int length, int dshift, int dfactor)
{
int i;
diff --git a/libavcodec/takdsp.h b/libavcodec/takdsp.h
index 55f1a10cd3..13b5e530b2 100644
--- a/libavcodec/takdsp.h
+++ b/libavcodec/takdsp.h
@@ -22,10 +22,10 @@
#include <stdint.h>
typedef struct TAKDSPContext {
- void (*decorrelate_ls)(int32_t *p1, int32_t *p2, int length);
- void (*decorrelate_sr)(int32_t *p1, int32_t *p2, int length);
+ void (*decorrelate_ls)(const int32_t *p1, int32_t *p2, int length);
+ void (*decorrelate_sr)(int32_t *p1, const int32_t *p2, int length);
void (*decorrelate_sm)(int32_t *p1, int32_t *p2, int length);
- void (*decorrelate_sf)(int32_t *p1, int32_t *p2, int length, int dshift, int dfactor);
+ void (*decorrelate_sf)(int32_t *p1, const int32_t *p2, int length, int dshift, int dfactor);
} TAKDSPContext;
void ff_takdsp_init(TAKDSPContext *c);
diff --git a/libavcodec/x86/takdsp_init.c b/libavcodec/x86/takdsp_init.c
index c99a057b24..9553f8442c 100644
--- a/libavcodec/x86/takdsp_init.c
+++ b/libavcodec/x86/takdsp_init.c
@@ -23,14 +23,14 @@
#include "libavutil/x86/cpu.h"
#include "config.h"
-void ff_tak_decorrelate_ls_sse2(int32_t *p1, int32_t *p2, int length);
-void ff_tak_decorrelate_ls_avx2(int32_t *p1, int32_t *p2, int length);
-void ff_tak_decorrelate_sr_sse2(int32_t *p1, int32_t *p2, int length);
-void ff_tak_decorrelate_sr_avx2(int32_t *p1, int32_t *p2, int length);
+void ff_tak_decorrelate_ls_sse2(const int32_t *p1, int32_t *p2, int length);
+void ff_tak_decorrelate_ls_avx2(const int32_t *p1, int32_t *p2, int length);
+void ff_tak_decorrelate_sr_sse2(int32_t *p1, const int32_t *p2, int length);
+void ff_tak_decorrelate_sr_avx2(int32_t *p1, const int32_t *p2, int length);
void ff_tak_decorrelate_sm_sse2(int32_t *p1, int32_t *p2, int length);
void ff_tak_decorrelate_sm_avx2(int32_t *p1, int32_t *p2, int length);
-void ff_tak_decorrelate_sf_sse4(int32_t *p1, int32_t *p2, int length, int dshift, int dfactor);
-void ff_tak_decorrelate_sf_avx2(int32_t *p1, int32_t *p2, int length, int dshift, int dfactor);
+void ff_tak_decorrelate_sf_sse4(int32_t *p1, const int32_t *p2, int length, int dshift, int dfactor);
+void ff_tak_decorrelate_sf_avx2(int32_t *p1, const int32_t *p2, int length, int dshift, int dfactor);
av_cold void ff_takdsp_init_x86(TAKDSPContext *c)
{
diff --git a/tests/checkasm/takdsp.c b/tests/checkasm/takdsp.c
index 78528b1c5d..fd4122f34b 100644
--- a/tests/checkasm/takdsp.c
+++ b/tests/checkasm/takdsp.c
@@ -37,7 +37,7 @@
#define BUF_SIZE 1024
static void test_decorrelate_ls(TAKDSPContext *s) {
- declare_func(void, int32_t *, int32_t *, int);
+ declare_func(void, const int32_t *, int32_t *, int);
if (check_func(s->decorrelate_ls, "decorrelate_ls")) {
LOCAL_ALIGNED_32(int32_t, p1, [BUF_SIZE]);
@@ -62,7 +62,7 @@ static void test_decorrelate_ls(TAKDSPContext *s) {
}
static void test_decorrelate_sr(TAKDSPContext *s) {
- declare_func(void, int32_t *, int32_t *, int);
+ declare_func(void, int32_t *, const int32_t *, int);
if (check_func(s->decorrelate_sr, "decorrelate_sr")) {
LOCAL_ALIGNED_32(int32_t, p1, [BUF_SIZE]);
@@ -115,7 +115,7 @@ static void test_decorrelate_sm(TAKDSPContext *s) {
}
static void test_decorrelate_sf(TAKDSPContext *s) {
- declare_func(void, int32_t *, int32_t *, int, int, int);
+ declare_func(void, int32_t *, const int32_t *, int, int, int);
if (check_func(s->decorrelate_sf, "decorrelate_sf")) {
LOCAL_ALIGNED_32(int32_t, p1, [BUF_SIZE]);
--
2.43.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-12-22 12:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 12:12 [FFmpeg-devel] [PATCH 1/3 v2] checkasm/takdsp: add decorrelate_sf test James Almer
2023-12-22 12:12 ` [FFmpeg-devel] [PATCH 2/3 v2] x86/takdsp: add avx2 versions of all functions James Almer
2023-12-22 12:12 ` James Almer [this message]
2023-12-22 12:17 ` [FFmpeg-devel] [PATCH 3/3] avcodec/takdsp: fix const correctness Martin Storsjö
2023-12-22 12:16 ` [FFmpeg-devel] [PATCH 1/3 v2] checkasm/takdsp: add decorrelate_sf test Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231222121232.324-3-jamrial@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git