From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH 1/3 v2] checkasm/takdsp: add decorrelate_sf test
Date: Fri, 22 Dec 2023 09:12:30 -0300
Message-ID: <20231222121232.324-1-jamrial@gmail.com> (raw)
Signed-off-by: James Almer <jamrial@gmail.com>
---
Fixes broken logic as reported by Martin.
tests/checkasm/takdsp.c | 35 ++++++++++++++++++++++++++++++++---
1 file changed, 32 insertions(+), 3 deletions(-)
diff --git a/tests/checkasm/takdsp.c b/tests/checkasm/takdsp.c
index 3aecee1f72..78528b1c5d 100644
--- a/tests/checkasm/takdsp.c
+++ b/tests/checkasm/takdsp.c
@@ -24,6 +24,7 @@
#include "libavutil/mem_internal.h"
#include "libavcodec/takdsp.h"
+#include "libavcodec/mathops.h"
#include "checkasm.h"
@@ -33,8 +34,9 @@
buf[i] = rnd(); \
} while (0)
-static void test_decorrelate_ls(TAKDSPContext *s) {
#define BUF_SIZE 1024
+
+static void test_decorrelate_ls(TAKDSPContext *s) {
declare_func(void, int32_t *, int32_t *, int);
if (check_func(s->decorrelate_ls, "decorrelate_ls")) {
@@ -60,7 +62,6 @@ static void test_decorrelate_ls(TAKDSPContext *s) {
}
static void test_decorrelate_sr(TAKDSPContext *s) {
-#define BUF_SIZE 1024
declare_func(void, int32_t *, int32_t *, int);
if (check_func(s->decorrelate_sr, "decorrelate_sr")) {
@@ -86,7 +87,6 @@ static void test_decorrelate_sr(TAKDSPContext *s) {
}
static void test_decorrelate_sm(TAKDSPContext *s) {
-#define BUF_SIZE 1024
declare_func(void, int32_t *, int32_t *, int);
if (check_func(s->decorrelate_sm, "decorrelate_sm")) {
@@ -114,6 +114,34 @@ static void test_decorrelate_sm(TAKDSPContext *s) {
report("decorrelate_sm");
}
+static void test_decorrelate_sf(TAKDSPContext *s) {
+ declare_func(void, int32_t *, int32_t *, int, int, int);
+
+ if (check_func(s->decorrelate_sf, "decorrelate_sf")) {
+ LOCAL_ALIGNED_32(int32_t, p1, [BUF_SIZE]);
+ LOCAL_ALIGNED_32(int32_t, p1_2, [BUF_SIZE]);
+ LOCAL_ALIGNED_32(int32_t, p2, [BUF_SIZE]);
+ int dshift, dfactor;
+
+ randomize(p1, BUF_SIZE);
+ memcpy(p1_2, p1, BUF_SIZE * sizeof(*p1));
+ randomize(p2, BUF_SIZE);
+ dshift = (rnd() & 0xF) + 1;
+ dfactor = sign_extend(rnd(), 10);
+
+ call_ref(p1, p2, BUF_SIZE, dshift, dfactor);
+ call_new(p1_2, p2, BUF_SIZE, dshift, dfactor);
+
+ if (memcmp(p1, p1_2, BUF_SIZE) != 0) {
+ fail();
+ }
+
+ bench_new(p1, p2, BUF_SIZE, dshift, dfactor);
+ }
+
+ report("decorrelate_sf");
+}
+
void checkasm_check_takdsp(void)
{
TAKDSPContext s = { 0 };
@@ -122,4 +150,5 @@ void checkasm_check_takdsp(void)
test_decorrelate_ls(&s);
test_decorrelate_sr(&s);
test_decorrelate_sm(&s);
+ test_decorrelate_sf(&s);
}
--
2.43.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2023-12-22 12:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 12:12 James Almer [this message]
2023-12-22 12:12 ` [FFmpeg-devel] [PATCH 2/3 v2] x86/takdsp: add avx2 versions of all functions James Almer
2023-12-22 12:12 ` [FFmpeg-devel] [PATCH 3/3] avcodec/takdsp: fix const correctness James Almer
2023-12-22 12:17 ` Martin Storsjö
2023-12-22 12:16 ` [FFmpeg-devel] [PATCH 1/3 v2] checkasm/takdsp: add decorrelate_sf test Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231222121232.324-1-jamrial@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git