From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AC12B48847 for ; Mon, 18 Dec 2023 17:21:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 551EF68D042; Mon, 18 Dec 2023 19:21:39 +0200 (EET) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4F28068CEF4 for ; Mon, 18 Dec 2023 19:21:33 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 53C2E20009 for ; Mon, 18 Dec 2023 17:21:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1702920092; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wUoOW143XY7RRClqgxeBSYC/axztjX3kzMWqKED7EVM=; b=dNnliBNrWUng+1+G30Rlkgy6VLgd21c+V93mSh6w+vm9dvDPzp77u9HLyGqZg3WJtXaPSl wH3cFzULfwTw8U4+f43WRC62SssWELtdKLR3kauingmzCqPMf88+EM9jbvYSckAVh+pagg sypcv4PLAHxaBzMqol7XtoxNwJiBEEJVFjaIQN46ZI01FQBavQq0FZWsmbjri76xrsdHHP SB3W1yOsQQ5eXBKcmogFS9AcNlYIVzO566NrvtZgGsm5Y7WhAWEbvet/pN3RSJ2YN4O4gW JaCp9ZvGVM9wMWovQMA08xSDMXuYhcADMT6lvBSCryNmjuyk5VZE7TuPOWr3og== Date: Mon, 18 Dec 2023 18:21:31 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20231218172131.GW6420@pb2> References: <20231217091343.34077-1-remi@remlab.net> <163c77ca-2bee-4ae5-bdab-faeb8c87281c@gmail.com> <1728283.6a2RTAW4fK@basile.remlab.net> <4a48315-3857-81c6-11a-99a99db8ee4@martin.st> MIME-Version: 1.0 In-Reply-To: <4a48315-3857-81c6-11a-99a99db8ee4@martin.st> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCHv2 1/1] checkasm/lpc: test compute_autocorr X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6734151390503304918==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6734151390503304918== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AFjAQ8ujNJnIGHaX" Content-Disposition: inline --AFjAQ8ujNJnIGHaX Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 17, 2023 at 11:57:50PM +0200, Martin Storsj=F6 wrote: [...] > FWIW, we've had these situations elsewhere before as well, in swscale, wh= ere > the existing x86 assembly mismatches the C code in nontrivial ways, and we > have new assembly (aarch64 in that case) that is missing a test (even if = one > was written) due to this. >=20 > First I considered if we should collect these extra checkasm tests in some > branch somewhere, so they aren't lost, as they are useful when working on > assembly on other architectures. >=20 > But rather than having the code rot, forgotten in a stray branch somewher= e, > I wonder if we should just go ahead and merge it with an #if !ARCH_X86 or > something, together with a notable FIXME comment. +1 i suggest, if its easy rather than disabling, adjust the threshold thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many that live deserve death. And some that die deserve life. Can you give it to them? Then do not be too eager to deal out death in judgement. For even the very wise cannot see all ends. -- Gandalf --AFjAQ8ujNJnIGHaX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZYB/lwAKCRBhHseHBAsP q0c6AJ96q54Cxz/HS3uUjtrgSO7b8PwFowCcCkNlNWsrJuAiWX0WcxGjrjM8fSg= =+wm4 -----END PGP SIGNATURE----- --AFjAQ8ujNJnIGHaX-- --===============6734151390503304918== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6734151390503304918==--